Re: [PR] Fix TestHnswQueueSaturationCollector#testEarlyExitRelation with k==0 [lucene]

2025-04-03 Thread via GitHub
tteofili merged PR #14434: URL: https://github.com/apache/lucene/pull/14434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Reduce the number of comparisons when lowerPoint is equal to upperPoint [lucene]

2025-04-03 Thread via GitHub
jainankitk commented on code in PR #14267: URL: https://github.com/apache/lucene/pull/14267#discussion_r2026298829 ## lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java: ## @@ -120,381 +132,475 @@ public void visit(QueryVisitor visitor) { public final Weight c

[PR] Fix TestHnswQueueSaturationCollector#testEarlyExitRelation with k==0 [lucene]

2025-04-03 Thread via GitHub
tteofili opened a new pull request, #14434: URL: https://github.com/apache/lucene/pull/14434 Fix for test failure in `TestHnswQueueSaturationCollector#testEarlyExitRelation` when `k` is equals `0`. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Remove slices creation overhead from IndexSearcher constructor [lucene]

2025-04-03 Thread via GitHub
javanna commented on code in PR #14428: URL: https://github.com/apache/lucene/pull/14428#discussion_r2026397746 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {

Re: [PR] KeywordField.newSetQuery() to uses prefixed terms for IndexOrDocValuesQuery [lucene]

2025-04-03 Thread via GitHub
mkhludnev commented on code in PR #14435: URL: https://github.com/apache/lucene/pull/14435#discussion_r2028113898 ## lucene/core/src/java/org/apache/lucene/document/KeywordField.java: ## @@ -175,9 +174,8 @@ public static Query newExactQuery(String field, String value) { publ

Re: [PR] Disable HNSW connectedComponents (#14214) [lucene]

2025-04-03 Thread via GitHub
txwei commented on PR #14436: URL: https://github.com/apache/lucene/pull/14436#issuecomment-2776535607 Can we backport this to 9.12 and cut a 9.12.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Revert "gh-12627: HnswGraphBuilder connects disconnected HNSW graph components (#13566)" [lucene]

2025-04-03 Thread via GitHub
txwei closed pull request #14411: Revert "gh-12627: HnswGraphBuilder connects disconnected HNSW graph components (#13566)" URL: https://github.com/apache/lucene/pull/14411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Revert "gh-12627: HnswGraphBuilder connects disconnected HNSW graph components (#13566)" [lucene]

2025-04-03 Thread via GitHub
benwtrent commented on PR #14411: URL: https://github.com/apache/lucene/pull/14411#issuecomment-2776556167 Thanks for pushing on this @txwei I think disabling is indeed what we should do until its fixed. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-03 Thread via GitHub
jpountz commented on PR #14333: URL: https://github.com/apache/lucene/pull/14333#issuecomment-2776835446 > I thought i only need to fork a Lucene103BlockTreeTerms to intersect with Lucene101Postings. But it seems challenging based on current API design. I have to fork the new Lucene103Posti

Re: [PR] A specialized Trie for Block Tree Index [lucene]

2025-04-03 Thread via GitHub
jpountz commented on code in PR #14333: URL: https://github.com/apache/lucene/pull/14333#discussion_r2027695983 ## lucene/core/src/java/org/apache/lucene/codecs/lucene103/Lucene103PostingsFormat.java: ## @@ -0,0 +1,510 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [I] develocity build scans fail to upload sometimes [lucene]

2025-04-03 Thread via GitHub
dweiss commented on issue #14305: URL: https://github.com/apache/lucene/issues/14305#issuecomment-2776872477 Sadly, yes - this message is still emitted: https://ci-builds.apache.org/job/Lucene/job/Lucene-NightlyTests-main/1619/console ``` The Develocity server (develocity.apache.org

Re: [PR] New IndexReaderFunctions.positionLength from the norm [lucene]

2025-04-03 Thread via GitHub
dsmiley commented on PR #14433: URL: https://github.com/apache/lucene/pull/14433#issuecomment-2777428910 Thanks for the historical context! I can definitely add more docs; I started with the bare minimum. Definitely need to emphasize a dependency on the default `computeNorm` formula!

Re: [PR] Remove slices creation overhead from IndexSearcher constructor [lucene]

2025-04-03 Thread via GitHub
jainankitk commented on code in PR #14428: URL: https://github.com/apache/lucene/pull/14428#discussion_r2027340846 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {

Re: [PR] Add support for determining off-heap memory requirements for KnnVectorsReader [lucene]

2025-04-03 Thread via GitHub
ChrisHegarty commented on code in PR #14426: URL: https://github.com/apache/lucene/pull/14426#discussion_r2027373074 ## lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java: ## @@ -130,4 +134,56 @@ public KnnVectorsReader getMergeInstance() { * The default imp

Re: [I] Skip data should be inlined into the postings lists [LUCENE-2962] [lucene]

2025-04-03 Thread via GitHub
jpountz commented on issue #4036: URL: https://github.com/apache/lucene/issues/4036#issuecomment-2775810196 Addressed by #13585. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] Skip data should be inlined into the postings lists [LUCENE-2962] [lucene]

2025-04-03 Thread via GitHub
jpountz closed issue #4036: Skip data should be inlined into the postings lists [LUCENE-2962] URL: https://github.com/apache/lucene/issues/4036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] develocity build scans fail to upload sometimes [lucene]

2025-04-03 Thread via GitHub
iverase commented on issue #14305: URL: https://github.com/apache/lucene/issues/14305#issuecomment-2775489317 @dweiss The milestone is set to 10.2 for this issue. Is this still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] TestIndexSortBackwardsCompatibility.testSortedIndexAddDocBlocks fails reproducibly [lucene]

2025-04-03 Thread via GitHub
iverase commented on issue #14344: URL: https://github.com/apache/lucene/issues/14344#issuecomment-2775491412 @dweiss The milestone is set to 10.2 for this issue. Is this still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] Revert "Add UnwrappingReuseStrategy for AnalyzerWrapper (#14154)" [lucene]

2025-04-03 Thread via GitHub
mayya-sharipova opened a new pull request, #14437: URL: https://github.com/apache/lucene/pull/14437 This reverts commit 1a676b64f89069284bf7d0510162f8095bba3980. Revert based on https://github.com/apache/lucene/pull/14430 -- This is an automated message from the Apache Git Servi

Re: [I] UnsupportedOperation when merging `Lucene90BlockTreeTermsWriter` [lucene]

2025-04-03 Thread via GitHub
benwtrent commented on issue #14429: URL: https://github.com/apache/lucene/issues/14429#issuecomment-2775445981 Thank you @mikemccand for some details! > Do we know any fun details about the use case? Maybe an exotic/old JVM? Massive numbers of terms...? Or the terms are some crazy bi

Re: [PR] OptimisticKnnVectorQuery [lucene]

2025-04-03 Thread via GitHub
dungba88 commented on PR #14226: URL: https://github.com/apache/lucene/pull/14226#issuecomment-2775842169 I'm also in favor of making this the default behavior. Maybe we can let the lambda parameter to be tuned with a reasonable default value (similar to greediness in the current collector)