jainankitk commented on code in PR #14428:
URL: https://github.com/apache/lucene/pull/14428#discussion_r2027340846
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor
executor) {
executor == null ? new TaskExecutor(Runnable::run) : new
TaskExecutor(executor);
Review Comment:
> And by the way, I am still on the fence on whether this is a good change
to start with. The overhead caused by the single slice creation that we
observed is surprising.
While I don't see any downsides of having this change, especially when lazy
creation was the original behavior. Although, I am really curious now how did
we observe the overhead? Was that through some metrics / flamegraph and
wondering if you can share that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
