jainankitk commented on code in PR #14267:
URL: https://github.com/apache/lucene/pull/14267#discussion_r2026298829
##########
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java:
##########
@@ -120,381 +132,475 @@ public void visit(QueryVisitor visitor) {
public final Weight createWeight(IndexSearcher searcher, ScoreMode
scoreMode, float boost)
throws IOException {
+ if (this.equalValues) { // lowerPoint==upperPoint
+ return new SinglePointRangeQueryWeight(this, scoreMode, boost);
+ }
// We don't use RandomAccessWeight here: it's no good to approximate with
"match all docs".
// This is an inverted structure and should be used in the first pass:
+ return new MultiPointRangeQueryWeight(this, scoreMode, boost);
+ }
- return new ConstantScoreWeight(this, boost) {
+ /**
+ * Single-point range query weight implementation class, used to handle the
special case where the
+ * lower and upper bounds are equal (i.e. single-point query).
+ *
+ * <p>Optimize query performance by reducing the number of comparisons
between dimensions. This
+ * implementation is used when the upper and lower bounds of all dimensions
are exactly the same.
+ */
+ protected class SinglePointRangeQueryWeight extends PointRangeQueryWeight {
Review Comment:
Yeah, they can be `private` in my opinion as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
