javanna commented on code in PR #14428:
URL: https://github.com/apache/lucene/pull/14428#discussion_r2026397746
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -223,12 +223,6 @@ public IndexSearcher(IndexReaderContext context, Executor
executor) {
executor == null ? new TaskExecutor(Runnable::run) : new
TaskExecutor(executor);
Review Comment:
yes we do, this got lost among other changes I reverted in my branch. I also
need to add a test to catch similar bugs. And by the way, I am still on the
fence on whether this is a good change to start with. The overhead caused by
the single slice creation that we observed is surprising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
