Re: [PR] Remove usage of IndexSearcher#Search(Query, Collector) from monitor package [lucene]

javanna commented on code in PR #13735: URL: https://github.com/apache/lucene/pull/13735#discussion_r1751543562 ## lucene/core/src/java/org/apache/lucene/search/CollectorManager.java: ## @@ -46,4 +48,28 @@ public interface CollectorManager { * called after collection is fini

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1751550108 ## lucene/misc/src/java/org/apache/lucene/misc/util/fst/UpToTwoPositiveIntOutputs.java: ## @@ -42,36 +42,11 @@ public final class UpToTwoPositiveIntOutputs exten

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1751558206 ## lucene/core/src/java/org/apache/lucene/util/FixedBits.java: ## @@ -17,15 +17,7 @@ package org.apache.lucene.util; /** Immutable twin of FixedBitSet. */ -fi

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1751557625 ## lucene/test-framework/src/java/org/apache/lucene/tests/codecs/asserting/AssertingLiveDocsFormat.java: ## @@ -68,9 +68,7 @@ public String toString() { retu

Re: [PR] Remove usage of IndexSearcher#Search(Query, Collector) from monitor package [lucene]

javanna commented on code in PR #13735: URL: https://github.com/apache/lucene/pull/13735#discussion_r1751560638 ## lucene/core/src/java/org/apache/lucene/search/CollectorManager.java: ## @@ -46,4 +48,28 @@ public interface CollectorManager { * called after collection is fini

Re: [PR] add TFSimilarity class [lucene]

cpoerschke commented on PR #13749: URL: https://github.com/apache/lucene/pull/13749#issuecomment-2340084262 > ... use the TF like a payload ... Initially I thought that this would require a custom `Term[Query|Scorer]` style change but then from a brief chat with @seanmacavaney (thank

[PR] add TFSimilarity class [lucene]

cpoerschke opened a new pull request, #13749: URL: https://github.com/apache/lucene/pull/13749 Motivation is to use the TF like a payload but without needing to have payloads and positions. see also #13731 `PayloadScoreQuery` javadoc update w.r.t. `SpanQuery` use -- This is an

Re: [PR] add TFSimilarity class [lucene]

seanmacavaney commented on code in PR #13749: URL: https://github.com/apache/lucene/pull/13749#discussion_r1751677536 ## lucene/core/src/java/org/apache/lucene/search/similarities/TFSimilarity.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] add TFSimilarity class [lucene]

cpoerschke commented on code in PR #13749: URL: https://github.com/apache/lucene/pull/13749#discussion_r1751688741 ## lucene/core/src/java/org/apache/lucene/search/similarities/TFSimilarity.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Provide a custom hash implementation in HnswLock [lucene]

dweiss commented on code in PR #13751: URL: https://github.com/apache/lucene/pull/13751#discussion_r1751723180 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswLock.java: ## @@ -67,4 +66,10 @@ public void close() { lock.unlock(); } } + + static int hash(in

Re: [PR] Remove usage of IndexSearcher#search(Query, Collector) from join package [lucene]

javanna commented on code in PR #13747: URL: https://github.com/apache/lucene/pull/13747#discussion_r1751774184 ## lucene/join/src/java/org/apache/lucene/search/join/JoinUtil.java: ## @@ -530,49 +528,104 @@ public static Query createJoinQuery( final Query rewrittenFromQue

Re: [PR] Add support for intra-segment search concurrency [lucene]

mikemccand commented on code in PR #13542: URL: https://github.com/apache/lucene/pull/13542#discussion_r1751974584 ## lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java: ## @@ -28,17 +36,114 @@ */ public class TotalHitCountCollectorManager i

Re: [PR] Convert more classes to record classes [lucene]

mikemccand commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752005115 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Add Bulk Scorer For ToParentBlockJoinQuery [lucene]

Mikep86 commented on code in PR #13697: URL: https://github.com/apache/lucene/pull/13697#discussion_r1752115832 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -242,14 +242,25 @@ public int nextDoc() throws IOException { @Override

Re: [PR] Add support for intra-segment search concurrency [lucene]

reta commented on code in PR #13542: URL: https://github.com/apache/lucene/pull/13542#discussion_r1752230454 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -233,7 +235,13 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {

Re: [PR] Add dynamic range facets [lucene]

stefanvodita commented on PR #13689: URL: https://github.com/apache/lucene/pull/13689#issuecomment-2341420365 I've addressed the feedback and there don't seem to be any blockers. Thank you Mike and Robert for reviewing! -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Add dynamic range facets [lucene]

stefanvodita merged PR #13689: URL: https://github.com/apache/lucene/pull/13689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucen

Re: [PR] DrillSideways#search: use bounded wildcard for the list of drill-sideways CollectorManagers [lucene]

stefanvodita commented on PR #13750: URL: https://github.com/apache/lucene/pull/13750#issuecomment-2341497570 @epotyom - could you still add a CHANGES entry to keep track of this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Add Bulk Scorer For ToParentBlockJoinQuery [lucene]

Mikep86 commented on code in PR #13697: URL: https://github.com/apache/lucene/pull/13697#discussion_r1752115832 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -242,14 +242,25 @@ public int nextDoc() throws IOException { @Override

Re: [PR] Add Bulk Scorer For ToParentBlockJoinQuery [lucene]

Mikep86 commented on code in PR #13697: URL: https://github.com/apache/lucene/pull/13697#discussion_r1752115832 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -242,14 +242,25 @@ public int nextDoc() throws IOException { @Override

Re: [I] Should KNN indexing throw an exception if `beamWidth < maxConn` to alert users to misconfiguration? [lucene]

mikemccand closed issue #13752: Should KNN indexing throw an exception if `beamWidth < maxConn` to alert users to misconfiguration? URL: https://github.com/apache/lucene/issues/13752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Reorder checks in LRUQueryCache#count [lucene]

jpountz merged PR #13742: URL: https://github.com/apache/lucene/pull/13742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add support for intra-segment search concurrency [lucene]

reta commented on code in PR #13542: URL: https://github.com/apache/lucene/pull/13542#discussion_r1752702414 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -233,7 +235,13 @@ public IndexSearcher(IndexReaderContext context, Executor executor) {

Re: [PR] Add support for intra-segment search concurrency [lucene]

javanna commented on code in PR #13542: URL: https://github.com/apache/lucene/pull/13542#discussion_r1752702691 ## lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java: ## @@ -142,7 +142,7 @@ protected Facets buildFacetsResult( private IndexSearcher getNewSear

[I] DrillSideways does not support intra-segment concurrency [lucene]

javanna opened a new issue, #13753: URL: https://github.com/apache/lucene/issues/13753 With the introduction of intra-segment search concurrency (see #13542), `DrillSideways` is the only case that disables it in tests which can't support intra-segment slicing given its implementation requir

Re: [PR] Replace Map with IntObjectHashMap for DV producer [lucene]

jpountz merged PR #13686: URL: https://github.com/apache/lucene/pull/13686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add dynamic range facets [lucene]

stefanvodita commented on code in PR #13689: URL: https://github.com/apache/lucene/pull/13689#discussion_r1752721942 ## lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java: ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Convert more classes to record classes [lucene]

jpountz merged PR #13328: URL: https://github.com/apache/lucene/pull/13328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Add AbstractKnnVectorQuery.seed for seeded HNSW [lucene]

benwtrent commented on PR #13635: URL: https://github.com/apache/lucene/pull/13635#issuecomment-2342018139 I haven't been able to review fully, but will soon. I like this idea. Do you have any scripts & test data where you have tested that this Lucene implementation works and gives a

Re: [PR] Add support for intra-segment search concurrency [lucene]

javanna commented on PR #13542: URL: https://github.com/apache/lucene/pull/13542#issuecomment-2342018120 Thanks all for the feedback and reviews! The journey only begins as this PR is getting merged, looking forward to making intra-segment concurrency support shine soon :) -- This is an

Re: [PR] Add support for intra-segment search concurrency [lucene]

javanna merged PR #13542: URL: https://github.com/apache/lucene/pull/13542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [I] Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] [lucene]

javanna closed issue #9721: Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] URL: https://github.com/apache/lucene/issues/9721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] [lucene]

javanna closed issue #9721: Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] URL: https://github.com/apache/lucene/issues/9721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Convert more classes to record classes [lucene]

stefanvodita commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2342037249 I think we've run into a conflict with #13689. @jpountz - should I fix that or are you already doing it? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Convert more classes to record classes [lucene]

jpountz commented on PR #13328: URL: https://github.com/apache/lucene/pull/13328#issuecomment-2342059732 @javanna just fixed it, thanks @javanna ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update QueryUtils to use CollectorManager [lucene]

msfroh commented on code in PR #13748: URL: https://github.com/apache/lucene/pull/13748#discussion_r1752775181 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/QueryUtils.java: ## @@ -345,175 +348,201 @@ public static void checkSkipTo(final Query q, final IndexS

Re: [PR] Add dynamic range facets [lucene]

stefanvodita commented on code in PR #13689: URL: https://github.com/apache/lucene/pull/13689#discussion_r1752721942 ## lucene/facet/src/java/org/apache/lucene/facet/range/DynamicRangeUtil.java: ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Update QueryUtils to use CollectorManager [lucene]

javanna commented on code in PR #13748: URL: https://github.com/apache/lucene/pull/13748#discussion_r1752834380 ## lucene/test-framework/src/java/org/apache/lucene/tests/search/QueryUtils.java: ## @@ -345,175 +348,201 @@ public static void checkSkipTo(final Query q, final Index

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752842660 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752842660 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752860507 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == result.

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752842660 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeight

Re: [PR] Remove usage of IndexSearcher#search(Query, Collector) from join package [lucene]

msfroh commented on code in PR #13747: URL: https://github.com/apache/lucene/pull/13747#discussion_r1752887025 ## lucene/join/src/java/org/apache/lucene/search/join/JoinUtil.java: ## @@ -530,49 +528,104 @@ public static Query createJoinQuery( final Query rewrittenFromQuer

Re: [PR] Convert more classes to record classes [lucene]

uschindler commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1752895892 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == result.

Re: [PR] Use range optimizations for "slow" MultiTermQueries when terms happen to be contiguous [lucene]

github-actions[bot] commented on PR #13693: URL: https://github.com/apache/lucene/pull/13693#issuecomment-2342381311 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Implement Accountable for NFARunAutomaton [lucene]

zhaih merged PR #13741: URL: https://github.com/apache/lucene/pull/13741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

Re: [PR] add TFSimilarity class [lucene]

rmuir commented on code in PR #13749: URL: https://github.com/apache/lucene/pull/13749#discussion_r1752981586 ## lucene/core/src/java/org/apache/lucene/search/similarities/TFSimilarity.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] Remove usage of IndexSearcher#search(Query, Collector) from join package [lucene]

msfroh commented on PR #13747: URL: https://github.com/apache/lucene/pull/13747#issuecomment-2342434431 @javanna -- I've managed to get the remaining numeric / terms collectors in the Join module working with multiple search threads. I can add them to this PR, but the diff is pretty

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1753129302 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java: ## @@ -163,11 +156,6 @@ public boolean equals(Object o) { FieldAndWeig

Re: [PR] Convert more classes to record classes [lucene]

shubhamvishu commented on code in PR #13328: URL: https://github.com/apache/lucene/pull/13328#discussion_r1753134745 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreAccumulator.java: ## @@ -101,11 +93,6 @@ public boolean equals(Object o) { return docBase == resul

[I] Nightly gh action "buildAndPushRelease and smokeTestRelease.py" should save release.log on failure [lucene]

dweiss opened a new issue, #13754: URL: https://github.com/apache/lucene/issues/13754 ### Description It'll be useful to diagnose problems in case of failures, such as this one: https://github.com/apache/lucene/actions/runs/10803880083/job/29968434986 ### Version and environm

Re: [I] Nightly gh action "buildAndPushRelease and smokeTestRelease.py" should save release.log on failure [lucene]

dweiss closed issue #13754: Nightly gh action "buildAndPushRelease and smokeTestRelease.py" should save release.log on failure URL: https://github.com/apache/lucene/issues/13754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Modernize switch statements in FST [lucene]

mrhbj closed pull request #13755: Modernize switch statements in FST URL: https://github.com/apache/lucene/pull/13755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[PR] Modernize switch statements in FST [lucene]

mrhbj opened a new pull request, #13755: URL: https://github.com/apache/lucene/pull/13755 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns