benwtrent commented on PR #13635: URL: https://github.com/apache/lucene/pull/13635#issuecomment-2342018139
I haven't been able to review fully, but will soon. I like this idea. Do you have any scripts & test data where you have tested that this Lucene implementation works and gives as good as results as you had in the original paper? One thing that still bugs me is attaching yet another parameter to a common method. Especially a parameter that will be rarely used (my gut reaction is choosing the correct seed query is difficult and average users will never use it). I will think more about this. Maybe its just fine and I am overreacting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
