shubhamvishu commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1751550108
##########
lucene/misc/src/java/org/apache/lucene/misc/util/fst/UpToTwoPositiveIntOutputs.java:
##########
@@ -42,36 +42,11 @@
public final class UpToTwoPositiveIntOutputs extends Outputs<Object> {
/** Holds two long outputs. */
- public static final class TwoLongs {
- public final long first;
- public final long second;
-
- public TwoLongs(long first, long second) {
- this.first = first;
- this.second = second;
+ public record TwoLongs(long first, long second) {
+ public TwoLongs {
assert first >= 0;
assert second >= 0;
}
-
- @Override
- public String toString() {
- return "TwoLongs:" + first + "," + second;
- }
Review Comment:
Yes, its fine in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
