dweiss merged PR #12684:
URL: https://github.com/apache/lucene/pull/12684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
benwtrent commented on code in PR #12657:
URL: https://github.com/apache/lucene/pull/12657#discussion_r1360502250
##
lucene/core/src/java/org/apache/lucene/util/hnsw/InitializedHnswGraphBuilder.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
s1monw commented on code in PR #12685:
URL: https://github.com/apache/lucene/pull/12685#discussion_r1360623450
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -3368,9 +3368,15 @@ public void addIndexesReaderMerge(MergePolicy.OneMerge
merge) throws IOExce
s1monw commented on code in PR #12685:
URL: https://github.com/apache/lucene/pull/12685#discussion_r1360627901
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SegmentInfoFormat.java:
##
@@ -0,0 +1,236 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mikemccand commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1360701669
##
lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java:
##
@@ -21,19 +21,18 @@
import java.util.List;
import org.apache.lucene.store.DataInput;
impor
mikemccand commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1360715823
##
lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java:
##
@@ -21,19 +21,18 @@
import java.util.List;
import org.apache.lucene.store.DataInput;
impor
s1monw commented on code in PR #12685:
URL: https://github.com/apache/lucene/pull/12685#discussion_r1360837043
##
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:
##
@@ -3368,9 +3368,15 @@ public void addIndexesReaderMerge(MergePolicy.OneMerge
merge) throws IOExce
dungba88 commented on code in PR #12633:
URL: https://github.com/apache/lucene/pull/12633#discussion_r1360866889
##
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##
@@ -99,31 +87,23 @@ public class FSTCompiler {
* tuning and tweaking, see {@link Builder}.
dungba88 commented on code in PR #12633:
URL: https://github.com/apache/lucene/pull/12633#discussion_r1360875178
##
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##
@@ -17,50 +17,80 @@
package org.apache.lucene.util.fst;
import java.io.IOException;
-import o
msfroh commented on code in PR #12626:
URL: https://github.com/apache/lucene/pull/12626#discussion_r1360878505
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -1996,6 +1996,41 @@ public void testGetCommitData() throws Exception {
dir.close();
msfroh commented on code in PR #12626:
URL: https://github.com/apache/lucene/pull/12626#discussion_r1360880697
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -1996,6 +1996,41 @@ public void testGetCommitData() throws Exception {
dir.close();
gf2121 commented on PR #12661:
URL: https://github.com/apache/lucene/pull/12661#issuecomment-1764814636
I made some effort to speed up the `add` operation for `BytesRef`, getting a
tiny improvement:
> Baseline: after https://github.com/apache/lucene/pull/12631; Candidate:
this patch;
harshavamsi opened a new issue, #12686:
URL: https://github.com/apache/lucene/issues/12686
### Description
While working with the `IndexOrDocValuesQuery`, I noticed that highlighting
was broken. This is potentially caused by the extract function that does not
check if the query is in
dweiss opened a new pull request, #12687:
URL: https://github.com/apache/lucene/pull/12687
Estimates taken from empirical run times (actions history), with a generous
buffer added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
benwtrent commented on code in PR #12657:
URL: https://github.com/apache/lucene/pull/12657#discussion_r136233
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/IncrementalHnswGraphMerger.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (A
benwtrent commented on code in PR #12657:
URL: https://github.com/apache/lucene/pull/12657#discussion_r1361112199
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/IncrementalHnswGraphMerger.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (A
mingshl commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1765091198
@romseygeek @mkhludnev, this bug was introduced since 9.4 version, can this
PR be back-ported to 9.4.2 to fix the issue?
--
This is an automated message from the Apache Git Service.
To
jmazanec15 commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765145453
Hey @benwtrent, sorry for delay, still looking through change. But 4x space
improvement with minimal recall loss is awesome.
--
This is an automated message from the Apache Git Ser
benwtrent commented on code in PR #12582:
URL: https://github.com/apache/lucene/pull/12582#discussion_r1361186978
##
lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
jmazanec15 commented on code in PR #12582:
URL: https://github.com/apache/lucene/pull/12582#discussion_r1357440025
##
lucene/core/src/java/org/apache/lucene/util/ScalarQuantizer.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
jpountz commented on code in PR #12685:
URL: https://github.com/apache/lucene/pull/12685#discussion_r1361188738
##
lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java:
##
@@ -153,6 +157,16 @@ public boolean getUseCompoundFile() {
return isCompoundFile;
}
+ /
jpountz commented on PR #12661:
URL: https://github.com/apache/lucene/pull/12661#issuecomment-1765186395
If we're specializing the format anyway, I wonder if we could try different
layouts. E.g. another option could be to encode the number of supplementary
bytes using unary coding (like UTF
zhaih merged PR #12651:
URL: https://github.com/apache/lucene/pull/12651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
uschindler commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765287960
Hi, why do we need a new Codec? The Lucebe main file format does not change,
olly the HNSW format was exchanged. Because like pistingsfornats and
dicvaluesformats, the SPI can detect
benwtrent commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765316000
@uschindler so I should just add a new format?
It would be a new Lucene99 HNSW format, but keep the default Lucene95 HNSW
format?
Or can we change the default vector form
jmazanec15 commented on code in PR #12582:
URL: https://github.com/apache/lucene/pull/12582#discussion_r1361261168
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsWriter.java:
##
@@ -0,0 +1,782 @@
+/*
+ * Licensed to the Apache Software Fo
jimczi commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765330759
> why do we need a new top-level Codec? The Lucene main file format does
not change, only the HNSW format was exchanged. Because like ppostingsfornats
and docvaluesformats, the SPI can d
Tony-X opened a new pull request, #12688:
URL: https://github.com/apache/lucene/pull/12688
### Description
Related issue https://github.com/apache/lucene/issues/12513
Opening this PR early to avoid massive diffs in one-shot
- [x] Encode (term type, local ord) in FST
T
uschindler commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765355363
> > why do we need a new top-level Codec? The Lucene main file format does
not change, only the HNSW format was exchanged. Because like ppostingsfornats
and docvaluesformats, the SPI
uschindler commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765362790
> @uschindler so I should just add a new format?
>
> It would be a new Lucene99 HNSW format, but keep the default Lucene95 HNSW
format?
>
> Or can we change the default v
uschindler commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765382016
I just checked the code, the 9.5 top-level codec addition was useless. Just
code duplication. We can't revert it anymore, but we should not repeat that.
The only required top-level Fo
sohami commented on code in PR #12606:
URL: https://github.com/apache/lucene/pull/12606#discussion_r1361333154
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -420,13 +418,12 @@ public int count(Query query) throws IOException {
}
/**
- * Ret
zhaih commented on code in PR #12683:
URL: https://github.com/apache/lucene/pull/12683#discussion_r1361334258
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java:
##
@@ -59,11 +60,26 @@ protected HnswGraph() {}
*
* @param level level of the graph
* @pa
uschindler commented on PR #12582:
URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765386547
The simplest change is:
- Remove Lucene99Codec
- In Lucene95Codec just change this: `this.defaultKnnVectorsFormat = new
Lucene95HnswVectorsFormat();` to the new format.
Do
zhaih commented on code in PR #12657:
URL: https://github.com/apache/lucene/pull/12657#discussion_r1361341835
##
lucene/core/src/java/org/apache/lucene/util/hnsw/IncrementalHnswGraphMerger.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
msfroh commented on issue #12032:
URL: https://github.com/apache/lucene/issues/12032#issuecomment-1765587096
I started to work on making DrillSidewaysScorer work on windows of doc IDs,
when I noticed the following comment added in TestDrillSideways as part of
https://github.com/apache/lucen
dweiss merged PR #12687:
URL: https://github.com/apache/lucene/pull/12687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
mkhludnev commented on PR #12260:
URL: https://github.com/apache/lucene/pull/12260#issuecomment-1765741713
Hi, @mingshl
I'm able to cherrypick this fix into branch_9_4, but I'm not sure if
there'll be release 9.4.2 ever.
--
This is an automated message from the Apache Git Service.
To
38 matches
Mail list logo
