uschindler commented on PR #12582: URL: https://github.com/apache/lucene/pull/12582#issuecomment-1765362790
> @uschindler so I should just add a new format? > > It would be a new Lucene99 HNSW format, but keep the default Lucene95 HNSW format? > > Or can we change the default vector format for the top level Lucene95 codec to a new HNSW format? > > I definitely don't fully understand how backwards compatibility works. No you just create a new HNSW format with a new name. The old one is moved to backwards compatibility. The top level Codec Lucene95Codec ist Format compatible and needs no change in it's identify. Only the part that returns the format for writing must be changed. When it reads an index the format is looked up by its name from the metadata. If that does not work there is a bug in the code reading the segment Infos. So basically, only add a new HNSW format (like you could add a new postings format) but leave the codec intact. Just change the class returned for HNSW when writing. The top level codec only needs to be changed when metadata fotmats or non spi formats change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
