gf2121 commented on PR #12661: URL: https://github.com/apache/lucene/pull/12661#issuecomment-1764814636
I made some effort to speed up the `add` operation for `BytesRef`, getting a tiny improvement: > Baseline: after https://github.com/apache/lucene/pull/12631; Candidate: this patch; Luceneutil Random seed = 0 ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value Fuzzy1 50.96 (1.1%) 51.31 (1.6%) 0.7% ( -1% - 3%) 0.114 Wildcard 58.12 (2.2%) 58.55 (2.1%) 0.8% ( -3% - 5%) 0.267 Respell 32.20 (1.7%) 32.51 (1.3%) 1.0% ( -2% - 4%) 0.044 Fuzzy2 36.56 (1.2%) 37.00 (1.2%) 1.2% ( -1% - 3%) 0.002 PKLookup 106.36 (2.0%) 108.68 (2.4%) 2.2% ( -2% - 6%) 0.002 ``` But still far more slower than origin patch: > Baseline: before https://github.com/apache/lucene/pull/12631; Candidate: this patch; Luceneutil Random seed = 0 ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value Fuzzy1 53.95 (1.4%) 51.22 (1.3%) -5.1% ( -7% - -2%) 0.000 PKLookup 114.52 (2.5%) 108.73 (2.7%) -5.0% ( -9% - 0%) 0.000 Fuzzy2 38.19 (1.2%) 36.89 (1.3%) -3.4% ( -5% - 0%) 0.000 Respell 33.41 (2.2%) 32.37 (2.4%) -3.1% ( -7% - 1%) 0.000 Wildcard 59.00 (2.6%) 58.15 (2.5%) -1.4% ( -6% - 3%) 0.072 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
