msfroh commented on code in PR #12626: URL: https://github.com/apache/lucene/pull/12626#discussion_r1360878505
########## lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java: ########## @@ -1996,6 +1996,41 @@ public void testGetCommitData() throws Exception { dir.close(); } + @Test Review Comment: It was the case that Lucene unit tests preferred to avoid the `@Test` annotation, going instead with the JUnit 3 convention where public methods whose name start with `test...` would indicate test methods. I think the annotation on `testGetCommitData()` above must have slipped through (11 years ago). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org