[GitHub] [lucene] javanna commented on issue #12347: Allow extensions of IndexSearcher to provide custom SliceExecutor and slices computation

javanna commented on issue #12347: URL: https://github.com/apache/lucene/issues/12347#issuecomment-1592633068 > Strong -1 t replacing the interface. I think it has worked well for many users for a while and it would be breaking back compatibility to serve a specific use case. @atris

[GitHub] [lucene] javanna commented on a diff in pull request #12369: Increased the likelihood of leveraging inter-segment concurrency in tests

javanna commented on code in PR #12369: URL: https://github.com/apache/lucene/pull/12369#discussion_r1230692559 ## lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java: ## @@ -1941,7 +1940,7 @@ public static IndexSearcher newSearcher( } else {

[GitHub] [lucene] adioss commented on issue #11020: CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit [LUCENE-9981]

adioss commented on issue #11020: URL: https://github.com/apache/lucene/issues/11020#issuecomment-1592692048 Hi, I don't know if my comment is relevant but: is any CVE disclosed for this security issue? I'm not able to find it anywhere. Any hints? -- This is an automated message from the

[GitHub] [lucene] javanna commented on pull request #12369: Increased the likelihood of leveraging inter-segment concurrency in tests

javanna commented on PR #12369: URL: https://github.com/apache/lucene/pull/12369#issuecomment-1592703040 thanks for the review @jpountz ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene] javanna merged pull request #12369: Increased the likelihood of leveraging inter-segment concurrency in tests

javanna merged PR #12369: URL: https://github.com/apache/lucene/pull/12369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] uschindler commented on issue #12342: Prevent VectorSimilarity.DOT_PRODUCT from returning negative scores

uschindler commented on issue #12342: URL: https://github.com/apache/lucene/issues/12342#issuecomment-1592920756 > Yeah. Another thing we could consider is doing this scaling in KnnVectorQuery and/or its Scorer. These have the ultimate responsibility of complying with the Scorer contract. I

[GitHub] [lucene] benwtrent commented on issue #12342: Prevent VectorSimilarity.DOT_PRODUCT from returning negative scores

benwtrent commented on issue #12342: URL: https://github.com/apache/lucene/issues/12342#issuecomment-1592990533 > If we did it there we wouldn't have to change the output of VectorSimilarity. However it's messy to do it there since this is specific to a particular similarity implementation,

[GitHub] [lucene] jpountz commented on issue #12359: Limit the recursion depth on token graph for preventing StackOverflow

jpountz commented on issue #12359: URL: https://github.com/apache/lucene/issues/12359#issuecomment-1593094096 This will be fixed in Lucene 9.7: https://github.com/apache/lucene/pull/12249. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] jpountz closed issue #12359: Limit the recursion depth on token graph for preventing StackOverflow

jpountz closed issue #12359: Limit the recursion depth on token graph for preventing StackOverflow URL: https://github.com/apache/lucene/issues/12359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] jpountz opened a new issue, #12375: Add a postCollect hook to LeafCollector

jpountz opened a new issue, #12375: URL: https://github.com/apache/lucene/issues/12375 ### Description It is a common need to run some logic after a segment has been collected. Even though, I can't find previous instances of this discussion I'm pretty sure that this has been raised s

[GitHub] [lucene] sohami commented on pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

sohami commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1593187744 @javanna Can you help to look into this PR ? Would be great if we can merge it in before release branch cut off. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] uschindler opened a new pull request, #12376: This allows VectorUtilProvider tests to be executed although hardwaremay not fully support vectorization or if C2 is not enabled

uschindler opened a new pull request, #12376: URL: https://github.com/apache/lucene/pull/12376 This PR allows us to better test the new Panama Vector Support, although the hardware may not fully support it. Currently when developers are running tests, C2 is disabled, so the provider never e

[GitHub] [lucene] ChrisHegarty commented on a diff in pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

ChrisHegarty commented on code in PR #12376: URL: https://github.com/apache/lucene/pull/12376#discussion_r1231273222 ## lucene/core/src/test/org/apache/lucene/util/TestVectorUtilProviders.java: ## @@ -27,7 +27,7 @@ public class TestVectorUtilProviders extends LuceneTestCase {

[GitHub] [lucene] uschindler commented on a diff in pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

uschindler commented on code in PR #12376: URL: https://github.com/apache/lucene/pull/12376#discussion_r1231278902 ## lucene/core/src/java20/org/apache/lucene/util/VectorUtilPanamaProvider.java: ## @@ -295,7 +301,7 @@ public int dotProduct(byte[] a, byte[] b) { int res = 0;

[GitHub] [lucene] uschindler commented on a diff in pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

uschindler commented on code in PR #12376: URL: https://github.com/apache/lucene/pull/12376#discussion_r1231281792 ## lucene/core/src/test/org/apache/lucene/util/TestVectorUtilProviders.java: ## @@ -27,7 +27,7 @@ public class TestVectorUtilProviders extends LuceneTestCase {

[GitHub] [lucene] uschindler commented on a diff in pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

uschindler commented on code in PR #12376: URL: https://github.com/apache/lucene/pull/12376#discussion_r1231283028 ## lucene/core/src/java20/org/apache/lucene/util/VectorUtilPanamaProvider.java: ## @@ -295,7 +301,7 @@ public int dotProduct(byte[] a, byte[] b) { int res = 0;

[GitHub] [lucene] uschindler commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

uschindler commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593392652 Actually I would like to have this testability enabled, because it is planned to run Smoke Tester for release also with Java 19/20/21 if the tester enables. I need to open issu

[GitHub] [lucene] rmuir commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

rmuir commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593450948 i guess my main question would be, what are we testing? With this approach, we just test the `jdk.incubator.vector` slow fallback code. Wouldn't it be better to just enable C2/expor

[GitHub] [lucene] rmuir commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

rmuir commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593455240 especially since we work pretty hard to prevent the slow fallback code from ever executing for real :) -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [lucene] uschindler commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

uschindler commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593481754 We just test that our code is semantically correct. Of course we assume that the fallback code is correct. So if we for example add some wrong sign flip it will fail. Theres no

[GitHub] [lucene] andrross commented on a diff in pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

andrross commented on code in PR #12374: URL: https://github.com/apache/lucene/pull/12374#discussion_r1231450680 ## lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java: ## @@ -1984,14 +1985,16 @@ protected LeafSlice[] slices(List leaves) {

[GitHub] [lucene] andrross commented on a diff in pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

andrross commented on code in PR #12374: URL: https://github.com/apache/lucene/pull/12374#discussion_r1231457192 ## lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java: ## @@ -1984,14 +1985,16 @@ protected LeafSlice[] slices(List leaves) {

[GitHub] [lucene] ChrisHegarty commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

ChrisHegarty commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593656263 This is just a very basic sanity of the code, which I think is fine. I’d find it useful to have this if modifying the code locally. The CI, etc should already be testing this more e

[GitHub] [lucene] jmazanec15 commented on issue #12342: Prevent VectorSimilarity.DOT_PRODUCT from returning negative scores

jmazanec15 commented on issue #12342: URL: https://github.com/apache/lucene/issues/12342#issuecomment-1593725970 @benwtrent I think that makes sense, but would add a little confusion. How common is it to use Vector results with MAX_SCORE/WAND? I am wondering if it would be better to j

[GitHub] [lucene] uschindler commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

uschindler commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1593732104 > This is just a very basic sanity of the code, which I think is fine. I’d find it useful to have this if modifying the code locally. The CI, etc should already be testing this more e

[GitHub] [lucene] javanna commented on pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

javanna commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1593783661 hi @sohami thanks for opening this PR! I have been considering a different approach, in the attempt of not adding additional constructor to IndexSearcher, as it already has quite some.

[GitHub] [lucene] sohami commented on pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

sohami commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1593825909 > hi @sohami thanks for opening this PR! I have been considering a different approach, in the attempt of not adding additional constructors to IndexSearcher, as it already has quite some.