[GitHub] [lucene] rmuir commented on issue #7687: Random 7200 seconds build timeouts / infinite loops in Lucene tests? [LUCENE-6629]

2022-08-24 Thread GitBox
rmuir commented on issue #7687: URL: https://github.com/apache/lucene/issues/7687#issuecomment-1225628331 This popped again on the dev list, I think its worth considering that this could be caused by a "step" to the system time (time correction by NTP or VM utility). From what I can

[GitHub] [lucene] mocobeta commented on issue #1072: lock files don't work in JDK 1.1 [LUCENE-1]

2022-08-24 Thread GitBox
mocobeta commented on issue #1072: URL: https://github.com/apache/lucene/issues/1072#issuecomment-1225699249 This is a duplicate issue to #1079. Please do not update this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] mocobeta commented on issue #2045: Optimize the core tokenizers/analyzers & deprecate Token.termText [LUCENE-969]

2022-08-24 Thread GitBox
mocobeta commented on issue #2045: URL: https://github.com/apache/lucene/issues/2045#issuecomment-1225700700 This is a duplicate issue to #2044. Please do not update this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] mocobeta commented on issue #2863: getDocValues should provide a MultiReader DocValues abstraction [LUCENE-1789]

2022-08-24 Thread GitBox
mocobeta commented on issue #2863: URL: https://github.com/apache/lucene/issues/2863#issuecomment-1225701700 This is a duplicate issue to #2864. Please do not update this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] mocobeta commented on issue #4506: Random access non RAM resident IndexDocValues (CSF) [LUCENE-3433]

2022-08-24 Thread GitBox
mocobeta commented on issue #4506: URL: https://github.com/apache/lucene/issues/4506#issuecomment-1225702673 This is a duplicate issue to #4507. Please do not update this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] mocobeta commented on issue #10557: BugfixDeflater_JDK8252739 causes Java security issues in JDK 11 [LUCENE-9517]

2022-08-24 Thread GitBox
mocobeta commented on issue #10557: URL: https://github.com/apache/lucene/issues/10557#issuecomment-1225704239 This is a duplicate issue to #10556. Please do not update this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] mocobeta commented on issue #10599: Position aware TermQuery [LUCENE-9560]

2022-08-24 Thread GitBox
mocobeta commented on issue #10599: URL: https://github.com/apache/lucene/issues/10599#issuecomment-1225705582 This is a duplicate issue #10600. Please do not update this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [lucene] madrob opened a new pull request, #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
madrob opened a new pull request, #11715: URL: https://github.com/apache/lucene/pull/11715 Add RamUsageEstimator.sizeOf(Integer) Improve estimation for both Long and Integer to not count VM Cache values. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [lucene] jpountz commented on a diff in pull request #3125: LUCENE-10633 Disable sort optimization for SortedSetSortField

2022-08-24 Thread GitBox
jpountz commented on code in PR #3125: URL: https://github.com/apache/lucene/pull/3125#discussion_r952221530 ## lucene/core/src/java/org/apache/lucene/search/SortField.java: ## @@ -627,31 +634,35 @@ public IndexSorter getIndexSorter() { } /** - * Enables/disables numer

[GitHub] [lucene] dweiss commented on issue #7687: Random 7200 seconds build timeouts / infinite loops in Lucene tests? [LUCENE-6629]

2022-08-24 Thread GitBox
dweiss commented on issue #7687: URL: https://github.com/apache/lucene/issues/7687#issuecomment-1225798719 Yeah, I'll change that internally in randomizedtesting and make an update. Let's see if this resurfaces after that. -- This is an automated message from the Apache Git Service. To re

[GitHub] [lucene] mocobeta opened a new pull request, #11716: update contributing guide for GH issue

2022-08-24 Thread GitBox
mocobeta opened a new pull request, #11716: URL: https://github.com/apache/lucene/pull/11716 Closes #1078. This also includes a small update for the pull request template. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] uschindler commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
uschindler commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1225923616 Impl looks ok. In early versions we had an auto detector for the size of the cache, but we disabled it due to a bug in OpenJ9 (not sure about it anymore). The comments still sug

[GitHub] [lucene] madrob commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
madrob commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1225956235 I went looking for the previous change and found it in LUCENE-9117. Adding David for review request, since he was touching this last. The JLS spec requires an Integer cache of at le

[GitHub] [lucene] uschindler commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
uschindler commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1225972120 ah... AOT, so my brain correlated that correctly to OpenJ9 (which also uses AOT)! Yes, AOT could remove the check and then suddenly all Longs and Integers are zero size. At

[GitHub] [lucene] madrob commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
madrob commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1225979052 We saw some weird behavior in Solr with a size-limited Caffeine cache not getting as many entries as we thought it should have. That turned out to be because sizeOf(Integer) was returning

[GitHub] [lucene] uschindler commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
uschindler commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1225990121 > We saw some weird behavior in Solr with a size-limited Caffeine cache not getting as many entries as we thought it should have. That turned out to be because sizeOf(Integer) was ret

[GitHub] [lucene] gsmiller opened a new issue, #11717: Determine the performance differences between taxonomy and ssdv faceting

2022-08-24 Thread GitBox
gsmiller opened a new issue, #11717: URL: https://github.com/apache/lucene/issues/11717 ### Description Since January of this year (after bringing hierarchical faceting to SSDV - LUCENE-10250), taxonomy and SSDV faceting have feature parity (as far as I'm aware). I'd like to consider

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #3125: LUCENE-10633 Disable sort optimization for SortedSetSortField

2022-08-24 Thread GitBox
mayya-sharipova commented on code in PR #3125: URL: https://github.com/apache/lucene/pull/3125#discussion_r954070675 ## lucene/core/src/java/org/apache/lucene/search/SortField.java: ## @@ -627,31 +634,35 @@ public IndexSorter getIndexSorter() { } /** - * Enables/disabl

[GitHub] [lucene] rmuir commented on pull request #1057: LUCENE-10670: Add a codec class to track merge time of each index part

2022-08-24 Thread GitBox
rmuir commented on PR #1057: URL: https://github.com/apache/lucene/pull/1057#issuecomment-1226029428 > I like the idea of making `SegmentMerger` implement some sort of a Stats interface that can return a metrics object. We can populate the TimeMetric object in `SegmentMerger.merge()` as eac

[GitHub] [lucene] msokolov commented on issue #2136: backport byte vector encoding to 9.x

2022-08-24 Thread GitBox
msokolov commented on issue #2136: URL: https://github.com/apache/lucene/issues/2136#issuecomment-1226059512 * 8021c2db4eee1b2d9153d4d238498e917fbbc66b * df67223497384416c7b47a546e4ea5c248554f61 * 653d2ebf71174cccba3ccff08d07a92cd51574d7 * daa56d30f0dc5370e60adc2dafd9947c65c75d4f

[GitHub] [lucene] dweiss commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
dweiss commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1226096136 Darn, I can't remember writing that code. :) LGTM though. With smarter and smarter compilers such memory estimation may become tricky like hell... -- This is an automated message from t

[GitHub] [lucene] uschindler commented on pull request #11715: RamUsageEstimator properly checks for Long cache

2022-08-24 Thread GitBox
uschindler commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1226112858 I still would not change the code here. Better to overestimate than having all Longs or Ints suddenly size=0 (when AOT jumps in). I'd just remove the wrong comment. And a

[GitHub] [lucene] msokolov commented on issue #2136: backport byte vector encoding to 9.x

2022-08-24 Thread GitBox
msokolov commented on issue #2136: URL: https://github.com/apache/lucene/issues/2136#issuecomment-1226119410 ok, I had to revert the switch statements to old-style to be compatible with JDK11, and I added a CHANGES entry. Otherwise it all built cleanly. -- This is an automated message fro

[GitHub] [lucene] msokolov closed issue #2136: backport byte vector encoding to 9.x

2022-08-24 Thread GitBox
msokolov closed issue #2136: backport byte vector encoding to 9.x URL: https://github.com/apache/lucene/issues/2136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [lucene] dweiss commented on issue #7687: Random 7200 seconds build timeouts / infinite loops in Lucene tests? [LUCENE-6629]

2022-08-24 Thread GitBox
dweiss commented on issue #7687: URL: https://github.com/apache/lucene/issues/7687#issuecomment-1226127754 Randomizedtesting is riddled with currentTimeMillis calls so yeah - could be it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] mocobeta closed issue #1078: Update contribution guide

2022-08-24 Thread GitBox
mocobeta closed issue #1078: Update contribution guide URL: https://github.com/apache/lucene/issues/1078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] mocobeta merged pull request #11716: update contributing guide for GH issue

2022-08-24 Thread GitBox
mocobeta merged PR #11716: URL: https://github.com/apache/lucene/pull/11716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] msokolov commented on issue #11613: Enable quantization of HNSW vectors to 8 bits [LUCENE-10577]

2022-08-24 Thread GitBox
msokolov commented on issue #11613: URL: https://github.com/apache/lucene/issues/11613#issuecomment-1226148301 pushed to main and backported to 9.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] msokolov closed issue #11613: Enable quantization of HNSW vectors to 8 bits [LUCENE-10577]

2022-08-24 Thread GitBox
msokolov closed issue #11613: Enable quantization of HNSW vectors to 8 bits [LUCENE-10577] URL: https://github.com/apache/lucene/issues/11613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [lucene] uschindler commented on issue #11701: Deadlock in AnalysisSPILoader [LUCENE-10665]

2022-08-24 Thread GitBox
uschindler commented on issue #11701: URL: https://github.com/apache/lucene/issues/11701#issuecomment-1226293731 Hi, this is exactly the same issue we have seen with Codecs and PostingsFormats. The problem is the following: The base class of all analysis factories (TokenizerFactory, Toke

[GitHub] [lucene] uschindler commented on issue #11701: Deadlock in AnalysisSPILoader [LUCENE-10665]

2022-08-24 Thread GitBox
uschindler commented on issue #11701: URL: https://github.com/apache/lucene/issues/11701#issuecomment-1226300895 See #7541 and #10700 for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene] uschindler opened a new pull request, #11718: Fix classloading deadlock in analysis factories / AnalysisSPILoader initialization

2022-08-24 Thread GitBox
uschindler opened a new pull request, #11718: URL: https://github.com/apache/lucene/pull/11718 This fixes #11701 (LUCENE-10665). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [lucene] uschindler commented on pull request #11718: Fix classloading deadlock in analysis factories / AnalysisSPILoader initialization

2022-08-24 Thread GitBox
uschindler commented on PR #11718: URL: https://github.com/apache/lucene/pull/11718#issuecomment-1226396597 This fix is more or less a copy of the SPI loader code we use in Codec, PostingsFormat, DocValuesFormat,... The general issue is: Nowhere in Java you should have a static initia

[GitHub] [lucene] uschindler commented on issue #11701: Deadlock in AnalysisSPILoader [LUCENE-10665]

2022-08-24 Thread GitBox
uschindler commented on issue #11701: URL: https://github.com/apache/lucene/issues/11701#issuecomment-1226453761 PR (main branch): #11718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene-jira-archive] mocobeta closed issue #29: Can/should we make Jira read-only on migration to GitHub issues?

2022-08-24 Thread GitBox
mocobeta closed issue #29: Can/should we make Jira read-only on migration to GitHub issues? URL: https://github.com/apache/lucene-jira-archive/issues/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] rmuir commented on issue #11717: Determine the performance differences between taxonomy and ssdv faceting

2022-08-24 Thread GitBox
rmuir commented on issue #11717: URL: https://github.com/apache/lucene/issues/11717#issuecomment-1226766804 Some of the differences are not performance related, but instead usability. In some of those cases I think we can still improve. For example, it is a usability improvement for t