uschindler commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1226112858
I still would not change the code here. Better to overestimate than having all Longs or Ints suddenly size=0 (when AOT jumps in). I'd just remove the wrong comment. And about Solr: Solr should use shallowSizeOf(Long.class) to tell Cafeine cache the reals size. That works consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
