uschindler commented on PR #11715: URL: https://github.com/apache/lucene/pull/11715#issuecomment-1225972120
aaaaah... AOT, so my brain correlated that correctly to OpenJ9 (which also uses AOT)! Yes, AOT could remove the check and then suddenly all Longs and Integers are zero size. At least your solution will not blow up when AOT jumps in. It will find identity in the obejcts and says "all longs/ints are cached", so size 0. The old code that Dawid removed went into an endless loop. In my personal opinion, I would not check for the cache at all, unless we really overestimate for certain cases like and `Integer[]` array with thousands of small integers. But In Lucene code we have have this. What is the real problem you are trying to solve? Uwe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
