rmuir commented on PR #1057: URL: https://github.com/apache/lucene/pull/1057#issuecomment-1226029428
> I like the idea of making `SegmentMerger` implement some sort of a Stats interface that can return a metrics object. We can populate the TimeMetric object in `SegmentMerger.merge()` as each codec's merge returns. It solves what is needed here, and is easy to extend. I would suggest IndexWriter instead. it is already the public interface, just expose some counters. SegmentMerger is an implementation detail. In fact there are already some counters there (e.g. flushCount), but only exposed for testing purposes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
