[GitHub] [lucene] mocobeta closed issue #993: Raise a fake issue !Do not raise a real issue in GitHub until the official announcement is sent!

2022-08-22 Thread GitBox
mocobeta closed issue #993: Raise a fake issue !Do not raise a real issue in GitHub until the official announcement is sent! URL: https://github.com/apache/lucene/issues/993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] mocobeta opened a new issue, #1078: Update contribution guide

2022-08-22 Thread GitBox
mocobeta opened a new issue, #1078: URL: https://github.com/apache/lucene/issues/1078 ### Description The contribution guide needs to be updated after issue migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] msokolov opened a new issue, #1587: SimpleTextKnnVectorsFormat to fully support byte-encoding

2022-08-22 Thread GitBox
msokolov opened a new issue, #1587: URL: https://github.com/apache/lucene/issues/1587 ### Description Today SimpleTextKnnVectorsFormat ignores byte-encoding, treating any binary values as encoded floats. Most of the tests pass anyway, but when we explicitly test for byte-encoding, we

[GitHub] [lucene] msokolov commented on a diff in pull request #1074: Fix for bad cast when sorting a KnnVectors index over BytesRef

2022-08-22 Thread GitBox
msokolov commented on code in PR #1074: URL: https://github.com/apache/lucene/pull/1074#discussion_r951374398 ## lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsWriter.java: ## @@ -76,6 +77,10 @@ public class SimpleTextKnnVectorsWriter extends Buf

[GitHub] [lucene] msokolov commented on issue #1587: SimpleTextKnnVectorsFormat to fully support byte-encoding

2022-08-22 Thread GitBox
msokolov commented on issue #1587: URL: https://github.com/apache/lucene/issues/1587#issuecomment-192495 https://github.com/apache/lucene/commit/8021c2db4eee1b2d9153d4d238498e917fbbc66b removes the exception -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [lucene] msokolov opened a new issue, #2136: backport byte vector encoding to 9.x

2022-08-22 Thread GitBox
msokolov opened a new issue, #2136: URL: https://github.com/apache/lucene/issues/2136 ### Description In LUCENE-10577 we added byte encoded HNSW vectors. I'd like to backport to 9.x, which I guess is uncontroversial, but I opened this issue because there have been a bunch of commits

[GitHub] [lucene-solr] cpoerschke commented on a diff in pull request #2159: SOLR-14923: Nested docs indexing performance.

2022-08-22 Thread GitBox
cpoerschke commented on code in PR #2159: URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r951673228 ## solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java: ## @@ -355,8 +370,9 @@ void processGetInputDocument(ResponseBuilder rb) throws

[GitHub] [lucene] gsmiller commented on a diff in pull request #1062: Optimize TermInSetQuery for terms that match all docs in a segment

2022-08-22 Thread GitBox
gsmiller commented on code in PR #1062: URL: https://github.com/apache/lucene/pull/1062#discussion_r951698471 ## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ## @@ -293,6 +296,9 @@ private WeightOrDocIdSet rewrite(LeafReaderContext context) throws IOExcept

[GitHub] [lucene] gsmiller commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-22 Thread GitBox
gsmiller commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r951744466 ## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ## @@ -345,15 +345,62 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOExceptio

[GitHub] [lucene] gsmiller commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-22 Thread GitBox
gsmiller commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r951745046 ## lucene/CHANGES.txt: ## @@ -95,6 +95,9 @@ Improvements - * LUCENE-10592: Build HNSW Graph on indexing. (Mayya Sharipova, Adrien Grand, Julie Tib

[GitHub] [lucene] gsmiller commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-22 Thread GitBox
gsmiller commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r951765243 ## lucene/CHANGES.txt: ## @@ -95,6 +95,9 @@ Improvements - * LUCENE-10592: Build HNSW Graph on indexing. (Mayya Sharipova, Adrien Grand, Julie Tib

[GitHub] [lucene] gsmiller commented on a diff in pull request #1058: LUCENE-10207: TermInSetQuery now provides a ScoreSupplier with cost estimation for use in TermInSetQuery

2022-08-22 Thread GitBox
gsmiller commented on code in PR #1058: URL: https://github.com/apache/lucene/pull/1058#discussion_r951767154 ## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ## @@ -345,15 +345,62 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOExceptio

[GitHub] [lucene] mayya-sharipova closed pull request #1061: increase the value of max dimensions for dense vector search.

2022-08-22 Thread GitBox
mayya-sharipova closed pull request #1061: increase the value of max dimensions for dense vector search. URL: https://github.com/apache/lucene/pull/1061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] mayya-sharipova commented on pull request #1061: increase the value of max dimensions for dense vector search.

2022-08-22 Thread GitBox
mayya-sharipova commented on PR #1061: URL: https://github.com/apache/lucene/pull/1061#issuecomment-1222847989 Closing as a duplicate for https://github.com/apache/lucene/pull/874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene] mayya-sharipova opened a new pull request, #3125: LUCENE-10633 Disable sort optimization for SortedSetSortField

2022-08-22 Thread GitBox
mayya-sharipova opened a new pull request, #3125: URL: https://github.com/apache/lucene/pull/3125 Add ability to SortedSetSortField to disable sort optimization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] rmuir commented on pull request #1057: LUCENE-10670: Add a codec class to track merge time of each index part

2022-08-22 Thread GitBox
rmuir commented on PR #1057: URL: https://github.com/apache/lucene/pull/1057#issuecomment-1223506286 it uses `instanceof`: https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java#L686 ther