gsmiller commented on code in PR #1062: URL: https://github.com/apache/lucene/pull/1062#discussion_r951698471
########## lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java: ########## @@ -293,6 +296,9 @@ private WeightOrDocIdSet rewrite(LeafReaderContext context) throws IOException { builder.add(docs); Review Comment: Oh, I get what you're saying now. Thanks @LuXugang! If I'm understanding correctly (I think I am now), you're pointing out that we can further optimize; I'm missing a check on the current TermEnum when dropping into this branch. I'll update the PR shortly. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org