msokolov commented on code in PR #1074: URL: https://github.com/apache/lucene/pull/1074#discussion_r951374398
########## lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsWriter.java: ########## @@ -76,6 +77,10 @@ public class SimpleTextKnnVectorsWriter extends BufferingKnnVectorsWriter { public void writeField(FieldInfo fieldInfo, KnnVectorsReader knnVectorsReader, int maxDoc) throws IOException { VectorValues vectors = knnVectorsReader.getVectorValues(fieldInfo.name); + if (fieldInfo.getVectorEncoding() != VectorEncoding.FLOAT32) { Review Comment: yeah, oops -- and this exception is breaking all kinds of tests. I opened https://github.com/apache/lucene/issues/1587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org