[GitHub] [lucene-jira-archive] mikemccand merged pull request #98: Escape github style issue links

2022-07-31 Thread GitBox
mikemccand merged PR #98: URL: https://github.com/apache/lucene-jira-archive/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mikemccand commented on issue #1: Fix markup conversion error

2022-07-31 Thread GitBox
mikemccand commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1200386255 > Thank you for sending the call for help. YW -- it's the least I could do!! I will also send a call for help for users (not just devs) to record their jira id

[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mikemccand commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933956367 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict

[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mikemccand commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933956494 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict

[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #101: Fix a few type errors identified by mypy

2022-07-31 Thread GitBox
mikemccand opened a new pull request, #101: URL: https://github.com/apache/lucene-jira-archive/pull/101 I am new to these type annotations so please double-check that I didn't make things worse! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-jira-archive] mikemccand commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mikemccand commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200393717 Hmm, the thing is, this form `[~thetaphi]` seems to happen quite often: ``` (.venv) beast3:migration[main]$ grep -ri "\[\~thetaphi\]" jira-dump | wc 955

[GitHub] [lucene-jira-archive] mikemccand commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mikemccand commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200394506 It happens for some other users too: ``` (.venv) beast3:migration[main]$ grep -ri "\[\~" github-import-data/ | wc 331 15583 214620 ``` E.g.:

[GitHub] [lucene-jira-archive] mikemccand commented on issue #94: We need to escape #NN when it appears in Jira comment/description

2022-07-31 Thread GitBox
mikemccand commented on issue #94: URL: https://github.com/apache/lucene-jira-archive/issues/94#issuecomment-1200394596 I think this is resolved now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-jira-archive] mikemccand closed issue #94: We need to escape #NN when it appears in Jira comment/description

2022-07-31 Thread GitBox
mikemccand closed issue #94: We need to escape #NN when it appears in Jira comment/description URL: https://github.com/apache/lucene-jira-archive/issues/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-jira-archive] mikemccand closed issue #92: Don't substitute the GitHub issue link in the Legacy Jira header

2022-07-31 Thread GitBox
mikemccand closed issue #92: Don't substitute the GitHub issue link in the Legacy Jira header URL: https://github.com/apache/lucene-jira-archive/issues/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-jira-archive] mikemccand commented on issue #92: Don't substitute the GitHub issue link in the Legacy Jira header

2022-07-31 Thread GitBox
mikemccand commented on issue #92: URL: https://github.com/apache/lucene-jira-archive/issues/92#issuecomment-1200394697 OK I think we can resolve this now? Thanks @mocobeta! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [lucene-jira-archive] mikemccand commented on issue #93: Too much text is quoted

2022-07-31 Thread GitBox
mikemccand commented on issue #93: URL: https://github.com/apache/lucene-jira-archive/issues/93#issuecomment-1200395212 We might be able to work around this by inserting an extra newline when we detect `^> ...` at the start of a line? So from the above issue, we would map: ```

[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #99: Capture email-address like jira mentions

2022-07-31 Thread GitBox
mikemccand commented on code in PR #99: URL: https://github.com/apache/lucene-jira-archive/pull/99#discussion_r933963119 ## migration/src/jira_util.py: ## @@ -228,8 +228,8 @@ def extract_pull_requests(o: dict) -> list[str]: REGEX_CRLF = re.compile(r"\r\n") REGEX_JIRA_KEY = r

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933963135 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933963266 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933963266 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] uschindler commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
uschindler commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200396083 "thetaphi" is "uschindler". This was changed when ASF changed to use LDAP for committer access to JIRA. The other account was deleted (I think) or we renamed it, but a JI

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933963266 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] mikemccand commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mikemccand commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200396433 OK! Mystery explained then. Apache users (committers+) who had different Jira id than their Apache id, got renamed in the LDAP migration. But this left some broke

[GitHub] [lucene-jira-archive] mikemccand commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mikemccand commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200396473 Thanks for the history lesson @uschindler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene-jira-archive] mikemccand commented on issue #95: Are we missing conversion of some ~jira-id references?

2022-07-31 Thread GitBox
mikemccand commented on issue #95: URL: https://github.com/apache/lucene-jira-archive/issues/95#issuecomment-1200396809 OK I'll resolve this issue as a duplicate of #96 where more discussion has happened. Thanks @mocobeta. -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene-jira-archive] mikemccand closed issue #95: Are we missing conversion of some ~jira-id references?

2022-07-31 Thread GitBox
mikemccand closed issue #95: Are we missing conversion of some ~jira-id references? URL: https://github.com/apache/lucene-jira-archive/issues/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [lucene-jira-archive] mikemccand commented on issue #89: Excess strike-through on conversion

2022-07-31 Thread GitBox
mikemccand commented on issue #89: URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1200397024 OK I confirmed that we can just escape the `~` with a backslash: Broken (copied from the Jira issue): For Lucene 3.6.2, the timings settle down to 200~300 wit

[GitHub] [lucene-jira-archive] mikemccand commented on issue #95: Are we missing conversion of some ~jira-id references?

2022-07-31 Thread GitBox
mikemccand commented on issue #95: URL: https://github.com/apache/lucene-jira-archive/issues/95#issuecomment-1200397190 Duplicate of #96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene-jira-archive] mikemccand commented on issue #95: Are we missing conversion of some ~jira-id references?

2022-07-31 Thread GitBox
mikemccand commented on issue #95: URL: https://github.com/apache/lucene-jira-archive/issues/95#issuecomment-1200397223 Duplicate of #96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene-jira-archive] mikemccand commented on issue #95: Are we missing conversion of some ~jira-id references?

2022-07-31 Thread GitBox
mikemccand commented on issue #95: URL: https://github.com/apache/lucene-jira-archive/issues/95#issuecomment-1200397309 Well, I tried to mark this as duplicate not as "Completed". But, I failed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [lucene-jira-archive] uschindler commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
uschindler commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200397331 See: https://issues.apache.org/jira/browse/INFRA-19087 There were many renames and ASF infra asked to open issues like the above. -- This is an automated message

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933964756 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933964769 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #97: don't create issue links to self

2022-07-31 Thread GitBox
mocobeta commented on code in PR #97: URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933965142 ## migration/src/jira_util.py: ## @@ -289,34 +289,34 @@ def repl_att(m: re.Match): return text -def embed_gh_issue_link(text: str, issue_id_map: dict[s

[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #99: Capture email-address like jira mentions

2022-07-31 Thread GitBox
mocobeta commented on code in PR #99: URL: https://github.com/apache/lucene-jira-archive/pull/99#discussion_r933965570 ## migration/src/jira_util.py: ## @@ -228,8 +228,8 @@ def extract_pull_requests(o: dict) -> list[str]: REGEX_CRLF = re.compile(r"\r\n") REGEX_JIRA_KEY = re.

[GitHub] [lucene-jira-archive] mocobeta commented on issue #89: Excess strike-through on conversion

2022-07-31 Thread GitBox
mocobeta commented on issue #89: URL: https://github.com/apache/lucene-jira-archive/issues/89#issuecomment-1200399822 I know which code we should change - will take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene-jira-archive] mocobeta merged pull request #101: Fix a few type errors identified by mypy

2022-07-31 Thread GitBox
mocobeta merged PR #101: URL: https://github.com/apache/lucene-jira-archive/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene-jira-archive] mocobeta commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mocobeta commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200400393 > @mocobeta if you agree, I can try to work up a PR with these "orphaned" jira IDs by just adding to the mappings file? Yes I think it'd be great if we could add the

[GitHub] [lucene-jira-archive] mikemccand commented on issue #78: Draft a summary of how we migrated to GitHub issues

2022-07-31 Thread GitBox
mikemccand commented on issue #78: URL: https://github.com/apache/lucene-jira-archive/issues/78#issuecomment-1200400556 I started a very rough draft here: https://docs.google.com/document/d/10m6--f7vbU9OC_SfANN6vbNDvu25COMm0Jc4wnggNV0/edit# Feel free to edit. -- This is an automat

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #102: Missing persons (committers)

2022-07-31 Thread GitBox
mocobeta opened a new issue, #102: URL: https://github.com/apache/lucene-jira-archive/issues/102 I've tried to identify committers' (https://projects.apache.org/committee.html?lucene) GitHub accounts as far as possible. Several accounts were found (I added them to the mapping file), but th

[GitHub] [lucene-jira-archive] mocobeta commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mocobeta commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200406925 But the situation is not any worse than in Jira - anyway, the orphaned mentions are not actual mentions in Jira. I don't think this has priority. -- This is an automated

[GitHub] [lucene-jira-archive] uschindler commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
uschindler commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200411999 > But the situation is not any worse than in Jira - anyway, the orphaned mentions are not actual mentions in Jira. I don't think this has priority in terms of migration.

[GitHub] [lucene-jira-archive] mocobeta commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mocobeta commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200412428 This list includes people who are/were very active in Lucene, but I gave up. If you have any information please let me know. cc @mikemccand -- This is an automa

[GitHub] [lucene-jira-archive] mocobeta commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mocobeta commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200412660 > I'd suggest this for my name: "thetaphi" -> "uschindler" OK I will do this. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene-jira-archive] mocobeta commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mocobeta commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200413200 I would rather try to seek help for #102 - I don't have any clues about this and gave up. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene-jira-archive] mocobeta commented on issue #1: Fix markup conversion error

2022-07-31 Thread GitBox
mocobeta commented on issue #1: URL: https://github.com/apache/lucene-jira-archive/issues/1#issuecomment-1200419598 > In fact, we should more generally announce our planned schedule to java-user@ as well once we have a specific timeline planned. I will make an announcement about the

[GitHub] [lucene-jira-archive] uschindler commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
uschindler commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200460272 One posisbility: Grep through the whole history of the (old) lucene-solr repository searching for their name as committer/author. If you found a hit, copy the commit id

[jira] [Created] (LUCENE-10671) Lucene

2022-07-31 Thread allnewcracksoftwares (Jira)
allnewcracksoftwares created LUCENE-10671: - Summary: Lucene Key: LUCENE-10671 URL: https://issues.apache.org/jira/browse/LUCENE-10671 Project: Lucene - Core Issue Type: Bug

[GitHub] [lucene-jira-archive] mikemccand commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mikemccand commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200480219 Karl Wright is `daddywri` in both places (plus a couple email addresses) -- I'll push a change. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene-jira-archive] mikemccand commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mikemccand commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200481031 > * Otis Gospodnetic Otis is @otisg on GitHub (I recognize him) -- I'll add his mapping. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] msokolov commented on a diff in pull request #1054: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-31 Thread GitBox
msokolov commented on code in PR #1054: URL: https://github.com/apache/lucene/pull/1054#discussion_r934048743 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/CompressingVectorValues.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene-jira-archive] mocobeta commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mocobeta commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200523814 Thank you @mikemccand. > Otis is `@otisg` on GitHub (I recognize him) -- I'll add his mapping. Sorry, I should have recognized it - actually the script found

[GitHub] [lucene-jira-archive] mocobeta commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mocobeta commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200527835 > Karl Wright is daddywri in both places (plus a couple email addresses) -- I'll push a change. For this mapping, it was impossible to detect it by the account sear

[GitHub] [lucene-jira-archive] mocobeta commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mocobeta commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200545695 Manual account identification/verification is the most time- and energy-consuming task in the entire work (it took two hours for me only for <100 committers). I don't thi

[GitHub] [lucene-jira-archive] mocobeta commented on issue #102: Missing accounts (committers)

2022-07-31 Thread GitBox
mocobeta commented on issue #102: URL: https://github.com/apache/lucene-jira-archive/issues/102#issuecomment-1200615093 > One posisbility: Grep through the whole history of the (old) lucene-solr repository searching for their name as committer/author. If you found a hit, copy the commit id

[GitHub] [lucene] tang-hi commented on a diff in pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-31 Thread GitBox
tang-hi commented on code in PR #1016: URL: https://github.com/apache/lucene/pull/1016#discussion_r934125980 ## lucene/core/src/java/org/apache/lucene/util/automaton/Automaton.java: ## @@ -616,7 +621,7 @@ public String toDot() { appendCharString(t.max, b); }

[GitHub] [lucene-jira-archive] mocobeta commented on issue #96: Some user references don't convert?

2022-07-31 Thread GitBox
mocobeta commented on issue #96: URL: https://github.com/apache/lucene-jira-archive/issues/96#issuecomment-1200718903 Seeing the case of "Karl Wright is daddywri" in #102, I feel like we have to investigate all "orphaned" mentions. I'll try to write scripts that count the number of occurre

[GitHub] [lucene] tang-hi commented on pull request #1016: LUCENE-10646: Add some comment on LevenshteinAutomata

2022-07-31 Thread GitBox
tang-hi commented on PR #1016: URL: https://github.com/apache/lucene/pull/1016#issuecomment-1200722990 > I filed #1053 to perhaps help people in figuring out where the source/target files are. Resource regeneration is a mess but we've talked about it before - it's not quite trivial to imple