mikemccand commented on code in PR #97:
URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933956494
##########
migration/src/jira_util.py:
##########
@@ -289,34 +289,34 @@ def repl_att(m: re.Match):
return text
-def embed_gh_issue_link(text: str, issue_id_map: dict[str, str]) -> str:
+def embed_gh_issue_link(text: str, issue_id_map: dict[str, str],
gh_number_self: int = None) -> str:
"""Embed GitHub issue number
"""
def repl_simple(m: re.Match):
res = m.group(0)
gh_number = issue_id_map.get(m.group(2))
- if gh_number:
+ if gh_number and gh_number != gh_number_self:
Review Comment:
Hmm `issue_id_map` is a `str -> str` dict type, but `gh_number` is an `int`?
Aren't we then comparing `str` to `int`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
