msokolov commented on code in PR #1054: URL: https://github.com/apache/lucene/pull/1054#discussion_r934048743
########## lucene/core/src/java/org/apache/lucene/codecs/lucene94/CompressingVectorValues.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.lucene.codecs.lucene94; + +import java.io.IOException; +import org.apache.lucene.index.FilterVectorValues; +import org.apache.lucene.index.VectorValues; +import org.apache.lucene.util.BytesRef; + +/** convert from floating point to single byte */ +public class CompressingVectorValues extends FilterVectorValues { Review Comment: oh - this can be deleted now ########## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94HnswVectorsFormat.java: ########## @@ -156,6 +157,11 @@ public KnnVectorsReader fieldsReader(SegmentReadState state) throws IOException return new Lucene94HnswVectorsReader(state); } + @Override + public int currentVersion() { Review Comment: I'm not sure if we really need this -- it's used only in BaseKnnVectorsFormatTestCase to decide whether to test the BYTE format. Maybe there's a less-intrusive way to make the test work now and going forward? But I didn't like the idea of having instanceof checks on the codec that might have to be updated with each release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
