mikemccand commented on code in PR #97:
URL: https://github.com/apache/lucene-jira-archive/pull/97#discussion_r933956367
##########
migration/src/jira_util.py:
##########
@@ -289,34 +289,34 @@ def repl_att(m: re.Match):
return text
-def embed_gh_issue_link(text: str, issue_id_map: dict[str, str]) -> str:
+def embed_gh_issue_link(text: str, issue_id_map: dict[str, str],
gh_number_self: int = None) -> str:
Review Comment:
I think Python itself does not enforce these type hints?
And I think I may've messed some of them up with copy/paste in past PRs.
I will try `mypy` static analysis and see what it says ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
