[GitHub] [lucene] LuXugang commented on a diff in pull request #967: LUCENE-10623: Error implementation of docValueCount for SortingSortedSetDocValues

2022-06-26 Thread GitBox
LuXugang commented on code in PR #967: URL: https://github.com/apache/lucene/pull/967#discussion_r906765458 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -114,6 +116,7 @@ private void finishCurrentDoc() { } lastValue = termID;

[GitHub] [lucene] LuXugang commented on a diff in pull request #967: LUCENE-10623: Error implementation of docValueCount for SortingSortedSetDocValues

2022-06-26 Thread GitBox
LuXugang commented on code in PR #967: URL: https://github.com/apache/lucene/pull/967#discussion_r906767186 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -114,6 +116,7 @@ private void finishCurrentDoc() { } lastValue = termID;

[GitHub] [lucene] LuXugang commented on a diff in pull request #967: LUCENE-10623: Error implementation of docValueCount for SortingSortedSetDocValues

2022-06-26 Thread GitBox
LuXugang commented on code in PR #967: URL: https://github.com/apache/lucene/pull/967#discussion_r906769090 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesConsumer.java: ## @@ -805,11 +805,9 @@ public int nextDoc() throws IOException {

[GitHub] [lucene] shaie opened a new pull request, #982: Fix typos and minor refactoring to FacetConfig

2022-06-26 Thread GitBox
shaie opened a new pull request, #982: URL: https://github.com/apache/lucene/pull/982 ### Description (or a Jira issue link if you have one) Some typos fixes + small refactoring to simplify `FacetConfig` code. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene] gsmiller opened a new pull request, #983: Some refactoring/cleanup of AbstractSortedSetDocValueFacetCounts

2022-06-26 Thread GitBox
gsmiller opened a new pull request, #983: URL: https://github.com/apache/lucene/pull/983 A little refactoring/cleanup of common functionality in `AbstractSortedSetDocValueFacetCounts`. No functional change. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] gsmiller opened a new pull request, #984: Switch Float/IntTaxonomyFacets to primitive list data structures in getAllChildren

2022-06-26 Thread GitBox
gsmiller opened a new pull request, #984: URL: https://github.com/apache/lucene/pull/984 Let's avoid creating some garbage and unnecessary boxing/unboxing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] zacharymorn commented on pull request #972: LUCENE-10480: Use BMM scorer for 2 clauses disjunction

2022-06-26 Thread GitBox
zacharymorn commented on PR #972: URL: https://github.com/apache/lucene/pull/972#issuecomment-1166714692 Hi @jpountz, I've taken some ideas from your bulk scorer implementation and was able to simplify my code as well as to boost the performance when under default `SEARCH_NUM_THREADS` [her

[GitHub] [lucene] shaie merged pull request #982: Fix typos and minor refactoring to FacetConfig

2022-06-26 Thread GitBox
shaie merged PR #982: URL: https://github.com/apache/lucene/pull/982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or

[GitHub] [lucene] shaie opened a new pull request, #985: Fix typos and minor refactoring to FacetConfig (#982)

2022-06-26 Thread GitBox
shaie opened a new pull request, #985: URL: https://github.com/apache/lucene/pull/985 ### Description Backport `9338909373a` to branch_9x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene] shaie merged pull request #985: Fix typos and minor refactoring to FacetConfig (#982)

2022-06-26 Thread GitBox
shaie merged PR #985: URL: https://github.com/apache/lucene/pull/985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or

[GitHub] [lucene] jtibshirani commented on pull request #951: LUCENE-10606: Optimize Prefilter Hit Collection

2022-06-26 Thread GitBox
jtibshirani commented on PR #951: URL: https://github.com/apache/lucene/pull/951#issuecomment-1166948233 For context, I also reran benchmarks and didn't see any slowdown to the typical case (not backed by a BitSet). -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [lucene] jtibshirani merged pull request #951: LUCENE-10606: Optimize Prefilter Hit Collection

2022-06-26 Thread GitBox
jtibshirani merged PR #951: URL: https://github.com/apache/lucene/pull/951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[jira] [Commented] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559019#comment-17559019 ] ASF subversion and git services commented on LUCENE-10606: -- Co