LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r906765458
##########
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##########
@@ -114,6 +116,7 @@ private void finishCurrentDoc() {
}
lastValue = termID;
}
+ maxBitsRequired |= count;
Review Comment:
Thanks for catching this, @jpountz I saw we already have a `maxCount`,
that's what we needed.
Addressed in
https://github.com/apache/lucene/pull/967/commits/542c2f9a5fa7dab0a9b3cc84fc777d8988fec3d7
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
