[GitHub] [lucene] LuXugang commented on a diff in pull request #967: LUCENE-10623: Error implementation of docValueCount for SortingSortedSetDocValues

[GitBox]

LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r906767186


##########
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##########
@@ -114,6 +116,7 @@ private void finishCurrentDoc() {
       }
       lastValue = termID;
     }
+    maxBitsRequired |= count;

Review Comment:
   
   Thanks for catching this, @jpountz , I saw we already have a `maxCount`, 
that is what we wanted.
   
   Addressed in 
https://github.com/apache/lucene/pull/967/commits/542c2f9a5fa7dab0a9b3cc84fc777d8988fec3d7



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org