zacharymorn commented on PR #972: URL: https://github.com/apache/lucene/pull/972#issuecomment-1166714692
Hi @jpountz, I've taken some ideas from your bulk scorer implementation and was able to simplify my code as well as to boost the performance when under default `SEARCH_NUM_THREADS` [here](https://github.com/apache/lucene/pull/972/commits/cb8ab7485a405e9517049822eef36ae590f2f65b). The benchmark results look similar now albeit a bit varying : ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value BrowseDateSSDVFacets 4.38 (35.8%) 4.01 (30.3%) -8.3% ( -54% - 90%) 0.431 Prefix3 811.56 (5.6%) 782.08 (7.8%) -3.6% ( -16% - 10%) 0.091 OrHighMedDayTaxoFacets 11.42 (5.6%) 11.11 (8.0%) -2.7% ( -15% - 11%) 0.223 IntNRQ 297.19 (1.5%) 291.62 (5.0%) -1.9% ( -8% - 4%) 0.107 Wildcard 269.43 (5.0%) 264.57 (6.4%) -1.8% ( -12% - 10%) 0.319 BrowseRandomLabelSSDVFacets 20.22 (8.8%) 19.86 (8.4%) -1.8% ( -17% - 16%) 0.518 HighTermTitleBDVSort 236.73 (8.6%) 232.93 (8.6%) -1.6% ( -17% - 17%) 0.555 AndHighHighDayTaxoFacets 12.67 (2.9%) 12.48 (4.4%) -1.5% ( -8% - 5%) 0.186 BrowseMonthTaxoFacets 32.18 (36.3%) 31.72 (38.8%) -1.4% ( -56% - 115%) 0.904 LowPhrase 1725.41 (3.3%) 1702.14 (5.3%) -1.3% ( -9% - 7%) 0.334 MedSloppyPhrase 111.58 (3.2%) 110.16 (3.8%) -1.3% ( -8% - 5%) 0.250 HighPhrase 930.18 (2.5%) 919.75 (3.4%) -1.1% ( -6% - 4%) 0.234 MedTermDayTaxoFacets 46.10 (3.9%) 45.68 (4.8%) -0.9% ( -9% - 8%) 0.514 TermDTSort 341.03 (7.2%) 338.23 (8.5%) -0.8% ( -15% - 15%) 0.740 AndHighMedDayTaxoFacets 39.88 (1.9%) 39.57 (3.1%) -0.8% ( -5% - 4%) 0.349 HighTermDayOfYearSort 148.85 (7.6%) 147.86 (8.3%) -0.7% ( -15% - 16%) 0.792 HighTermMonthSort 218.46 (8.6%) 217.06 (9.2%) -0.6% ( -16% - 18%) 0.819 OrNotHighLow 2696.50 (5.4%) 2681.95 (5.0%) -0.5% ( -10% - 10%) 0.743 LowSloppyPhrase 22.79 (2.0%) 22.69 (2.9%) -0.4% ( -5% - 4%) 0.585 Fuzzy2 125.08 (2.7%) 124.54 (4.3%) -0.4% ( -7% - 6%) 0.708 HighSloppyPhrase 21.02 (2.3%) 20.94 (3.0%) -0.4% ( -5% - 5%) 0.629 OrHighNotMed 1805.04 (4.7%) 1797.98 (5.8%) -0.4% ( -10% - 10%) 0.816 BrowseMonthSSDVFacets 29.37 (14.0%) 29.26 (13.4%) -0.4% ( -24% - 31%) 0.933 MedPhrase 205.52 (1.7%) 204.78 (3.0%) -0.4% ( -4% - 4%) 0.643 Fuzzy1 128.47 (2.8%) 128.05 (4.2%) -0.3% ( -7% - 6%) 0.772 AndHighLow 2126.24 (5.3%) 2124.42 (5.6%) -0.1% ( -10% - 11%) 0.960 Respell 83.33 (3.2%) 83.33 (4.2%) 0.0% ( -7% - 7%) 0.998 OrHighNotHigh 1415.44 (4.4%) 1419.78 (4.5%) 0.3% ( -8% - 9%) 0.827 OrHighNotLow 1655.08 (4.4%) 1663.51 (4.7%) 0.5% ( -8% - 10%) 0.725 OrNotHighHigh 1035.89 (3.1%) 1042.85 (4.6%) 0.7% ( -6% - 8%) 0.587 PKLookup 283.77 (5.1%) 285.92 (4.5%) 0.8% ( -8% - 10%) 0.616 LowTerm 3616.62 (4.1%) 3655.48 (5.3%) 1.1% ( -8% - 10%) 0.476 HighSpanNear 15.54 (2.2%) 15.71 (3.5%) 1.1% ( -4% - 7%) 0.241 MedTerm 2615.07 (4.0%) 2645.27 (4.0%) 1.2% ( -6% - 9%) 0.364 OrNotHighMed 1759.45 (4.2%) 1779.94 (4.6%) 1.2% ( -7% - 10%) 0.406 LowSpanNear 66.06 (2.9%) 66.83 (4.3%) 1.2% ( -5% - 8%) 0.316 BrowseDayOfYearSSDVFacets 26.94 (10.7%) 27.30 (9.7%) 1.3% ( -17% - 24%) 0.684 MedIntervalsOrdered 86.40 (5.1%) 87.58 (4.8%) 1.4% ( -8% - 11%) 0.387 AndHighMed 113.83 (3.4%) 115.48 (5.8%) 1.5% ( -7% - 11%) 0.334 AndHighHigh 42.71 (2.9%) 43.35 (5.8%) 1.5% ( -6% - 10%) 0.300 HighTerm 2639.27 (4.2%) 2678.82 (4.4%) 1.5% ( -6% - 10%) 0.273 HighIntervalsOrdered 11.98 (7.1%) 12.17 (6.7%) 1.5% ( -11% - 16%) 0.480 MedSpanNear 97.91 (2.7%) 99.79 (4.0%) 1.9% ( -4% - 8%) 0.077 LowIntervalsOrdered 222.06 (12.2%) 229.67 (10.9%) 3.4% ( -17% - 30%) 0.348 BrowseDateTaxoFacets 28.41 (35.2%) 31.76 (47.7%) 11.8% ( -52% - 146%) 0.374 BrowseDayOfYearTaxoFacets 28.45 (34.8%) 31.91 (47.4%) 12.2% ( -51% - 144%) 0.355 BrowseRandomLabelTaxoFacets 27.25 (44.3%) 31.80 (60.7%) 16.7% ( -61% - 218%) 0.321 OrHighLow 1204.21 (3.6%) 1475.66 (6.9%) 22.5% ( 11% - 34%) 0.000 OrHighMed 207.04 (6.4%) 285.96 (5.7%) 38.1% ( 24% - 53%) 0.000 OrHighHigh 50.80 (6.2%) 88.52 (8.1%) 74.3% ( 56% - 94%) 0.000 ``` ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value BrowseRandomLabelSSDVFacets 20.99 (8.4%) 20.06 (7.6%) -4.4% ( -18% - 12%) 0.081 Prefix3 264.64 (5.6%) 258.91 (7.0%) -2.2% ( -13% - 11%) 0.278 HighSpanNear 55.97 (2.8%) 55.33 (3.4%) -1.1% ( -7% - 5%) 0.240 BrowseDayOfYearSSDVFacets 27.04 (8.0%) 26.74 (4.1%) -1.1% ( -12% - 12%) 0.591 IntNRQ 123.74 (25.9%) 122.52 (22.6%) -1.0% ( -39% - 64%) 0.898 Wildcard 144.91 (5.7%) 143.53 (5.5%) -0.9% ( -11% - 10%) 0.593 MedSpanNear 58.12 (2.2%) 57.62 (2.6%) -0.9% ( -5% - 4%) 0.266 LowSloppyPhrase 56.23 (2.7%) 55.75 (2.5%) -0.8% ( -5% - 4%) 0.309 LowSpanNear 83.48 (1.9%) 82.83 (2.2%) -0.8% ( -4% - 3%) 0.237 AndHighMedDayTaxoFacets 66.27 (2.1%) 65.85 (1.8%) -0.6% ( -4% - 3%) 0.307 MedTermDayTaxoFacets 61.16 (4.3%) 60.78 (4.9%) -0.6% ( -9% - 8%) 0.676 HighTermMonthSort 197.74 (11.7%) 196.88 (9.9%) -0.4% ( -19% - 23%) 0.898 MedTerm 3912.22 (3.9%) 3899.21 (4.0%) -0.3% ( -7% - 7%) 0.789 AndHighHighDayTaxoFacets 52.69 (1.5%) 52.53 (1.5%) -0.3% ( -3% - 2%) 0.515 PKLookup 285.12 (4.8%) 284.29 (4.2%) -0.3% ( -8% - 9%) 0.837 MedPhrase 155.83 (2.1%) 155.88 (1.7%) 0.0% ( -3% - 3%) 0.962 OrNotHighLow 2052.07 (4.9%) 2053.48 (5.0%) 0.1% ( -9% - 10%) 0.965 Respell 86.89 (3.3%) 86.99 (3.1%) 0.1% ( -6% - 6%) 0.912 Fuzzy1 136.62 (1.9%) 136.98 (2.6%) 0.3% ( -4% - 4%) 0.709 HighPhrase 652.65 (2.1%) 654.44 (1.8%) 0.3% ( -3% - 4%) 0.657 Fuzzy2 104.64 (2.7%) 105.09 (2.3%) 0.4% ( -4% - 5%) 0.591 OrNotHighHigh 1558.41 (2.5%) 1565.23 (2.4%) 0.4% ( -4% - 5%) 0.572 AndHighLow 1378.89 (3.6%) 1385.39 (3.4%) 0.5% ( -6% - 7%) 0.667 HighSloppyPhrase 43.66 (3.8%) 43.88 (3.3%) 0.5% ( -6% - 7%) 0.644 BrowseDateSSDVFacets 4.31 (36.0%) 4.34 (32.6%) 0.6% ( -49% - 107%) 0.955 LowIntervalsOrdered 24.44 (3.3%) 24.60 (3.5%) 0.7% ( -5% - 7%) 0.536 MedSloppyPhrase 121.45 (3.4%) 122.31 (3.2%) 0.7% ( -5% - 7%) 0.499 OrNotHighMed 1518.27 (2.9%) 1530.49 (3.5%) 0.8% ( -5% - 7%) 0.432 LowPhrase 1590.38 (3.3%) 1604.25 (3.9%) 0.9% ( -6% - 8%) 0.447 HighTermDayOfYearSort 227.17 (7.8%) 229.44 (7.7%) 1.0% ( -13% - 17%) 0.684 OrHighNotMed 1426.20 (4.6%) 1440.64 (3.9%) 1.0% ( -7% - 9%) 0.453 HighIntervalsOrdered 6.34 (4.4%) 6.42 (4.8%) 1.2% ( -7% - 10%) 0.413 LowTerm 3170.27 (5.2%) 3208.75 (6.0%) 1.2% ( -9% - 13%) 0.495 OrHighNotLow 1904.11 (4.6%) 1929.56 (3.8%) 1.3% ( -6% - 10%) 0.316 AndHighMed 301.92 (4.1%) 306.40 (3.9%) 1.5% ( -6% - 9%) 0.243 MedIntervalsOrdered 44.71 (4.1%) 45.38 (4.5%) 1.5% ( -6% - 10%) 0.274 OrHighNotHigh 2139.92 (2.9%) 2172.45 (4.3%) 1.5% ( -5% - 8%) 0.191 HighTermTitleBDVSort 300.97 (8.9%) 306.56 (8.5%) 1.9% ( -14% - 21%) 0.499 HighTerm 2745.94 (3.5%) 2799.23 (3.6%) 1.9% ( -4% - 9%) 0.083 TermDTSort 338.13 (6.3%) 345.25 (6.8%) 2.1% ( -10% - 16%) 0.309 AndHighHigh 105.27 (3.0%) 107.76 (3.6%) 2.4% ( -4% - 9%) 0.024 BrowseMonthTaxoFacets 25.29 (31.4%) 25.99 (35.5%) 2.7% ( -48% - 101%) 0.795 OrHighMedDayTaxoFacets 7.05 (7.7%) 7.26 (5.0%) 3.0% ( -9% - 17%) 0.146 BrowseDayOfYearTaxoFacets 27.07 (29.3%) 28.39 (42.0%) 4.8% ( -51% - 107%) 0.672 BrowseDateTaxoFacets 27.00 (29.5%) 28.33 (42.5%) 4.9% ( -51% - 109%) 0.671 BrowseMonthSSDVFacets 29.01 (10.5%) 30.45 (10.7%) 5.0% ( -14% - 29%) 0.139 BrowseRandomLabelTaxoFacets 25.85 (37.4%) 28.27 (58.1%) 9.4% ( -62% - 167%) 0.544 OrHighLow 1322.31 (2.8%) 1506.33 (3.5%) 13.9% ( 7% - 20%) 0.000 OrHighHigh 37.60 (5.5%) 59.95 (9.9%) 59.4% ( 41% - 79%) 0.000 OrHighMed 146.48 (4.4%) 320.00 (10.1%) 118.5% ( 99% - 139%) 0.000 ``` ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value HighTermTitleBDVSort 232.99 (8.7%) 227.90 (6.6%) -2.2% ( -16% - 14%) 0.372 BrowseDayOfYearSSDVFacets 27.67 (9.1%) 27.14 (10.6%) -1.9% ( -19% - 19%) 0.533 AndHighMed 195.79 (4.8%) 192.91 (4.3%) -1.5% ( -10% - 8%) 0.309 Prefix3 752.40 (9.1%) 742.56 (7.8%) -1.3% ( -16% - 17%) 0.627 HighTerm 2655.43 (5.3%) 2622.06 (3.1%) -1.3% ( -9% - 7%) 0.360 AndHighHigh 171.69 (4.6%) 169.66 (4.0%) -1.2% ( -9% - 7%) 0.390 OrNotHighHigh 1275.59 (3.6%) 1261.66 (2.5%) -1.1% ( -6% - 5%) 0.259 OrHighNotHigh 1670.68 (4.4%) 1655.08 (3.0%) -0.9% ( -7% - 6%) 0.433 MedSloppyPhrase 12.51 (2.8%) 12.40 (2.5%) -0.9% ( -5% - 4%) 0.277 OrHighNotMed 1677.16 (4.8%) 1663.03 (3.0%) -0.8% ( -8% - 7%) 0.508 MedTerm 4174.46 (3.9%) 4144.81 (4.6%) -0.7% ( -8% - 8%) 0.598 LowTerm 3205.62 (4.9%) 3183.90 (4.5%) -0.7% ( -9% - 9%) 0.647 IntNRQ 86.34 (8.2%) 85.91 (8.2%) -0.5% ( -15% - 17%) 0.846 PKLookup 290.40 (4.1%) 289.10 (4.4%) -0.4% ( -8% - 8%) 0.740 LowSpanNear 18.90 (2.9%) 18.81 (3.1%) -0.4% ( -6% - 5%) 0.640 OrNotHighMed 1413.70 (2.7%) 1408.55 (3.0%) -0.4% ( -5% - 5%) 0.683 AndHighLow 1965.22 (4.7%) 1958.33 (3.7%) -0.4% ( -8% - 8%) 0.794 OrHighNotLow 1628.65 (4.1%) 1624.17 (3.9%) -0.3% ( -7% - 8%) 0.828 LowSloppyPhrase 244.50 (3.0%) 243.99 (2.2%) -0.2% ( -5% - 5%) 0.802 MedSpanNear 69.69 (3.4%) 69.56 (2.8%) -0.2% ( -6% - 6%) 0.844 LowPhrase 176.86 (3.9%) 176.70 (4.0%) -0.1% ( -7% - 8%) 0.941 HighSpanNear 25.67 (4.0%) 25.65 (3.6%) -0.1% ( -7% - 7%) 0.964 HighIntervalsOrdered 8.08 (10.1%) 8.08 (9.8%) 0.0% ( -18% - 22%) 0.994 LowIntervalsOrdered 90.46 (6.5%) 90.49 (6.4%) 0.0% ( -12% - 13%) 0.988 Wildcard 297.27 (5.4%) 297.43 (4.4%) 0.1% ( -9% - 10%) 0.972 BrowseMonthSSDVFacets 28.60 (8.6%) 28.66 (11.6%) 0.2% ( -18% - 22%) 0.947 MedIntervalsOrdered 69.85 (6.4%) 70.00 (6.4%) 0.2% ( -11% - 13%) 0.913 AndHighHighDayTaxoFacets 32.05 (1.8%) 32.13 (2.4%) 0.3% ( -3% - 4%) 0.705 HighSloppyPhrase 15.93 (3.3%) 16.00 (3.3%) 0.4% ( -6% - 7%) 0.682 OrNotHighLow 1784.41 (4.1%) 1792.59 (4.5%) 0.5% ( -7% - 9%) 0.734 Fuzzy1 146.35 (2.9%) 147.05 (3.8%) 0.5% ( -6% - 7%) 0.656 Respell 114.58 (2.5%) 115.18 (3.1%) 0.5% ( -5% - 6%) 0.559 AndHighMedDayTaxoFacets 134.21 (1.7%) 135.03 (2.6%) 0.6% ( -3% - 4%) 0.373 TermDTSort 176.85 (5.1%) 177.94 (6.9%) 0.6% ( -10% - 13%) 0.747 HighPhrase 134.11 (2.2%) 135.02 (2.8%) 0.7% ( -4% - 5%) 0.394 Fuzzy2 128.74 (2.5%) 129.63 (3.2%) 0.7% ( -4% - 6%) 0.450 MedPhrase 85.90 (2.2%) 86.68 (1.9%) 0.9% ( -3% - 5%) 0.158 MedTermDayTaxoFacets 69.57 (4.2%) 70.39 (4.0%) 1.2% ( -6% - 9%) 0.368 HighTermDayOfYearSort 196.16 (2.7%) 198.50 (6.6%) 1.2% ( -7% - 10%) 0.455 BrowseRandomLabelSSDVFacets 20.42 (9.4%) 20.68 (9.7%) 1.3% ( -16% - 22%) 0.671 BrowseDateSSDVFacets 4.58 (28.7%) 4.66 (32.0%) 1.8% ( -45% - 87%) 0.855 OrHighMedDayTaxoFacets 19.97 (7.5%) 20.62 (6.2%) 3.2% ( -9% - 18%) 0.138 HighTermMonthSort 212.99 (5.8%) 219.92 (8.9%) 3.3% ( -10% - 19%) 0.172 BrowseMonthTaxoFacets 27.65 (35.6%) 31.27 (47.3%) 13.1% ( -51% - 149%) 0.323 BrowseDateTaxoFacets 24.81 (27.6%) 28.54 (43.5%) 15.1% ( -43% - 118%) 0.191 BrowseDayOfYearTaxoFacets 24.85 (26.6%) 28.68 (43.3%) 15.4% ( -43% - 116%) 0.175 BrowseRandomLabelTaxoFacets 23.80 (38.7%) 28.05 (56.9%) 17.8% ( -56% - 185%) 0.247 OrHighLow 886.55 (3.3%) 1105.54 (5.0%) 24.7% ( 15% - 34%) 0.000 OrHighMed 209.42 (6.1%) 304.52 (4.7%) 45.4% ( 32% - 59%) 0.000 OrHighHigh 46.51 (6.4%) 68.85 (6.9%) 48.0% ( 32% - 65%) 0.000 ``` ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value HighTermDayOfYearSort 268.07 (7.6%) 260.40 (3.8%) -2.9% ( -13% - 9%) 0.132 PKLookup 284.74 (5.7%) 278.54 (5.8%) -2.2% ( -12% - 9%) 0.234 BrowseRandomLabelSSDVFacets 20.82 (10.2%) 20.45 (6.7%) -1.8% ( -16% - 16%) 0.512 Fuzzy2 234.77 (3.0%) 230.58 (3.3%) -1.8% ( -7% - 4%) 0.073 MedTermDayTaxoFacets 42.28 (4.7%) 41.56 (5.6%) -1.7% ( -11% - 9%) 0.298 HighTermMonthSort 218.63 (9.6%) 215.12 (7.8%) -1.6% ( -17% - 17%) 0.563 TermDTSort 262.87 (7.8%) 258.91 (7.2%) -1.5% ( -15% - 14%) 0.527 Prefix3 349.11 (7.1%) 344.04 (8.0%) -1.5% ( -15% - 14%) 0.544 AndHighHighDayTaxoFacets 20.76 (2.6%) 20.47 (3.6%) -1.4% ( -7% - 4%) 0.154 OrHighMedDayTaxoFacets 9.09 (5.7%) 8.96 (6.1%) -1.4% ( -12% - 11%) 0.460 Respell 109.27 (3.4%) 107.82 (2.5%) -1.3% ( -6% - 4%) 0.158 Fuzzy1 177.60 (3.9%) 175.30 (2.9%) -1.3% ( -7% - 5%) 0.229 Wildcard 391.34 (8.0%) 386.37 (9.0%) -1.3% ( -16% - 17%) 0.636 MedPhrase 1174.01 (3.6%) 1160.58 (4.8%) -1.1% ( -9% - 7%) 0.396 AndHighMedDayTaxoFacets 34.66 (2.7%) 34.27 (3.4%) -1.1% ( -7% - 5%) 0.243 AndHighMed 334.12 (6.3%) 330.86 (4.8%) -1.0% ( -11% - 10%) 0.584 AndHighLow 1720.82 (5.3%) 1704.25 (4.3%) -1.0% ( -10% - 9%) 0.527 MedSpanNear 18.51 (3.6%) 18.36 (3.8%) -0.8% ( -7% - 6%) 0.491 LowPhrase 159.66 (6.1%) 158.43 (6.3%) -0.8% ( -12% - 12%) 0.693 LowSpanNear 14.66 (3.4%) 14.54 (3.4%) -0.8% ( -7% - 6%) 0.475 OrHighNotLow 1848.94 (4.3%) 1837.32 (4.4%) -0.6% ( -8% - 8%) 0.646 HighSpanNear 36.23 (3.5%) 36.04 (2.7%) -0.5% ( -6% - 5%) 0.590 OrNotHighHigh 1355.23 (4.1%) 1349.28 (4.7%) -0.4% ( -8% - 8%) 0.753 HighPhrase 53.43 (2.7%) 53.22 (3.9%) -0.4% ( -6% - 6%) 0.706 HighSloppyPhrase 54.76 (3.5%) 54.68 (4.3%) -0.2% ( -7% - 7%) 0.899 HighTermTitleBDVSort 199.46 (9.0%) 199.23 (12.6%) -0.1% ( -19% - 23%) 0.973 OrHighNotHigh 1289.90 (3.5%) 1292.38 (3.8%) 0.2% ( -6% - 7%) 0.869 MedSloppyPhrase 23.10 (2.2%) 23.15 (2.7%) 0.2% ( -4% - 5%) 0.780 OrHighNotMed 1880.20 (3.9%) 1886.66 (5.3%) 0.3% ( -8% - 9%) 0.814 OrNotHighLow 1524.76 (3.7%) 1530.74 (4.2%) 0.4% ( -7% - 8%) 0.755 IntNRQ 1154.82 (2.3%) 1159.36 (4.6%) 0.4% ( -6% - 7%) 0.731 BrowseDayOfYearSSDVFacets 26.46 (9.5%) 26.56 (8.8%) 0.4% ( -16% - 20%) 0.890 OrNotHighMed 1280.97 (3.4%) 1286.37 (3.4%) 0.4% ( -6% - 7%) 0.695 LowSloppyPhrase 18.44 (3.1%) 18.53 (3.4%) 0.4% ( -5% - 7%) 0.671 AndHighHigh 64.90 (3.7%) 65.31 (3.3%) 0.6% ( -6% - 7%) 0.565 LowTerm 4926.25 (5.3%) 4962.05 (6.0%) 0.7% ( -10% - 12%) 0.684 HighIntervalsOrdered 12.83 (4.8%) 12.93 (4.5%) 0.8% ( -8% - 10%) 0.608 LowIntervalsOrdered 199.64 (5.5%) 201.26 (5.2%) 0.8% ( -9% - 12%) 0.630 MedIntervalsOrdered 18.57 (5.1%) 18.72 (4.9%) 0.8% ( -8% - 11%) 0.597 HighTerm 3069.83 (4.1%) 3109.22 (5.1%) 1.3% ( -7% - 10%) 0.378 MedTerm 3000.10 (4.0%) 3039.40 (5.1%) 1.3% ( -7% - 10%) 0.365 BrowseMonthSSDVFacets 29.00 (12.5%) 30.24 (13.9%) 4.3% ( -19% - 35%) 0.302 BrowseDateSSDVFacets 4.53 (31.8%) 4.88 (31.7%) 7.7% ( -42% - 104%) 0.445 BrowseDateTaxoFacets 27.12 (37.5%) 29.80 (45.3%) 9.9% ( -53% - 148%) 0.453 BrowseDayOfYearTaxoFacets 27.25 (37.2%) 30.01 (44.3%) 10.1% ( -52% - 145%) 0.433 BrowseRandomLabelTaxoFacets 25.82 (44.7%) 29.41 (60.5%) 13.9% ( -63% - 215%) 0.409 BrowseMonthTaxoFacets 25.92 (35.0%) 29.53 (45.3%) 13.9% ( -49% - 145%) 0.277 OrHighLow 885.95 (4.3%) 1142.96 (3.7%) 29.0% ( 20% - 38%) 0.000 OrHighHigh 46.72 (6.1%) 65.39 (5.8%) 40.0% ( 26% - 55%) 0.000 OrHighMed 144.59 (6.7%) 525.10 (11.3%) 263.2% ( 229% - 301%) 0.000 ``` For > One optimization it has that seemed to help that your scorer doesn't have is to check for every non-essential scorer whether the score obtained so far plus the sum of max scores of non essential scorers that haven't been checked yet is still competitive. I implemented [similar logic]( https://github.com/apache/lucene/pull/972/commits/2f2abd7a133659e8c195afcc04e9435e6328c3e5#diff-6d2292dfdef5525e6205d3298d49b2c81c41ec41bea6e30148f3cf22f6a0f5d0R180-R198) to move the next least contributing essential scorer into non-essential scorer list when minCompetitiveScore increased, I feel the effect would be similar? In terms of next steps, I'm wondering if there's a preference between bulk scorer and scorer implementations when performance improvement is similar (maybe one type of scorer can be used in more places) ? I've learnt a lot from both PRs already and either one looks like a good improvement for disjunction queries! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
