[
https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556683#comment-17556683
]
Adrien Grand commented on LUCENE-10507:
---
It looks like this change help find a re
[
https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556684#comment-17556684
]
Adrien Grand commented on LUCENE-10507:
---
Also we wondered if this change could af
[
https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556688#comment-17556688
]
ASF subversion and git services commented on LUCENE-10507:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556689#comment-17556689
]
ASF subversion and git services commented on LUCENE-10507:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556690#comment-17556690
]
Adrien Grand commented on LUCENE-10507:
---
OK I found the issue with the test. The
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556475#comment-17556475
]
Tomoko Uchida edited comment on LUCENE-10557 at 6/21/22 7:18 AM:
[
https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556723#comment-17556723
]
Tomoko Uchida commented on LUCENE-10622:
Looks like cross-issue links and sub-t
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r902336738
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -121,35 +140,15 @@ public Query rewrite(IndexReader reader) throws
IOException {
return c
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r902366042
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k,
Query filter) {
jpountz commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r902383800
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k,
Query filter) {
[
https://issues.apache.org/jira/browse/LUCENE-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556848#comment-17556848
]
Robert Muir commented on LUCENE-10577:
--
Seems like the codec API needs to be fixed
gsmiller opened a new pull request, #969:
URL: https://github.com/apache/lucene/pull/969
Let's get this marked as deprecated ASAP if we want to actually remove it in
a 10.0 release. Unless we remove it, we won't see any performance benefits of
LUCENE-10603 since we'll still need to do the i
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556891#comment-17556891
]
Greg Miller commented on LUCENE-10603:
--
[~ChrisLu] thanks again for proposing this
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1161727452
Thanks @shaie! I was away from my computer since Thursday but should have
time to catch up on this today, respond to your comments and do another review
pass. Agreed that we're close on thi
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556966#comment-17556966
]
Tomoko Uchida commented on LUCENE-10557:
I was trying to figure out how to uplo
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556966#comment-17556966
]
Tomoko Uchida edited comment on LUCENE-10557 at 6/21/22 3:07 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556475#comment-17556475
]
Tomoko Uchida edited comment on LUCENE-10557 at 6/21/22 3:11 PM:
jpountz merged PR #961:
URL: https://github.com/apache/lucene/pull/961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
gsmiller merged PR #969:
URL: https://github.com/apache/lucene/pull/969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556988#comment-17556988
]
ASF subversion and git services commented on LUCENE-10603:
--
Co
jpountz commented on PR #964:
URL: https://github.com/apache/lucene/pull/964#issuecomment-1161979978
I reverted changes to top-docs collectors. This means this new
`Collector#setWeight` API is only useful to `TotalHitCountCollector`. I've been
wondering if it was worth adding a new API only
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557000#comment-17557000
]
ASF subversion and git services commented on LUCENE-10603:
--
Co
gsmiller commented on PR #969:
URL: https://github.com/apache/lucene/pull/969#issuecomment-1161982047
Thanks @jpountz !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
tang-hi opened a new pull request, #970:
URL: https://github.com/apache/lucene/pull/970
### Description (or a Jira issue link if you have one)
https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-10607?filter=allopenissues
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557029#comment-17557029
]
tangdh commented on LUCENE-10607:
-
Hi, I've raised a Pr to fix the potential integer ov
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1162137822
OK, I think I understand the intention with `FSD` long/int decoding more,
but I think it could be a little confusing in the API currently. If I was a
user, I'd expect there to be four imple
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557061#comment-17557061
]
Tomoko Uchida commented on LUCENE-10557:
Maybe GitHub's API call rate limit wou
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557061#comment-17557061
]
Tomoko Uchida edited comment on LUCENE-10557 at 6/21/22 7:00 PM:
mdmarshmallow commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r903051834
##
lucene/facet/src/java/org/apache/lucene/facet/facetset/RangeFacetSetMatcher.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
mdmarshmallow commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r903055633
##
lucene/facet/src/java/org/apache/lucene/facet/facetset/FacetSetsField.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
gsmiller commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r903051691
##
lucene/demo/src/java/org/apache/lucene/demo/facet/CustomFacetSetExample.java:
##
@@ -0,0 +1,303 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
gsmiller commented on code in PR #914:
URL: https://github.com/apache/lucene/pull/914#discussion_r903092231
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java:
##
@@ -163,6 +164,76 @@ public Number getSpecificValue(String dim, String... path)
throw
Yuti-G commented on PR #914:
URL: https://github.com/apache/lucene/pull/914#issuecomment-1162454475
Thank you so much for the last check! I added more javadoc and a new entry
to the CHANGES.txt. For back-porting, should I wait until this PR is merged and
checkout a new branch against the la
gsmiller commented on PR #914:
URL: https://github.com/apache/lucene/pull/914#issuecomment-1162469235
> For back-porting, should I wait until this PR is merged and checkout a new
branch against the latest branch_9x to cherrypick the merged commit? Thanks
again!
Exactly! Then you can
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557161#comment-17557161
]
ASF subversion and git services commented on LUCENE-10550:
--
Co
gsmiller commented on PR #914:
URL: https://github.com/apache/lucene/pull/914#issuecomment-1162469491
Merged onto `main`. Thanks again @Yuti-G! Exciting to see this new
functionality available :)
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
gsmiller merged PR #914:
URL: https://github.com/apache/lucene/pull/914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
Yuti-G opened a new pull request, #971:
URL: https://github.com/apache/lucene/pull/971
Just using to backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
[
https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557164#comment-17557164
]
Yuting Gan commented on LUCENE-10614:
-
Thank you so much for reviewing and merging
gsmiller merged PR #971:
URL: https://github.com/apache/lucene/pull/971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
gsmiller commented on PR #971:
URL: https://github.com/apache/lucene/pull/971#issuecomment-1162519460
Thanks @Yuti-G !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557174#comment-17557174
]
ASF subversion and git services commented on LUCENE-10550:
--
Co
zacharymorn commented on PR #968:
URL: https://github.com/apache/lucene/pull/968#issuecomment-1162539088
Thanks @wuwm for opening this PR! The improvement idea makes sense to me.
Quick question though, given the similarities of the binary search
implementations in the two methods, is it pos
[
https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557197#comment-17557197
]
chaseny commented on LUCENE-10607:
--
(y)
> NRTSuggesterBuilder扩展input时溢出
> ---
zacharymorn opened a new pull request, #972:
URL: https://github.com/apache/lucene/pull/972
### Description (or a Jira issue link if you have one)
Use Block-Max-Maxscore algorithm for 2 clauses disjunction. Adapted from PR
https://github.com/apache/lucene/pull/101
--
This is an aut
[
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557223#comment-17557223
]
Lu Xugang commented on LUCENE-10603:
Hi, [~gsmiller] when I start to work on the r
zacharymorn commented on PR #972:
URL: https://github.com/apache/lucene/pull/972#issuecomment-1162613846
Hi @jpountz , I have adapted the original BMM PR
https://github.com/apache/lucene/pull/101 to the latest codebase and run
further experiments on using it for 2 clauses disjunction. The r
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r903277452
##
lucene/demo/src/java/org/apache/lucene/demo/facet/CustomFacetSetExample.java:
##
@@ -0,0 +1,303 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r903277577
##
lucene/demo/src/java/org/apache/lucene/demo/facet/CustomFacetSetExample.java:
##
@@ -0,0 +1,303 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r903278541
##
lucene/facet/docs/FacetSets.adoc:
##
@@ -0,0 +1,130 @@
+= FacetSets Overview
+:toc:
+
+This document describes the `FacetSets` capability, which allows to aggregate
on mu
LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r903314253
##
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##
@@ -439,29 +433,42 @@ private void set() {
static final class DocOrds {
final lon
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r903319874
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -92,20 +91,40 @@ public KnnVectorQuery(String field, float[] target, int k,
Query filter) {
52 matches
Mail list logo
