[ 
https://issues.apache.org/jira/browse/LUCENE-10614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557164#comment-17557164
 ] 

Yuting Gan commented on LUCENE-10614:
-------------------------------------

Thank you so much for reviewing and merging the LUCENE-10550 PR! I will start 
working on this issue and will create a PR to properly return topNChildren in 
RangeFacetCounts.

> Properly support getTopChildren in RangeFacetCounts
> ---------------------------------------------------
>
>                 Key: LUCENE-10614
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10614
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: 10.0 (main)
>            Reporter: Greg Miller
>            Priority: Minor
>
> As mentioned in LUCENE-10538, {{RangeFacetCounts}} is not implementing 
> {{getTopChildren}}. Instead of returning "top" ranges, it returns all 
> user-provided ranges in the order the user specified them when instantiating. 
> This is probably more useful functionality, but it would be nice to support 
> {{getTopChildren}} as well.
> LUCENE-10550 is introducing the concept of {{getAllChildren}}, so once that 
> lands, we can replace the current implementation of {{getTopChildren}} with 
> an actual "top children" implementation and direct users to 
> {{getAllChildren}} if they want to maintain the current behavior.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to