zacharymorn commented on PR #968: URL: https://github.com/apache/lucene/pull/968#issuecomment-1162539088
Thanks @wuwm for opening this PR! The improvement idea makes sense to me. Quick question though, given the similarities of the binary search implementations in the two methods, is it possible to extract them out into a common method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org