uschindler commented on code in PR #867:
URL: https://github.com/apache/lucene/pull/867#discussion_r865606003
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java:
##
@@ -52,18 +52,26 @@ private UnknownDictionary() throws IOException {
uschindler opened a new pull request, #868:
URL: https://github.com/apache/lucene/pull/868
see https://issues.apache.org/jira/browse/LUCENE-10558
This is against 9.x branch, but can be forward ported to main.
TODO: This still needs Nori support.
--
This is an automated messag
[
https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532101#comment-17532101
]
Uwe Schindler commented on LUCENE-10558:
Here is my preferred variant: https://
uschindler commented on PR #867:
URL: https://github.com/apache/lucene/pull/867#issuecomment-1118251208
I would not make the IOSupplier ctors available, they are internal only
(IOSupplier is a class which is marked as subject to change).
Because we have `java.nio.files.Path` ctors for
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118253739
In case you ask: This works both with classpath and module usage. The
caller-sensitive parts are `Class#getResource(String)`,
`ClassLoader#getResource(String)`, and `Module#getResource(St
[
https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532117#comment-17532117
]
Uwe Schindler commented on LUCENE-10558:
The latest PR also fixes Nori with the
[
https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10558:
---
Summary: Add URL constructors as complement to Path ctors in Kuromoji and
Nori (was: Expos
[
https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-10558:
--
Assignee: Uwe Schindler
> Add URL constructors for classpath/module usage as complem
[
https://issues.apache.org/jira/browse/LUCENE-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10558:
---
Summary: Add URL constructors for classpath/module usage as complement to
Path ctors in Kur
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865638824
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java:
##
@@ -63,6 +65,17 @@ public ConnectionCosts(Path connectionCostsFi
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865639082
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMap
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865650503
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java:
##
@@ -63,6 +65,17 @@ public ConnectionCosts(Path connectionCostsFi
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865650474
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java:
##
@@ -63,6 +65,17 @@ public ConnectionCosts(Path connectionCostsFile) thro
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865650662
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMapFile, Pa
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865650684
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMap
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865650877
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java:
##
@@ -64,6 +66,20 @@ public UnknownDictionary(Path targetMapFile, Path
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865650926
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java:
##
@@ -64,6 +66,20 @@ public UnknownDictionary(Path targetMapFile
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118281755
Can someone disable this @sonatype-lift, makes no sense for Lucene as we are
no webservers.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118282233
@sonatype-lift silence ignore shutup 👎
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865656370
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMap
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865656501
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMapFile, Pa
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865656677
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMap
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865656735
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/TokenInfoDictionary.java:
##
@@ -89,6 +92,25 @@ public TokenInfoDictionary(Path targetMapFile, Path
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865656822
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/TokenInfoDictionary.java:
##
@@ -89,6 +92,25 @@ public TokenInfoDictionary(Path targetMapFile
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865656911
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/TokenInfoDictionary.java:
##
@@ -89,6 +92,25 @@ public TokenInfoDictionary(Path targetMapFile, Path
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865657065
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/ConnectionCosts.java:
##
@@ -63,6 +65,17 @@ public ConnectionCosts(Path connectionCostsFi
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865657121
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/ConnectionCosts.java:
##
@@ -63,6 +66,17 @@ public ConnectionCosts(Path connectionCostsFile) throws
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865657342
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/UnknownDictionary.java:
##
@@ -62,6 +65,20 @@ public UnknownDictionary(Path targetMapFile, Pa
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865657460
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/TokenInfoDictionary.java:
##
@@ -89,6 +92,25 @@ public TokenInfoDictionary(Path targetMapFile, Path
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865657636
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMap
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865657741
##
lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/TokenInfoDictionary.java:
##
@@ -89,6 +92,25 @@ public TokenInfoDictionary(Path targetMapFile, Path
uschindler commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865658630
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMapFile, Pa
sonatype-lift[bot] commented on code in PR #868:
URL: https://github.com/apache/lucene/pull/868#discussion_r865658659
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary.java:
##
@@ -82,6 +84,25 @@ public TokenInfoDictionary(Path targetMap
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118309403
@mocobeta should be maybe add a note to the deprecated javadocs that the
deprecated ctor no longer works with classpath resources and always loads the
default one?
Or should we cha
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118313342
Thank you @uschindler, I am fine with this!
> This is against 9.x branch, but can be forward ported to main.
I'm inclined to add these URL-based constructors only to 9.x for the
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118316633
> should be maybe add a note to the deprecated javadocs that the deprecated
ctor no longer works with classpath resources and always loads the default one?
> Or should we change it to beh
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118320435
> I'm inclined to add these URL-based constructors only to 9.x for the
temporal remedy; I'm afraid that people use this abusively. (like opening TCP
sockets to load resources from another
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118326675
(As for sonatype-lift bot, it repeatedly reports the same warnings per push;
I once tried to silence it and gave up... I'd agree with disabling it for
lucene.)
--
This is an automated me
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118328012
But yes, one workaround for Mike is to rebuild the JAR files. An alternative
that always works (outside module system) is to place the JAR file with the
resources in a separate JAR file a
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118329537
> (As for sonatype-lift bot, it repeatedly reports the same warnings per
push; I once tried to silence it and gave up... I'd agree with disabling it for
lucene.)
Especially as thos
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118332065
See
[TikaInputStream](https://tika.apache.org/1.28.2/api/org/apache/tika/io/TikaInputStream.html#get-java.net.URL-org.apache.tika.metadata.Metadata-)
for an example that allow URL next to
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118340545
Personally, I don't think we should allow users to load resources from
anyware... It's not the sensible way to load the dictionary resources as far as
I know. If you need external resources
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118346475
> Personally, I don't think we should allow users to load resources from
anyware... It's not the sensible way to load the dictionary resources as far as
I know. If you need external resou
romseygeek merged PR #860:
URL: https://github.com/apache/lucene/pull/860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
[
https://issues.apache.org/jira/browse/LUCENE-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532157#comment-17532157
]
ASF subversion and git services commented on LUCENE-10553:
--
Co
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118353023
Thanks for explaining, then I don't have an objection to forward porting;
maybe we'll need it to make it possible to load the resources from another jar.
--
This is an automated message f
romseygeek opened a new pull request, #869:
URL: https://github.com/apache/lucene/pull/869
When this was refactored previously, we moved a public static method from
DocValuesFieldExistsQuery to the package-private DocValuesIterator class.
This
makes the method available again by movin
romseygeek commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118356099
When I backport I'll add a deprecated forwarding method to
DocValuesFieldExistsQuery again, to make it a bit more obvious on how to
migrate.
--
This is an automated message from the Ap
romseygeek commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118357618
Having said that, looking at the existing MIGRATE instructions, maybe the
most sensible thing is to have this method on FieldExistsQuery directly? Then
existing code that references the d
[
https://issues.apache.org/jira/browse/LUCENE-10553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532161#comment-17532161
]
ASF subversion and git services commented on LUCENE-10553:
--
Co
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118408717
OK. I opened this PR against 9.x because it makes it easier to add the
changes in deprecation messages. When forward porting just tell the
merge/cherrypick on main to "use theirs".
--
rmuir commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118416936
what is going on here? why are we allowing such stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmuir commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118418901
> Personally, I don't think we should allow users to load resources from
anyware... It's not the sensible way to load the dictionary resources as far as
I know. If you need external resources
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118422000
In short: Some people like Mike Sokolov at Amazon wants to load custom
ConnectionCosts and TermInfoDicts and Unk dicts from custom resources. This was
working previously with file system
rmuir commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118425532
yes, please, lets remove any File,Path,URL,URL,whatever ctors. The code is
open-source if amazon wants to build a custom crazy jar. We can't make all the
apis complicated and unusable for such
msokolov commented on code in PR #867:
URL: https://github.com/apache/lucene/pull/867#discussion_r865801802
##
lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/UnknownDictionary.java:
##
@@ -52,18 +52,26 @@ private UnknownDictionary() throws IOException {
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118442012
Let's give @msokolov a chance to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
msokolov commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118443078
> In case you ask: This works both with classpath and module usage. The
caller-sensitive parts are `Class#getResource(String)`,
`ClassLoader#getResource(String)`, and `Module#getResource(St
rmuir commented on PR #867:
URL: https://github.com/apache/lucene/pull/867#issuecomment-1118443273
I don't think we shoudl do this, same reasons as stated on #868
These things should be loaded from jar as singletons and that's it.
--
This is an automated message from the Apache Git
msokolov commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118449412
Oh, I missed Robert's objections. Sorry, I don't understand the problem
here. The way Kuromoji works, it uses a language model that is trained from a
corpus of text to do tokenization. We j
rmuir commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118450647
> Oh, I missed Robert's objections. Sorry, I don't understand the problem
here. The way Kuromoji works, it uses a language model that is trained from a
corpus of text to do tokenization. We ju
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118457174
> The format is not proprietary, it was promoted by Mecab I think, which is
the tool used to train the dictionary, and is open-source.
It is proprietary because the FST in the Token
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118462741
I will leave that PR open for discussion. I just implemented the minimal
approach + test to make the API compatible to classpath.
We can still allow to use the IOSuppliers, but then
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532223#comment-17532223
]
Deepika Sharma edited comment on LUCENE-10151 at 5/5/22 12:16 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532223#comment-17532223
]
Deepika Sharma commented on LUCENE-10151:
-
I am exploring adding timeout suppor
rmuir commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118480829
Uwe explains it clearly, such APIs are impossible to support correctly and
we don't need to add backwards-compatibility or anything else.
Files such as `ConnectionCosts.dat` are not sta
rmuir commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118511195
Why in the world are we moving a method to DocValues API that is only used
by 3 callsites. Please, let's make it package private somewhere else.
--
This is an automated message from the Apac
romseygeek commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118516530
> Please, let's make it package private somewhere else.
It already is package private, but it was public before, and we use it in
elasticsearch code. I'm happy to put it elsewhere
rmuir commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118526833
> It already is package private, but it was public before, and we use it in
elasticsearch code. I'm happy to put it elsewhere (on FieldExistsQuery maybe?)
but I don't think we can just remove
msokolov commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118535867
> Use the gradle build to make a jar then.
Is the idea that we would fork analysis/kuromoji package? That would be sad,
but maybe you meant something else? Uwe mentioned some kind of
romseygeek commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118537137
I'd argue that it's a revert of an API change - it's a public method in 9.1
and currently we're removing it in 9.2 with no CHANGES entry or information
about how to migrate. And the fact
msokolov commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118552882
Also - I don't really buy the idea that we can't support binary file formats
- the entire index is filled with binary files. In this case we provide tools
for generating these files, so use
rmuir commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118557005
I'm not so opposed to the method being public somewhere, I'm more
questioning the need to put it in `DocValues` api. This is what grabbed my
attention. Would love to keep this API simple and m
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118561015
I have complex feelings about it and I understand both opinions...
Current APIs in 9.x to load custom resources are not perfect (or bad, I dare
to say), meanwhile "customizable/switch
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118585168
> Also - I don't really buy the idea that we can't support binary file
formats - the entire index is filled with binary files. In this case we provide
tools for generating these files, so
romseygeek commented on PR #869:
URL: https://github.com/apache/lucene/pull/869#issuecomment-1118588920
That I agree with! I'll update and put it on FieldExistsQuery - it was on
DocValuesFieldExistsQuery before, which has been deprecated but now extends
FEQ, and so it should make the trans
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118606210
To come back to current issue: I see no problem in this PR it does not make
it worse, just better. Path and URI are just holders of a resource. Path is
used for filesystem, URL is returne
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118611460
The alternative would be - as said before - remove Path ctors and use
IOSupplier only. But that's worse (maybe it prevents people from doing this,
haha).
--
This is an automated messag
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10550:
-
Component/s: modules/facet
> Add getAllChildren functionality to facets
> -
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532277#comment-17532277
]
Greg Miller edited comment on LUCENE-10550 at 5/5/22 2:37 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532277#comment-17532277
]
Greg Miller commented on LUCENE-10550:
--
I'm also +1 on this but with a minor sugge
rmuir commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118635459
> I know, Robert does not like some details of the URL class, but they don't
hit us here.
https://twitter.com/tnurkiewicz/status/1519643900423688192
Sorry, couldn't resist
--
T
[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-10538:
-
Component/s: modules/facet
> TopN is not being used in getTopChildren()
> -
mayya-sharipova commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1118635984
@LuXugang Do you want to make this PR against `apache:vectors-disi-direct`
branch, so that we can merge it into this branch.
--
This is an automated message from the Apache Git Ser
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118638144
> I see no problem in this PR - it does not make it worse, just better.
Thanks @uschindler, I totally agree with that.
I am +1 to this PR and keeping IOSupplier-based ones priva
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1118642667
Yes, thanks @mayya-sharipova ,then I will continue to do the format changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
mayya-sharipova commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1118648748
@LuXugang Please change the base of this PR to `apache:vectors-disi-direct`
yourself, and after that I can merge this PR to this branch.
--
This is an automated message from the A
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118651872
> I would like URI more,
The same is true for me. We'd need URI, not URL...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1118656979
> @LuXugang Please change the base of this PR to
`apache:vectors-disi-direct` yourself, and after that I can merge this PR to
this branch.
@mayya-sharipova done.
--
This is an aut
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118665915
> > I would like URI more,
>
> The same is true for me. We'd need URI, not URL...
The difference is that URI is just an identificator, but to get an
InputStream you need to c
mocobeta commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118816930
Ah sorry for my vague comment, I know the difference between URI and URL;
and I understand there is no problem in using URL here.
I think we can ship this with 9.2? As an engineer who
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118841012
Sure, I would proceed with this plan and merge to 9.x and main. If we have
better ideas (like proposed earlier) for main we can change it there.
--
This is an automated message from the
risdenk commented on PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#issuecomment-1118841603
superceded by https://github.com/apache/solr/pull/831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
risdenk closed pull request #2651: SOLR-16110 Using Schema/Config API breaks
the File-Upload of Config Set File
URL: https://github.com/apache/lucene-solr/pull/2651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118843405
I still don't know if we can fix the deprecated ctors to handle the
CLASSPATH resource name correctly. In my original LUCENE-10335 change it was
still working (we had a test for it), but
uschindler commented on PR #868:
URL: https://github.com/apache/lucene/pull/868#issuecomment-1118848400
I think I can fix the old ctor so it works again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mocobeta commented on PR #540:
URL: https://github.com/apache/lucene/pull/540#issuecomment-1118861297
I'm sorry for the late response. I just kicked the CI - I'll take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532447#comment-17532447
]
ASF subversion and git services commented on LUCENE-10502:
--
Co
mayya-sharipova commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1118864081
@LuXugang Thanks, feel free to create a follow-up format PR against
`apache:vectors-disi-direct`
--
This is an automated message from the Apache Git Service.
To respond to the mess
mayya-sharipova merged PR #792:
URL: https://github.com/apache/lucene/pull/792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
1 - 100 of 117 matches
Mail list logo
