uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1118422000
In short: Some people like Mike Sokolov at Amazon wants to load custom ConnectionCosts and TermInfoDicts and Unk dicts from custom resources. This was working previously with file system and with classloader. The API of Classloading uses URL as resource, while while files use Path objects. So IMHO: - either remove both "Path and URL" ctors (my preference) - or add both (like done here to support Solr, Elasticsearch and Amazon to load dictionaries from custom JAR files) - or just add `IOSupplier<InputStream>` ctor, but that even worse as this is an internal class and should not be in public APIs. The question I ask also to @msokolov : Why the hell does naybody want to modify the dictioaries that are in highly propiertary format. To generate those files, you need to generate them with Gradle anyways (the FST, the compiler for connection costs). So anybody can just compile and package your own JAR file? So I agree with Robert here: Why do we need to make it customizable, there's no added value to provide some proprietary, non-standardized file formats to the ctor as external resource. This was a bug already in early versions of Kuromoji. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
