uschindler commented on PR #868: URL: https://github.com/apache/lucene/pull/868#issuecomment-1118606210
To come back to current issue: I see no problem in this PR it does not make it worse, just better. Path and URI are just holders of a resource. Path is used for filesystem, URL is returned by getResource() methods. I would like URI more, but Java's classloading uses URL also with modue system, so it is the only "correct" way to refer to a resource in a class or module loader. I know, Robert does not like some details of the URL class, but they don't us here. The new API is definitely better than the old deprecated one, which was also broken from beginning leading to the confusion that @msokolov has seen. We should mark the Path and URL APIs with `@lucene.internal` and warn users that we provide no garantiees when you use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
