rmuir commented on PR #869: URL: https://github.com/apache/lucene/pull/869#issuecomment-1118557005
I'm not so opposed to the method being public somewhere, I'm more questioning the need to put it in `DocValues` api. This is what grabbed my attention. Would love to keep this API simple and minimal and without exotic stuff. Today the methods it uses are type-safe and here we are adding a relatively "untyped" method to get a generic iterator over any DV type. If you look at the other methods in the file, it really doesn't fit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
