[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-04-20 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524856#comment-17524856 ] Adrien Grand commented on LUCENE-10421: --- Query latency of vector queries became m

[GitHub] [lucene] iverase commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
iverase commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r854066472 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double

[GitHub] [lucene] iverase commented on pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
iverase commented on PR #809: URL: https://github.com/apache/lucene/pull/809#issuecomment-1103866748 I run the performance test and no significant change on performance: ``` Index time (sec)||Force merge time (sec)||Index size (GB)||Reader heap (MB)|| ||Dev||Base||Diff ||Dev ||B

[GitHub] [lucene] rmuir commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
rmuir commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1103914462 > +1 to a single source of source/target Java version(s). A simple key-value format may be easily used from the outside world of java/gradle - github actions scripts or the smoke tester, and s

[GitHub] [lucene] nknize commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
nknize commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r854177310 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double b

[GitHub] [lucene] iverase commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
iverase commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r854187793 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double

[GitHub] [lucene] iverase opened a new pull request, #824: LUCENE-10508: Fix error for rectangles with an extent close to 180 degrees

2022-04-20 Thread GitBox
iverase opened a new pull request, #824: URL: https://github.com/apache/lucene/pull/824 In https://github.com/apache/lucene/pull/804 we fixes some edge cases when building rectangles where min longitude and max longitude were very close together. This introduced now problems when the min/ma

[GitHub] [lucene] nknize commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
nknize commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r854196239 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double b

[GitHub] [lucene] iverase commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
iverase commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r854207988 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double

[GitHub] [lucene] iverase merged pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
iverase merged PR #809: URL: https://github.com/apache/lucene/pull/809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10514) Some Component2D#within* implementations inconsistent with Component2D#relate

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525029#comment-17525029 ] ASF subversion and git services commented on LUCENE-10514: -- Co

[jira] [Updated] (LUCENE-10228) PerFieldKnnVectorsFormat can write to wrong format name

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10228: -- Labels: vector-based-search (was: ) > PerFieldKnnVectorsFormat can write to

[jira] [Updated] (LUCENE-9004) Approximate nearest vector search

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-9004: - Labels: vector-based-search (was: ) > Approximate nearest vector search > -

[jira] [Resolved] (LUCENE-10514) Some Component2D#within* implementations inconsistent with Component2D#relate

2022-04-20 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10514. --- Fix Version/s: 9.2 Assignee: Ignacio Vera Resolution: Fixed > Some Componen

[jira] [Commented] (LUCENE-10514) Some Component2D#within* implementations inconsistent with Component2D#relate

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525032#comment-17525032 ] ASF subversion and git services commented on LUCENE-10514: -- Co

[jira] [Updated] (LUCENE-10178) Add toString for inspecting Lucene90HnswVectorsFormat

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10178: -- Labels: vector-based-search (was: ) > Add toString for inspecting Lucene90Hn

[jira] [Updated] (LUCENE-10146) Add VectorSimilarityFunction.COSINE

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10146: -- Labels: vector-based-search (was: ) > Add VectorSimilarityFunction.COSINE >

[jira] [Updated] (LUCENE-10142) use a better RNG for Hnsw vectors

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10142: -- Labels: vector-based-search (was: ) > use a better RNG for Hnsw vectors > --

[GitHub] [lucene] iverase commented on pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
iverase commented on PR #809: URL: https://github.com/apache/lucene/pull/809#issuecomment-1104008701 Thanks for the review @nknize! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Updated] (LUCENE-10130) HnswGraph could make use of a SparseFixedBitSet.getAndSet

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10130: -- Labels: vector-based-search (was: ) > HnswGraph could make use of a SparseFi

[jira] [Updated] (LUCENE-10063) SimpleTextKnnVectorsReader.search needs an implementation

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10063: -- Labels: vector-based-search (was: ) > SimpleTextKnnVectorsReader.search need

[GitHub] [lucene] dweiss commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
dweiss commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104010860 Windows will be a problem, as it always is, argh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (LUCENE-10040) Handle deletions in nearest vector search

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10040: -- Labels: vector-based-search (was: ) > Handle deletions in nearest vector sea

[jira] [Updated] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10016: -- Labels: vector-based-search (was: ) > VectorReader.search needs rethought, o

[jira] [Updated] (LUCENE-10015) Remove VectorValues.SimilarityFunction.NONE

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10015: -- Labels: vector-based-search (was: ) > Remove VectorValues.SimilarityFunction

[jira] [Updated] (LUCENE-9908) Move VectorValues#search to VectorReader and LeafReader

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-9908: - Labels: vector-based-search (was: ) > Move VectorValues#search to VectorReader

[jira] [Updated] (LUCENE-9905) Revise approach to specifying NN algorithm

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-9905: - Labels: vector-based-search (was: ) > Revise approach to specifying NN algorith

[jira] [Updated] (LUCENE-9855) Reconsider names for ANN related format and APIs

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-9855: - Labels: vector-based-search (was: ) > Reconsider names for ANN related format a

[GitHub] [lucene] rmuir commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
rmuir commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104016177 > Windows will be a problem, as it always is, argh. why is windows a problem? this PR works perfectly fine on windows. I didnt touch the .bat file because, unlike the .sh file, it has no

[jira] [Updated] (LUCENE-9837) try to improve performance of VectorUtil.dotProduct

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-9837: - Labels: vector-based-search (was: ) > try to improve performance of VectorUtil.

[jira] [Updated] (LUCENE-9322) Discussing a unified vectors format API

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-9322: - Labels: vector-based-search (was: ) > Discussing a unified vectors format API >

[jira] [Commented] (LUCENE-10153) More speedups for operations on byte[] via VarHandles

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525044#comment-17525044 ] ASF subversion and git services commented on LUCENE-10153: -- Co

[jira] [Commented] (LUCENE-10153) More speedups for operations on byte[] via VarHandles

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525043#comment-17525043 ] ASF subversion and git services commented on LUCENE-10153: -- Co

[jira] [Updated] (LUCENE-10453) Speed up VectorUtil#squareDistance

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10453: -- Labels: vector-based-search (was: ) > Speed up VectorUtil#squareDistance > -

[jira] [Updated] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10421: -- Labels: vector-based-search (was: ) > Non-deterministic results from KnnVect

[jira] [Updated] (LUCENE-10408) Better dense encoding of doc Ids in Lucene91HnswVectorsFormat

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10408: -- Labels: vector-based-search (was: ) > Better dense encoding of doc Ids in Lu

[jira] [Updated] (LUCENE-10391) Reuse data structures across HnswGraph invocations

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10391: -- Labels: vector-based-search (was: ) > Reuse data structures across HnswGraph

[jira] [Updated] (LUCENE-10375) Speed up HNSW merge by writing combined vector data

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10375: -- Labels: vector-based-search (was: ) > Speed up HNSW merge by writing combine

[jira] [Updated] (LUCENE-10382) Allow KnnVectorQuery to operate over a subset of liveDocs

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10382: -- Labels: vector-based-search (was: ) > Allow KnnVectorQuery to operate over a

[jira] [Updated] (LUCENE-10351) Correct knn search failure with all deleted docs

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10351: -- Labels: vector-based-search (was: ) > Correct knn search failure with all d

[jira] [Updated] (LUCENE-10309) Minimum KnnVector codec support in Luke

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10309: -- Labels: vector-based-search (was: ) > Minimum KnnVector codec support in Luk

[jira] [Updated] (LUCENE-10183) KnnVectorsWriter#writeField should take a KnnVectorsReader, not a VectorValues instance

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10183: -- Labels: vector-based-search (was: ) > KnnVectorsWriter#writeField should tak

[jira] [Updated] (LUCENE-10054) Handle hierarchy in HNSW graph

2022-04-20 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated LUCENE-10054: -- Labels: vector-based-search (was: ) > Handle hierarchy in HNSW graph > -

[GitHub] [lucene] rmuir merged pull request #818: Fix incorrect docs in README.md: it must be java 17 exactly, java 18 does not work

2022-04-20 Thread GitBox
rmuir merged PR #818: URL: https://github.com/apache/lucene/pull/818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or

[GitHub] [lucene] nknize commented on a diff in pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

2022-04-20 Thread GitBox
nknize commented on code in PR #809: URL: https://github.com/apache/lucene/pull/809#discussion_r854258259 ## lucene/core/src/java/org/apache/lucene/geo/Polygon2D.java: ## @@ -257,10 +257,13 @@ public WithinRelation withinLine( boolean ab, double bX, double b

[GitHub] [lucene] jpountz merged pull request #823: Clarify that terms dicts are per-field in block-tree's javadocs.

2022-04-20 Thread GitBox
jpountz merged PR #823: URL: https://github.com/apache/lucene/pull/823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] dweiss commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
dweiss commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104077352 Maybe I misunderstood something - this comment: > and it could be read from this bash script with source I don't think you can do fancy stuff like this from cmd. Maybe from power

[GitHub] [lucene] dweiss commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
dweiss commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104081213 I'll take a look if I can modify the windows scripts the same way - it should be doable. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [lucene] rmuir commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
rmuir commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104088255 There's no version numbers in the .bat script. Hence no need for it to be able to suck in .properties file? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene] rmuir commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
rmuir commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104092136 OK now there is ... but you created the monster :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] dweiss commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
dweiss commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104092938 There's the emitted message there - I've just pushed a commit to your branch that does the same thing as the bash does. I think it's fine. We can probably add a test to check whether those sc

[GitHub] [lucene] rmuir commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
rmuir commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104096183 i'm fine with starting the properties file here, but the problem is not exactly new. really fixing all the stuff like smoketester, eclipse linter config, etc etc is gonna be some amount of wor

[GitHub] [lucene] dweiss commented on pull request #819: fail clearly on too-new JDK

2022-04-20 Thread GitBox
dweiss commented on PR #819: URL: https://github.com/apache/lucene/pull/819#issuecomment-1104097188 Yeah - I think we should do it as a separate issue. It'll be clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] dweiss commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-20 Thread GitBox
dweiss commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1104169873 I created an issue in spotless to perhaps customize the message right where it's emitted - in the SpotlessCheck task. diffplug/spotless#1175 -- This is an automated message from the Apache

[GitHub] [lucene] dweiss commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-20 Thread GitBox
dweiss commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1104244458 [spotless-msg.txt](https://github.com/apache/lucene/files/8523965/spotless-msg.txt) This patch implements the idea I mentioned - create an additional build failure/ message if any of t

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #822: LUCENE-10526: add single method to mockfile to wrap a Path

2022-04-20 Thread GitBox
gautamworah96 commented on code in PR #822: URL: https://github.com/apache/lucene/pull/822#discussion_r854391999 ## lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterFileSystemProvider.java: ## @@ -116,7 +116,11 @@ public Path getPath(URI uri) { if (file

[GitHub] [lucene] dweiss commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-20 Thread GitBox
dweiss commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1104245803 This is what the patched output looks like, btw. ![image](https://user-images.githubusercontent.com/199470/164292602-2990a609-bc50-48c7-95c1-0e92b2b1c370.png) -- This is an automated

[GitHub] [lucene] rmuir commented on a diff in pull request #822: LUCENE-10526: add single method to mockfile to wrap a Path

2022-04-20 Thread GitBox
rmuir commented on code in PR #822: URL: https://github.com/apache/lucene/pull/822#discussion_r854435033 ## lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterFileSystemProvider.java: ## @@ -116,7 +116,11 @@ public Path getPath(URI uri) { if (fileSystem =

[jira] [Commented] (LUCENE-10524) Augment CONTRIBUTING.md guide with instructions on how/when to benchmark

2022-04-20 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525214#comment-17525214 ] Gautam Worah commented on LUCENE-10524: --- I have a slight personal preference towa

[GitHub] [lucene] rmuir commented on pull request #822: LUCENE-10526: add single method to mockfile to wrap a Path

2022-04-20 Thread GitBox
rmuir commented on PR #822: URL: https://github.com/apache/lucene/pull/822#issuecomment-1104369976 @gautamworah96 care to take another look? I think fixing the tiny nit was helpful to our tests. now it is easier for tests to wrap a path with one of these mock filesystems explicitly, as they

[jira] [Commented] (LUCENE-8580) Make segment merging parallel in SegmentMerger

2022-04-20 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525244#comment-17525244 ] Vigya Sharma commented on LUCENE-8580: -- I'm thinking of tackling this one data stru

[GitHub] [lucene] zhaih merged pull request #778: LUCENE-10495: Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-20 Thread GitBox
zhaih merged PR #778: URL: https://github.com/apache/lucene/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or

[jira] [Commented] (LUCENE-10495) Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525247#comment-17525247 ] ASF subversion and git services commented on LUCENE-10495: -- Co

[GitHub] [lucene] Yuti-G opened a new pull request, #825: LUCENE-10495: Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-20 Thread GitBox
Yuti-G opened a new pull request, #825: URL: https://github.com/apache/lucene/pull/825 Backport of #778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [lucene] rmuir commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-20 Thread GitBox
rmuir commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1104420132 > I also discovered that afterTask is deprecated and scheduled to be removed in the future - something to be aware of. Perhaps when they update their example in the documentation, then I

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-04-20 Thread GitBox
mayya-sharipova commented on code in PR #792: URL: https://github.com/apache/lucene/pull/792#discussion_r854526400 ## lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java: ## @@ -207,15 +210,41 @@ private void writeMeta( // write docIDs

[GitHub] [lucene] rmuir commented on pull request #822: LUCENE-10526: add single method to mockfile to wrap a Path

2022-04-20 Thread GitBox
rmuir commented on PR #822: URL: https://github.com/apache/lucene/pull/822#issuecomment-1104430915 Thanks for reviewing, and good luck improving the act-like-Windows! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] rmuir merged pull request #822: LUCENE-10526: add single method to mockfile to wrap a Path

2022-04-20 Thread GitBox
rmuir merged PR #822: URL: https://github.com/apache/lucene/pull/822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or

[jira] [Commented] (LUCENE-10526) add single method to mockfile to wrap a Path

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525275#comment-17525275 ] ASF subversion and git services commented on LUCENE-10526: -- Co

[jira] [Commented] (LUCENE-10526) add single method to mockfile to wrap a Path

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525281#comment-17525281 ] ASF subversion and git services commented on LUCENE-10526: -- Co

[jira] [Resolved] (LUCENE-10526) add single method to mockfile to wrap a Path

2022-04-20 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10526. -- Fix Version/s: 9.2 Resolution: Fixed > add single method to mockfile to wrap a Path >

[GitHub] [lucene] mayya-sharipova commented on pull request #792: LUCENE-10502: Use IndexedDISI to store docIds and DirectMonotonicWriter/Reader to handle ordToDoc

2022-04-20 Thread GitBox
mayya-sharipova commented on PR #792: URL: https://github.com/apache/lucene/pull/792#issuecomment-1104454465 @LuXugang Thank you for your extra test results. It seems to me that 100k documents is rather small data set, we usually run a test on a dataset of 1M docs (which could be more usefu

[GitHub] [lucene] zhaih merged pull request #825: LUCENE-10495: Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-20 Thread GitBox
zhaih merged PR #825: URL: https://github.com/apache/lucene/pull/825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or

[jira] [Commented] (LUCENE-10495) Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525315#comment-17525315 ] ASF subversion and git services commented on LUCENE-10495: -- Co

[jira] [Created] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-04-20 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-10527: - Summary: Use bigger maxConn for last layer in HNSW Key: LUCENE-10527 URL: https://issues.apache.org/jira/browse/LUCENE-10527 Project: Lucene - Core

[GitHub] [lucene] Yuti-G commented on pull request #778: LUCENE-10495: Fix return statement of siblingsLoaded() in TaxonomyFacets

2022-04-20 Thread GitBox
Yuti-G commented on PR #778: URL: https://github.com/apache/lucene/pull/778#issuecomment-1104512792 Thanks @zhaih ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-04-20 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Description: Recently I was rereading the HNSW paper ([https://arxiv.org/pdf/1603.09

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-04-20 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Description: Recently I was rereading the HNSW paper ([https://arxiv.org/pdf/1603.09

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-04-20 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Attachment: (was: hnsw_plot.png) > Use bigger maxConn for last layer in HNSW > --

[GitHub] [lucene] wjp719 commented on pull request #786: LUCENE-10499: reduce unnecessary copy data overhead when growing array size

2022-04-20 Thread GitBox
wjp719 commented on PR #786: URL: https://github.com/apache/lucene/pull/786#issuecomment-1104631511 @rmuir @jpountz Hi, this pr is ready to be merged, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene] dweiss commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-20 Thread GitBox
dweiss commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1104720998 Yeah - the docs are riddled with these examples. I found it quite astonishing that they've deprecated such an important bit of functionality (not just this method but any build callback hooks

[GitHub] [lucene] dweiss commented on pull request #817: improve spotless error to suggest running 'gradlew tidy'

2022-04-20 Thread GitBox
dweiss commented on PR #817: URL: https://github.com/apache/lucene/pull/817#issuecomment-1104721448 Please feel free to merge - I'll provide a patch for spotless and then we can clean it up, once upgrading. -- This is an automated message from the Apache Git Service. To respond to the mes