mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1073666978
@romseygeek sorry to bother you, just a reminder :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jpountz merged pull request #754:
URL: https://github.com/apache/lucene/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509718#comment-17509718
]
ASF subversion and git services commented on LUCENE-10473:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509721#comment-17509721
]
ASF subversion and git services commented on LUCENE-10473:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509720#comment-17509720
]
ASF subversion and git services commented on LUCENE-10473:
--
Co
jpountz commented on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073690606
One downside of this approach is that nobody could just copy-paste the
suggested command to run the smoke tester any longer, they would always have to
tune the temporary path. I'd
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509741#comment-17509741
]
Adrien Grand commented on LUCENE-10448:
---
bq. we could handle the edge case of whe
iverase opened a new pull request #756:
URL: https://github.com/apache/lucene/pull/756
Similar to LUCENE-9580, It might happen that the new edge introduced when
removing a tile is collinear with edges from the resulting polygon. This
situation makes this edges not eligible for filtering b
jpountz commented on a change in pull request #736:
URL: https://github.com/apache/lucene/pull/736#discussion_r827810798
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -198,16 +200,23 @@ public boolea
janhoy commented on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073746350
Perhaps we could have an env var `LUCENE_SMOKE_TESTER_TMP_DIR` that the
smoke tester would respect, then devs can set that once and be happy?
--
This is an automated message from
[
https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509783#comment-17509783
]
Ignacio Vera commented on LUCENE-10470:
---
Thanks [~yixunx] fro reporting.
Indeed
mocobeta commented on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073827624
Thanks for your feedback and suggestions.
I reverted the command line to keep it as is.
The option could still be useful for some situations, I added a description
of it in
mocobeta edited a comment on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073827624
Thanks for your feedback and suggestions.
I reverted the command line to keep it as is.
The option could still be useful for some situations, I added a description
o
Christine Poerschke created LUCENE-10477:
Summary: SpanBoostQuery.rewrite was no-op for boost==1 factor
Key: LUCENE-10477
URL: https://issues.apache.org/jira/browse/LUCENE-10477
Project: Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509827#comment-17509827
]
Adrien Grand commented on LUCENE-10477:
---
It should be ok given that callers are e
[
https://issues.apache.org/jira/browse/LUCENE-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509828#comment-17509828
]
Christine Poerschke commented on LUCENE-8637:
-
bq. Method mustRewriteQuery(S
cpoerschke opened a new pull request #2650:
URL: https://github.com/apache/lucene-solr/pull/2650
https://issues.apache.org/jira/browse/LUCENE-10477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509835#comment-17509835
]
Christine Poerschke commented on LUCENE-10477:
--
For 8.0 this should be the
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509841#comment-17509841
]
Adrien Grand commented on LUCENE-10477:
---
Thanks Christine, this is where the bug
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509842#comment-17509842
]
Christine Poerschke commented on LUCENE-10477:
--
bq. ... callers are expect
jpountz commented on a change in pull request #737:
URL: https://github.com/apache/lucene/pull/737#discussion_r831103798
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java
##
@@ -309,11 +309,11 @@ protected void extractW
cpoerschke commented on a change in pull request #737:
URL: https://github.com/apache/lucene/pull/737#discussion_r831107050
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java
##
@@ -309,11 +309,11 @@ protected void extra
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated LUCENE-10477:
-
Summary: SpanBoostQuery.rewrite was incomplete for boost==1 factor (was:
SpanB
cpoerschke commented on pull request #2650:
URL: https://github.com/apache/lucene-solr/pull/2650#issuecomment-1073947536
closing in favour of https://github.com/apache/lucene/pull/737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cpoerschke closed pull request #2650:
URL: https://github.com/apache/lucene-solr/pull/2650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
jpountz commented on a change in pull request #737:
URL: https://github.com/apache/lucene/pull/737#discussion_r831152924
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java
##
@@ -309,11 +309,12 @@ protected void extractW
ywelsch commented on pull request #752:
URL: https://github.com/apache/lucene/pull/752#issuecomment-1073949409
> I'm still -1 for the change. If you hit StackOverFlowError, really you
should let the VM exit. There are no guarantees at this point.
That kind of argument makes it even m
romseygeek commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1073951849
One last thing, can you add a CHANGES.txt entry in the Lucene 9.2.0 New
Features section? And then I think we're good to merge! Thanks for all your
patience on this.
--
This
cpoerschke commented on a change in pull request #737:
URL: https://github.com/apache/lucene/pull/737#discussion_r831158244
##
File path:
lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java
##
@@ -309,11 +309,12 @@ protected void extra
mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1073983473
Done!
Thanks for Your patience and support @romseygeek !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509929#comment-17509929
]
Christine Poerschke commented on LUCENE-10477:
--
https://github.com/apache/
Tomoko Uchida created LUCENE-10478:
--
Summary: Mark Test4GBStoredFields as @Monster (it consumes a lot
of disk)
Key: LUCENE-10478
URL: https://issues.apache.org/jira/browse/LUCENE-10478
Project: Lucen
[
https://issues.apache.org/jira/browse/LUCENE-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509942#comment-17509942
]
Adrien Grand commented on LUCENE-10478:
---
+1 Using that much disk space definitely
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r831225341
##
File path: lucene/CHANGES.txt
##
@@ -56,7 +56,7 @@ API Changes
New Features
-
-(No changes)
+* LUCENE-10422: Monitor Improvemen
mocobeta opened a new pull request #757:
URL: https://github.com/apache/lucene/pull/757
Excludes `Test4GBStoredFields` from nightly tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/LUCENE-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509949#comment-17509949
]
Uwe Schindler commented on LUCENE-10478:
+1, test is also taking very long.
>
mocobeta commented on pull request #757:
URL: https://github.com/apache/lucene/pull/757#issuecomment-1074038814
It seems the commit message accidentally mentions an unrelated github
account - I'm sorry for the noise.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/LUCENE-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509954#comment-17509954
]
Tomoko Uchida commented on LUCENE-10478:
I opened #757, the link to it has appe
mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1074048328
Ok!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
jpountz commented on a change in pull request #757:
URL: https://github.com/apache/lucene/pull/757#discussion_r831260485
##
File path: lucene/core/src/test/org/apache/lucene/index/Test4GBStoredFields.java
##
@@ -26,13 +26,15 @@
import org.apache.lucene.tests.codecs.compressing
msokolov commented on pull request #738:
URL: https://github.com/apache/lucene/pull/738#issuecomment-1074085956
Yes, let's add a CHANGES entry and tag it as 9.2.0 since we'll want to
backport it
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
msokolov commented on pull request #752:
URL: https://github.com/apache/lucene/pull/752#issuecomment-1074111548
If we can find a clean way to detect imminent stack overflow and throw an
exc, that would be great. Maybe a member variable on RegExp would be less
intrusive than adding paramete
romseygeek merged pull request #679:
URL: https://github.com/apache/lucene/pull/679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510003#comment-17510003
]
ASF subversion and git services commented on LUCENE-10422:
--
Co
nknize commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r831316035
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQueryByType.java
##
@@ -0,0 +1,126 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/LUCENE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510009#comment-17510009
]
ASF subversion and git services commented on LUCENE-10422:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward resolved LUCENE-10422.
Fix Version/s: 9.2
Resolution: Fixed
> Monitor instantiation configurabilty improv
reta commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r831340155
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQueryByType.java
##
@@ -0,0 +1,126 @@
+/*
+ * Li
gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831477355
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -414,4 +505,101 @@ public int compare(FacetR
anshumg commented on pull request #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1074345569
Thanks for your suggestion @uschindler. I like your suggestion but can't
think of a clean way to make this work for multiple internal releases. I'm
trying to avoid forking
gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831491304
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -190,20 +254,33 @@ private FacetResult getPa
Mike Drob created LUCENE-10479:
--
Summary: Benchmark documentation referes to non-existent tasks
Key: LUCENE-10479
URL: https://issues.apache.org/jira/browse/LUCENE-10479
Project: Lucene - Core
I
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831558514
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -178,10 +229,23 @@ private FacetResult getPath
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831558514
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -178,10 +229,23 @@ private FacetResult getPath
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831558514
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -178,10 +229,23 @@ private FacetResult getPath
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831558514
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -178,10 +229,23 @@ private FacetResult getPath
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r831568451
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java
##
@@ -414,4 +505,101 @@ public int compare(FacetRes
57 matches
Mail list logo
