mocobeta commented on pull request #755:
URL: https://github.com/apache/lucene/pull/755#issuecomment-1073827624
Thanks for your feedback and suggestions.
I reverted the command line to keep it as is.
The option could still be useful for some situations, I added a description
of it in the notice below the command. Does it make sense?
> I'd rather turn Test4GBStoredFields into a @ Monster test?
Maybe an issue is needed to change the test, I will open it.
> Perhaps we could have an env var LUCENE_SMOKE_TESTER_TMP_DIR that the
smoke tester would respect, then devs can set that once and be happy?
It would be possible to make the smoke tester respect an env var if it is
set as the default, and people will have options to change the location (an env
var or explicit `--tmp-dir` option; the latter overwrite the env var). I think
this change can be done in this PR rather than opening additional one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
