jpountz commented on a change in pull request #737: URL: https://github.com/apache/lucene/pull/737#discussion_r831152924
########## File path: lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java ########## @@ -309,11 +309,12 @@ protected void extractWeightedSpanTerms( final IndexSearcher searcher = new IndexSearcher(getLeafContext()); searcher.setQueryCache(null); if (mustRewriteQuery) { + final SpanQuery rewrittenQuery = + (SpanQuery) IndexSearcher.rewrite(spanQuery, getLeafContext().reader()); Review comment: or maybe we could do `new IndexSearcher(getLeafContext()).rewrite(spanQuery)` so that we wouldn't have to add a new API to IndexSearcher? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org