[
https://issues.apache.org/jira/browse/LUCENE-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485692#comment-17485692
]
Chris Hegarty commented on LUCENE-10304:
Linking an IDEA issue here since it ha
[
https://issues.apache.org/jira/browse/LUCENE-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485711#comment-17485711
]
Dawid Weiss commented on LUCENE-10304:
--
Thanks for the link, [~ChrisHegarty]
> M
mocobeta opened a new pull request #638:
URL: https://github.com/apache/lucene/pull/638
See https://issues.apache.org/jira/browse/LUCENE-10393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/LUCENE-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485725#comment-17485725
]
Tomoko Uchida commented on LUCENE-10393:
A top-down approach for unifying or re
mocobeta commented on pull request #638:
URL: https://github.com/apache/lucene/pull/638#issuecomment-1027850413
The test fails since this wouldn't work on module mode (the resource loader
attempts to read resources in another module). I'll look at it later.
--
This is an automated messag
javanna opened a new pull request #639:
URL: https://github.com/apache/lucene/pull/639
This is another one of many steps towards resolution of LUCENE-10002. In
this PR I am replacing some usages of SimpleCollector extension in tests with a
corresponding CollectorManager. In a few cases the
javanna commented on a change in pull request #639:
URL: https://github.com/apache/lucene/pull/639#discussion_r797656068
##
File path: lucene/core/src/test/org/apache/lucene/index/TestOmitTf.java
##
@@ -219,160 +221,101 @@ public void testBasic() throws Exception {
searc
javanna commented on a change in pull request #639:
URL: https://github.com/apache/lucene/pull/639#discussion_r797657558
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestBooleanQueryVisitSubscorers.java
##
@@ -70,10 +72,7 @@ public void setUp() throws Exception
javanna commented on a change in pull request #639:
URL: https://github.com/apache/lucene/pull/639#discussion_r797657558
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestBooleanQueryVisitSubscorers.java
##
@@ -70,10 +72,7 @@ public void setUp() throws Exception
javanna commented on a change in pull request #639:
URL: https://github.com/apache/lucene/pull/639#discussion_r797660275
##
File path: lucene/core/src/test/org/apache/lucene/search/TestBooleanQuery.java
##
@@ -492,33 +493,43 @@ private void assertSameScoresWithoutFilters(IndexS
[
https://issues.apache.org/jira/browse/LUCENE-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485861#comment-17485861
]
Luca Cavanna commented on LUCENE-7282:
--
I would like to work on this. I was wonderi
[
https://issues.apache.org/jira/browse/LUCENE-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485875#comment-17485875
]
Adrien Grand commented on LUCENE-7282:
--
I would extend the existing TermQuery.
> s
madrob merged pull request #637:
URL: https://github.com/apache/lucene/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
dweiss commented on pull request #634:
URL: https://github.com/apache/lucene/pull/634#issuecomment-1028125846
> Specifying this intent (e.g. syntax) is a necessary prerequisite to doing
this optimization for SHOULD clauses!
I agree with you but I can't convince myself to add yet anot
dweiss commented on pull request #634:
URL: https://github.com/apache/lucene/pull/634#issuecomment-1028126879
(There are a few unrelated commits that I'll cherry pick to the main
branch, disregard these, please).
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LUCENE-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485948#comment-17485948
]
ASF subversion and git services commented on LUCENE-10283:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485947#comment-17485947
]
ASF subversion and git services commented on LUCENE-10283:
--
Co
jpountz commented on a change in pull request #639:
URL: https://github.com/apache/lucene/pull/639#discussion_r797855989
##
File path: lucene/core/src/test/org/apache/lucene/search/TestBooleanQuery.java
##
@@ -492,33 +493,43 @@ private void assertSameScoresWithoutFilters(IndexS
jpountz commented on a change in pull request #635:
URL: https://github.com/apache/lucene/pull/635#discussion_r797860208
##
File path: lucene/CHANGES.txt
##
@@ -128,6 +128,9 @@ New Features
based on TotalHitCountCollector that allows users to parallelize counting the
numb
mayya-sharipova merged pull request #636:
URL: https://github.com/apache/lucene/pull/636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
mayya-sharipova commented on pull request #636:
URL: https://github.com/apache/lucene/pull/636#issuecomment-1028281557
Thanks @jpountz for the review.
> I assume you're going to add these indices to the main branch then and
change the version from 10 to 9?
Yes, that's the pl
[
https://issues.apache.org/jira/browse/LUCENE-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486050#comment-17486050
]
ASF subversion and git services commented on LUCENE-9573:
-
Commi
gsmiller commented on a change in pull request #632:
URL: https://github.com/apache/lucene/pull/632#discussion_r797965578
##
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##
@@ -192,7 +192,11 @@ protected Facets buildFacetsResult(
* ExecutorSer
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani reassigned LUCENE-10391:
-
Assignee: Julie Tibshirani
> Reuse data structures across HnswGraph invocation
dnhatn opened a new pull request #640:
URL: https://github.com/apache/lucene/pull/640
`DocumentWriter#anyChanges()` can return false after we process and
generate a sequence number for an update operation; but before we adjust
the `numDocsInRAM`. In this window of time, refreshes are n
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486212#comment-17486212
]
Nhat Nguyen commented on LUCENE-10190:
--
I've opened a fix in
[https://github.com/
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nhat Nguyen updated LUCENE-10190:
-
Status: Patch Available (was: Open)
> Assertion error in TestIndexWriter.testMaxCompletedSeque
mocobeta commented on pull request #638:
URL: https://github.com/apache/lucene/pull/638#issuecomment-1028598383
I opened `o.a.l.a.ja.dict` and `o.a.l.a.ko.dict` to `analysis-common` module
to allow `DictionaryResourceLoader` (common utility) to read dictionary
resources in kuromoji and nor
mocobeta edited a comment on pull request #638:
URL: https://github.com/apache/lucene/pull/638#issuecomment-1028598383
I opened `o.a.l.a.ja.dict` and `o.a.l.a.ko.dict` to `analysis-common` module
to allow `DictionaryResourceLoader` (common utility) to read dictionary
resources in kuromoji
[
https://issues.apache.org/jira/browse/LUCENE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486213#comment-17486213
]
Nhat Nguyen commented on LUCENE-10392:
--
+1. That'd be great. We can avoid writing
[
https://issues.apache.org/jira/browse/LUCENE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486220#comment-17486220
]
Nhat Nguyen commented on LUCENE-10392:
--
Soft-deletes can index already-deleted doc
[
https://issues.apache.org/jira/browse/LUCENE-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486220#comment-17486220
]
Nhat Nguyen edited comment on LUCENE-10392 at 2/3/22, 5:07 AM:
--
jtibshirani opened a new pull request #641:
URL: https://github.com/apache/lucene/pull/641
A couple of the data structures used in HNSW search are pretty large and
expensive to allocate. This commit creates a shared candidates queue and
visited
set that are reused across calls to Hnsw
jtibshirani commented on pull request #641:
URL: https://github.com/apache/lucene/pull/641#issuecomment-1028617830
This PR contains two changes:
* Reuse `visited` bit set across calls. For graph construction, switch to
`FixedBitSet` instead of `SparseBitSet`.
* Reuse `candidates` queu
jtibshirani commented on a change in pull request #641:
URL: https://github.com/apache/lucene/pull/641#discussion_r798223589
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -93,6 +94,29 @@
}
}
+ /**
+ * Holds data structures that
[
https://issues.apache.org/jira/browse/LUCENE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486256#comment-17486256
]
Dawid Weiss commented on LUCENE-10190:
--
Thanks [~dnhatn] !
> Assertion error in
36 matches
Mail list logo
