[
https://issues.apache.org/jira/browse/LUCENE-10393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485725#comment-17485725
]
Tomoko Uchida commented on LUCENE-10393:
----------------------------------------
A top-down approach for unifying or redesigning the dictionary classes in
kuromoji and nori is unlikely to work for me. They have a very similar
structure but there are also many language-specific differences between them.
Instead, a bottom-up refactoring could work - extract a small fraction of
duplicate code, then factor it out to a common base class or utility. For a
start, I tried to refactor the resource handling methods in BinaryDictionary.
https://github.com/apache/lucene/pull/638
> Should we unify the dictionary builder/loader of kuromoji and nori?
> -------------------------------------------------------------------
>
> Key: LUCENE-10393
> URL: https://issues.apache.org/jira/browse/LUCENE-10393
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A spin-off from LUCENE-8816.
> Kuromoji and Nori have many duplicated code in their dictionary
> builder/loader and we occasionally have to maintain both of them; I'd like to
> explore the possibility of their unification at some level.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
