javanna commented on a change in pull request #639:
URL: https://github.com/apache/lucene/pull/639#discussion_r797657558
##########
File path:
lucene/core/src/test/org/apache/lucene/search/TestBooleanQueryVisitSubscorers.java
##########
@@ -70,10 +72,7 @@ public void setUp() throws Exception {
"nutch is an internet search engine with web crawler and is using
lucene and hadoop"));
reader = writer.getReader();
writer.close();
- // we do not use newSearcher because the assertingXXX layers break
- // the toString representations we are relying on
- // TODO: clean that up
- searcher = new IndexSearcher(reader);
+ searcher = newSearcher(reader, true, false);
searcher.setSimilarity(new ClassicSimilarity());
scorerSearcher = new ScorerIndexSearcher(reader);
Review comment:
I did not find an easy way to wrap this so that the random aspects of
calling newSearcher are applied to it as well. Not sure if I missed something
and whether it even makes sense to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
