dweiss commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771190744
##
File path: lucene/expressions/src/java/module-info.java
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771271952
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -72,22 +83,41 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771278177
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -72,22 +83,41 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771278605
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -72,22 +83,41 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771287045
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771288196
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -72,22 +83,41 @@ allprojects {
args += [ "-enableJavadoc" ]
args += [ "-properties
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771288585
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771287045
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771291012
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367
]
Feng Guo commented on LUCENE-10319:
---
Out of curiosity, I tried to run the luceneutil
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771287455
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367
]
Feng Guo edited comment on LUCENE-10319 at 12/17/21, 10:49 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367
]
Feng Guo edited comment on LUCENE-10319 at 12/17/21, 10:50 AM:
--
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771314916
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
uschindler commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771319925
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
romseygeek commented on pull request #543:
URL: https://github.com/apache/lucene/pull/543#issuecomment-996645449
I know I originally suggested on the list that we could add the new
abstractions to core, but I'm now wondering if it makes more sense to keep them
in the facets module, given t
dweiss commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771349651
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
dweiss commented on a change in pull request #533:
URL: https://github.com/apache/lucene/pull/533#discussion_r771349651
##
File path: gradle/validation/ecj-lint.gradle
##
@@ -60,6 +61,16 @@ allprojects {
def tmpDst = getTemporaryDir()
workingDir tmpDst
+
dweiss commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996678557
> showServiceProviders in modules-debbuging.gradle is not available by
default, how can one use it?
Include it in the main file or module.gradle. I think it'll be useful in
v
[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367
]
Feng Guo edited comment on LUCENE-10319 at 12/17/21, 12:16 PM:
--
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996696683
I also did some checks with Eclipse. Project opens and you can edit source
code. Of course module-tests (e.g. distribution) won't run.
--
This is an automated message from the
gsmiller merged pull request #547:
URL: https://github.com/apache/lucene/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461444#comment-17461444
]
ASF subversion and git services commented on LUCENE-10321:
--
Co
gsmiller opened a new pull request #548:
URL: https://github.com/apache/lucene/pull/548
Simple backport. Using PR as a preferred mechanism to merge. No review
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mocobeta commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996742260
Luke launch scripts still have `--add-modules jdk.unsupported ` option. I
think this can be removed.
https://github.com/dweiss/lucene/blob/db9dff225ce389eaec8341346a0e32e3cc8a
mocobeta edited a comment on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996742260
Luke launch scripts still have `--add-modules jdk.unsupported ` option. I
think this can be removed. (I confirmed that MMapDirectory is enabled without
this option.)
ht
[
https://issues.apache.org/jira/browse/LUCENE-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461367#comment-17461367
]
Feng Guo edited comment on LUCENE-10319 at 12/17/21, 2:08 PM:
---
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996751150
> Luke launch scripts still have `--add-modules jdk.unsupported ` option. I
think this can be removed. (I confirmed that MMapDirectory is enabled without
this option.)
https://
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996758554
When building a release it fails for some reason (not sure why) on luke's:
```
Execution failed for task ':lucene:luke:renderJavadoc'.
C:\Users\Uwe
Schindler\Projects\lu
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996763757
> When building a release it fails for some reason (not sure why) on luke's:
>
> ```
> Execution failed for task ':lucene:luke:renderJavadoc'.
> C:\Users\Uwe
Schindl
[
https://issues.apache.org/jira/browse/LUCENE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461488#comment-17461488
]
ASF subversion and git services commented on LUCENE-10321:
--
Co
gsmiller merged pull request #548:
URL: https://github.com/apache/lucene/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461493#comment-17461493
]
Greg Miller commented on LUCENE-10321:
--
Thanks [~ivera] for the review and suggest
[
https://issues.apache.org/jira/browse/LUCENE-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10321.
--
Fix Version/s: 9.1
Resolution: Fixed
> MultiRangeQuery doesn't need to "pull up" mins
Greg Miller created LUCENE-10325:
Summary: Add getTopDims functionality to Facets
Key: LUCENE-10325
URL: https://issues.apache.org/jira/browse/LUCENE-10325
Project: Lucene - Core
Issue Type:
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996796429
I built a release and started `./bin/luke.cmd`. I then opened an too old
index and it printed a stack trace to log with MMapDirectory, so unsupported
module was correctly added
uschindler edited a comment on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996763757
> When building a release it fails for some reason (not sure why) on luke's:
>
> ```
> Execution failed for task ':lucene:luke:renderJavadoc'.
> C:\Users\Uwe
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996800209
I think for the luke, we should make "check" depend on "renderJavadocs"
(only for that case, because we don't generate site javadocs), otherwise the
javadocs are never checked.
dweiss commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996843339
You're right. If something is not part of site, check should render its
javadocs. Perhaps you can file a separate PR for this, referencing original
issue number?
--
This is an au
dweiss commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996843850
I'll take one final look and will commit it in during the weekend. Thanks a
lot for collaboration.
--
This is an automated message from the Apache Git Service.
To respond to the m
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996863454
> You're right. If something is not part of site, check should render its
javadocs. Perhaps you can file a separate PR for this, referencing original
issue number?
will d
dweiss commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996865955
or leave javadocs to me and fix that apache jenkins worker server, if you
know how. :) Is there an ssh to those machines or should infra be involved?
--
This is an automated messa
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996867868
> or leave javadocs to me and fix that apache jenkins worker server, if you
know how. :) Is there an ssh to those machines or should infra be involved?
That's infra's task
uschindler commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996868909
> > or leave javadocs to me and fix that apache jenkins worker server, if
you know how. :) Is there an ssh to those machines or should infra be involved?
>
> That's infra'
dweiss commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-996873244
I'll commit the javadoc fix here - you're right, it belongs here better as
the javadoc rendering is slightly different.
--
This is an automated message from the Apache Git Service
Dawid Weiss created LUCENE-10326:
Summary: Render javadocs of modules as proper modules
Key: LUCENE-10326
URL: https://issues.apache.org/jira/browse/LUCENE-10326
Project: Lucene - Core
Issue
dweiss commented on pull request #549:
URL: https://github.com/apache/lucene/pull/549#issuecomment-996895621
@rmuir Can you try on your machine? I've ran
```gradlew regenerate --rerun-tasks```
on a linux box but I suspect the graph ordering may depend on the number of
cores, wind pa
rmuir commented on pull request #549:
URL: https://github.com/apache/lucene/pull/549#issuecomment-996900058
@dweiss running now. I'll run regenerate twice and see if i encounter
similar behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rmuir commented on pull request #549:
URL: https://github.com/apache/lucene/pull/549#issuecomment-996902447
I can already see the difference in execution order. in the main branch i
was able to trivially reproduce the problem. with this patch it runs the TLD
stuff first:
```
> Ta
dweiss commented on pull request #549:
URL: https://github.com/apache/lucene/pull/549#issuecomment-996905767
I do believe it should be all right, although there may be other quirks
lurking in there. The thing is: when you have this task graph:
A.dependsOn B
C.dependsOn D
th
dweiss merged pull request #549:
URL: https://github.com/apache/lucene/pull/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10285:
-
Fix Version/s: 9.1
(was: 10.0 (main))
> gradle regenerate TLDs file / to
[
https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10285.
--
Fix Version/s: 10.0 (main)
Resolution: Fixed
> gradle regenerate TLDs file / tokenizer
[
https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461601#comment-17461601
]
ASF subversion and git services commented on LUCENE-10285:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461603#comment-17461603
]
ASF subversion and git services commented on LUCENE-10285:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461604#comment-17461604
]
Robert Muir commented on LUCENE-10285:
--
Thanks [~dweiss]. Effectively doubles the
thelabdude commented on pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-997095585
@broberson721 ~ I'm doing the work for this issue here:
https://github.com/apache/solr/pull/460 ... if you want to follow along. Thanks
again for reporting, obviously I h
mocobeta commented on pull request #533:
URL: https://github.com/apache/lucene/pull/533#issuecomment-997141676
I did some sanity checks on this branch. Looks everything is fine.
https://gist.github.com/mocobeta/387585d846714aab86205ab92bc0beba
--
This is an automated message from the A
mayya-sharipova commented on pull request #416:
URL: https://github.com/apache/lucene/pull/416#issuecomment-997145470
@jtibshirani Thanks for continuing your review.
My main questions to @jpountz and @msokolov is indeed about file formats.
Is it better to keep the current desig
59 matches
Mail list logo
