uschindler commented on pull request #533: URL: https://github.com/apache/lucene/pull/533#issuecomment-996751150
> Luke launch scripts still have `--add-modules jdk.unsupported ` option. I think this can be removed. (I confirmed that MMapDirectory is enabled without this option.) https://github.com/dweiss/lucene/blob/db9dff225ce389eaec8341346a0e32e3cc8aa06d/lucene/distribution/src/binary-release/bin/luke.sh#L20 https://github.com/dweiss/lucene/blob/db9dff225ce389eaec8341346a0e32e3cc8aa06d/lucene/distribution/src/binary-release/bin/luke.cmd#L20 Yes it is obsolete. I tested the command line as printed b gradle and this worked. We need to pass no modules at all because it knows dependencies. (Although I never understood the transitive stuff). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
