iverase merged pull request #478:
URL: https://github.com/apache/lucene/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450249#comment-17450249
]
ASF subversion and git services commented on LUCENE-9820:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450248#comment-17450248
]
ASF subversion and git services commented on LUCENE-10264:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450251#comment-17450251
]
ASF subversion and git services commented on LUCENE-9820:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450250#comment-17450250
]
ASF subversion and git services commented on LUCENE-10264:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450257#comment-17450257
]
Jerome Prinet commented on LUCENE-10267:
Hi David and thanks for raising that!
[
https://issues.apache.org/jira/browse/LUCENE-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450258#comment-17450258
]
Dawid Weiss commented on LUCENE-10267:
--
Thanks [~JeromeP]!
> Gradle does not writ
[
https://issues.apache.org/jira/browse/LUCENE-10264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10264.
---
Assignee: Ignacio Vera
Resolution: Fixed
I haven't added an entry in CHANGES.txt as i
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450277#comment-17450277
]
Ignacio Vera commented on LUCENE-9619:
--
In LUCENE-9820 we have done the first step
Ignacio Vera created LUCENE-10269:
-
Summary: Add the ability to read KD trees from right to left
Key: LUCENE-10269
URL: https://issues.apache.org/jira/browse/LUCENE-10269
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450296#comment-17450296
]
Ignacio Vera commented on LUCENE-10266:
---
+1
> Move nearest-neighbor search on po
rmuir opened a new pull request #485:
URL: https://github.com/apache/lucene/pull/485
Instead, require that incoming automata is determinized by the caller,
throwing an exception if it isn't.
This paves the way for NFA execution in the future: if you pass an NFA to
AutomatonQuery, we
rmuir commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-981447584
I made a quick prototype with what i mean for the API:
https://github.com/apache/lucene/pull/485
The idea is that AutomatonQuery shouldn't be determinizing. Let's push this
to
iverase merged pull request #428:
URL: https://github.com/apache/lucene/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450310#comment-17450310
]
ASF subversion and git services commented on LUCENE-9538:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450311#comment-17450311
]
ASF subversion and git services commented on LUCENE-9538:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9538.
--
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> Tessellator shou
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450327#comment-17450327
]
Uwe Schindler commented on LUCENE-10255:
Hi,
I would like to bring in one more
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450359#comment-17450359
]
Dawid Weiss commented on LUCENE-10255:
--
I did that intentionally. I hate those lon
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450361#comment-17450361
]
Dawid Weiss commented on LUCENE-10255:
--
Think this way: java's internal modules do
[
https://issues.apache.org/jira/browse/LUCENE-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450365#comment-17450365
]
Dawid Weiss commented on LUCENE-10267:
--
I see this is a known issue - it was marke
romseygeek commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981531806
Have updated; the test is now docCount == maxDoc, which works even in the
case that we have deleted docs.
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/LUCENE-10267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450447#comment-17450447
]
Jerome Prinet commented on LUCENE-10267:
Yes, it was already raised but not sco
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450472#comment-17450472
]
Uwe Schindler commented on LUCENE-10255:
bq. java -m org.apache.lucene.core sou
xaviersanchez commented on pull request #461:
URL: https://github.com/apache/lucene/pull/461#issuecomment-981735988
> Hi @xaviersanchez, this contribution looks great.
>
> I'll do another pass on review and give some time for others to review as
well.
>
> I did a little invest
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981738439
Let's fix the CHANGES now that it works with deleted documents.
I'm sad the optimization couldnt work because of a crazy corner case: which
begs the question, why does the user
romseygeek commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981755138
For a `TokensExistsQuery`, is the idea that the query part would work the
same as norms, we just filter out docs with a norm of 0?
--
This is an automated message from the Apa
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981761039
> For a `TokensExistsQuery`, is the idea that the query part would work the
same as norms, we just filter out docs with a norm of 0?
yeah, at first at least. sounds like we nee
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981765930
personally, i really feel if someone wants "empty string" to be considered
"indexed" for cases like this, they should use KeywordTokenizer/StringField,
and actually index that empty
iverase opened a new pull request #486:
URL: https://github.com/apache/lucene/pull/486
Introduces two functional interfaces, `DocValuesVisitor` and `DocIdsVisitor`
that are used in the PointTree API instead of using the IntersectVisitor. The
IntersectVisitor is now extending those interfac
iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r758504244
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -323,10 +355,18 @@ default void grow(int count) {}
*/
public final v
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450554#comment-17450554
]
Dawid Weiss commented on LUCENE-10255:
--
Sorry but I remain unconvinced that typing
romseygeek commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981775748
One disadvantage of renaming it is that it really does require norms to
work; it might be a bit surprising to have a 'TokensExistsQuery' that you run
against a field with norms
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981811821
> One disadvantage of renaming it is that it really does require norms to
work; it might be a bit surprising to have a 'TokensExistsQuery' that you run
against a field with norms dis
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450583#comment-17450583
]
Uwe Schindler commented on LUCENE-10255:
Hi,
please have an overview on Maven c
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450589#comment-17450589
]
Dawid Weiss commented on LUCENE-10255:
--
You don't understand me, Uwe. I agree on m
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450583#comment-17450583
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 4:50 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450583#comment-17450583
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 4:59 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450597#comment-17450597
]
Uwe Schindler commented on LUCENE-10255:
We can disagree, for sure, but I'd lik
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450604#comment-17450604
]
Dawid Weiss commented on LUCENE-10255:
--
Sure, Uwe. I think I expressed my personal
rmuir commented on pull request #477:
URL: https://github.com/apache/lucene/pull/477#issuecomment-981837493
and btw i'm not suggesting we do all this crap underneath this PR, the
current PR looks fine to me (the optimization it uses is safe)
--
This is an automated message from the Apach
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450607#comment-17450607
]
Uwe Schindler commented on LUCENE-10255:
>From the list posted before there is
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450607#comment-17450607
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 5:14 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450613#comment-17450613
]
Dawid Weiss commented on LUCENE-10255:
--
Mistakes of the youth... I remain unconvin
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450620#comment-17450620
]
Uwe Schindler commented on LUCENE-10255:
Apache TIKA also uses module names acc
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450620#comment-17450620
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 5:41 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450624#comment-17450624
]
Dawid Weiss commented on LUCENE-10255:
--
Uwe... This was done with an announcement
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450625#comment-17450625
]
Uwe Schindler commented on LUCENE-10255:
bq. I just figured out that you alread
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450627#comment-17450627
]
Uwe Schindler commented on LUCENE-10255:
bq. This was done with an announcement
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450628#comment-17450628
]
Dawid Weiss commented on LUCENE-10255:
--
https://issues.apache.org/jira/browse/LUCE
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450630#comment-17450630
]
Robert Muir commented on LUCENE-10255:
--
{quote}
Sorry but I remain unconvinced tha
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reopened LUCENE-10234:
--
Uwe seems to be really devoted to changing the automatic module name to
full-prefix convention,
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450635#comment-17450635
]
Dawid Weiss commented on LUCENE-10255:
--
I already typed "-m lucene.luke" what seem
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450639#comment-17450639
]
Robert Muir commented on LUCENE-10255:
--
my comment was a genuine question, as I do
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450647#comment-17450647
]
Dawid Weiss commented on LUCENE-10255:
--
It'll be a different prefix in module-info
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450647#comment-17450647
]
Dawid Weiss edited comment on LUCENE-10255 at 11/29/21, 6:15 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10234:
-
Description: This is the first step to make Lucene a proper fit for the
java module system. -I
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758637522
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450680#comment-17450680
]
Uwe Schindler commented on LUCENE-10255:
bq. Sorry for the silly question, but
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450680#comment-17450680
]
Uwe Schindler edited comment on LUCENE-10255 at 11/29/21, 7:02 PM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450690#comment-17450690
]
Dawid Weiss commented on LUCENE-10255:
--
I accept your arguments, even if I disagre
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758670507
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
jtibshirani commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r758678766
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -56,31 +59,50 @@
public final class HnswGraph extends KnnGraphValues
madrob merged pull request #2615:
URL: https://github.com/apache/lucene-solr/pull/2615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758689212
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758691210
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758697734
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758700461
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450707#comment-17450707
]
Christian Stein commented on LUCENE-10255:
--
FWIW, I agree with Uwe on the nami
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758715684
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758715684
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758717236
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758718326
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758721225
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758723885
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758723981
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758728664
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758729874
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758732884
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758733113
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
rmuir commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758737615
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758742625
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758744591
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.versi
dweiss commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758746111
##
File path: gradle/java/jar-manifest.gradle
##
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']
rmuir opened a new pull request #488:
URL: https://github.com/apache/lucene/pull/488
Move this to the very top of MIGRATE, the user needs to first be able to
pull in the artifacts, before doing anything else like trying to compile, deal
with renamed classes, etc.
Add a table of each
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982046022
A separate note: The new name is also more conforming what the modules relay
do: They are not only "analyzers", those are compoents for "analysis" of text
while indexing/searchi
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982048976
Table looks much better now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on pull request #487:
URL: https://github.com/apache/lucene/pull/487#issuecomment-982055622
I added a change to the CHANGES.txt file to explain that the automatic
module names are a preparation for full module system support. This should be
added, because we have not
rmuir commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982055841
Sorry for all the commits, I wanted to try to make this easy to read and
prominent, and linked from the README too for more visibility.
I realize the `MIGRATE.md` is an unstru
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982058390
Originally I made the MIGRATE.md a markdown file to have all formatting
possibilities. The unordered list was just a "quick conversion" from the old
format introduced in Lucene
rmuir commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982061761
> A separate note: The new name is also more conforming what the modules
relay do: They are not only "analyzers", those are compoents for "analysis" of
text while indexing/searching
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982064591
This was just meant as a replacement for this text: "and are now consistent
with repository module 'analysis'". This does not sound like a acceptable
explanation to an annoyed u
rmuir merged pull request #488:
URL: https://github.com/apache/lucene/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
uschindler commented on pull request #488:
URL: https://github.com/apache/lucene/pull/488#issuecomment-982072123
Hi Robert,
I built the documentation with "gradlew documentation" and noticed that
tables were not enabled in the markdown converter. It now looks not very well.
If you
rmuir opened a new pull request #489:
URL: https://github.com/apache/lucene/pull/489
https://github.com/apache/lucene/pull/488 added table of analyzer artifacts
changes.
Unfortunately it looks like crap in generated HTML unless we bring in the
tables extension.
Before:
uschindler commented on pull request #489:
URL: https://github.com/apache/lucene/pull/489#issuecomment-982080248
I created the same PR but did not yet commit it.
Looks identical here, I just reformatted the long line with the extensions.
+1 to commit.
--
This is an automated
uschindler commented on pull request #489:
URL: https://github.com/apache/lucene/pull/489#issuecomment-982083351
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
rmuir merged pull request #489:
URL: https://github.com/apache/lucene/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450762#comment-17450762
]
Uwe Schindler commented on LUCENE-10255:
Thanks [~sor] for confirmation.
We no
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-982125853
Thanks @rmuir, I'll run a benchmark to ensure this PR does not introduce
regression recently.
I like the approach you proposed in #485, it would be nice if we can get rid
of `
1 - 100 of 125 matches
Mail list logo
