jpountz commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751011311
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,42 @@ public void testFieldExistsButNoDocsH
zacharymorn commented on a change in pull request #418:
URL: https://github.com/apache/lucene/pull/418#discussion_r751018772
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java
##
@@ -441,6 +491,273 @@ public boolean isCacheable(LeafR
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445032#comment-17445032
]
Feng Guo commented on LUCENE-10233:
---
[~jpountz] Thanks for the guide! Actually, there
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445032#comment-17445032
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 9:25 AM:
---
sonatype-lift[bot] commented on a change in pull request #438:
URL: https://github.com/apache/lucene/pull/438#discussion_r751055798
##
File path: lucene/core/src/java/org/apache/lucene/util/SparseFixedBitSet.java
##
@@ -530,4 +530,33 @@ public long ramBytesUsed() {
public St
bruno-roustant merged pull request #430:
URL: https://github.com/apache/lucene/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
spyk commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r751061365
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static String ge
[
https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445043#comment-17445043
]
ASF subversion and git services commented on LUCENE-10225:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445045#comment-17445045
]
Bruno Roustant commented on LUCENE-10225:
-
I'm a bit confused. I put this chang
[
https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445047#comment-17445047
]
Adrien Grand commented on LUCENE-10225:
---
Targeting 9.1 with this change sounds go
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445032#comment-17445032
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 10:13 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445059#comment-17445059
]
Dawid Weiss commented on LUCENE-10238:
--
Ah, thanks! I've rebuilt on windows too (n
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751102338
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,42 @@ public void testFieldExistsButNoDocs
[
https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445097#comment-17445097
]
ASF subversion and git services commented on LUCENE-10225:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved LUCENE-10225.
-
Fix Version/s: 9.1
Resolution: Fixed
Thanks Dawid and Adrien!
> Improve IntroSe
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445032#comment-17445032
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 10:57 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445032#comment-17445032
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 11:00 AM:
--
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445121#comment-17445121
]
Dawid Weiss commented on LUCENE-10238:
--
I've removed those specialized icu_xyz ver
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445032#comment-17445032
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 12:37 PM:
--
jpountz commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751199436
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,50 @@ public void testFieldExistsButNoDocsH
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445143#comment-17445143
]
Feng Guo commented on LUCENE-10233:
---
[~jpountz] I execute a low cardinality terms que
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751226805
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,50 @@ public void testFieldExistsButNoDocs
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751228998
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,52 @@ public void testFieldExistsButNoDocs
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751234461
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,50 @@ public void testFieldExistsButNoDocs
rmuir commented on pull request #447:
URL: https://github.com/apache/lucene/pull/447#issuecomment-971582845
FYI I opened https://issues.apache.org/jira/browse/LUCENE-10239 as a
followup. I think with recent jflex we can actually remove our emoji
regeneration task completely
--
This is a
Robert Muir created LUCENE-10239:
Summary: upgrade jflex (1.7.0 -> 1.8.2)
Key: LUCENE-10239
URL: https://issues.apache.org/jira/browse/LUCENE-10239
Project: Lucene - Core
Issue Type: Task
jpountz commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751243685
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,52 @@ public void testFieldExistsButNoDocsH
[
https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445170#comment-17445170
]
Dawid Weiss commented on LUCENE-10239:
--
+1.
> upgrade jflex (1.7.0 -> 1.8.2)
> --
Robert Muir created LUCENE-10240:
Summary: gradle regenerate fails on java 17
Key: LUCENE-10240
URL: https://issues.apache.org/jira/browse/LUCENE-10240
Project: Lucene - Core
Issue Type: Task
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445189#comment-17445189
]
Robert Muir commented on LUCENE-10240:
--
Of course the task that fails is one I am
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445143#comment-17445143
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 2:08 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445194#comment-17445194
]
Robert Muir commented on LUCENE-10240:
--
This task passes with this patch:
{noforma
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445196#comment-17445196
]
Feng Guo commented on LUCENE-10233:
---
In addition, here are the commit hashes of the c
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445143#comment-17445143
]
Feng Guo edited comment on LUCENE-10233 at 11/17/21, 2:28 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445253#comment-17445253
]
Robert Muir commented on LUCENE-10240:
--
Bumping the groovy version fixes the issue
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10233:
--
Attachment: image-2021-11-17-22-43-13-693.png
> Store docIds as bitset when leafCardinality = 1 to sp
[ https://issues.apache.org/jira/browse/LUCENE-10233 ]
Feng Guo deleted comment on LUCENE-10233:
---
was (Author: gf2121):
This is the flame graph of keeping running this script, it seems a lot of time
took to new a SparseFixedBitSet, which allocate
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445262#comment-17445262
]
Feng Guo commented on LUCENE-10233:
---
This is the flame graph of keeping running this
hendrikmuhs commented on pull request #433:
URL: https://github.com/apache/lucene/pull/433#issuecomment-971656429
@dweiss
Thanks for the feedback. I agree about avoiding gradle magic. The module
suggestion is great and helped me finding a better solution for me (I want to
run thing
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss reassigned LUCENE-10240:
Assignee: Dawid Weiss
> gradle regenerate fails on java 17
> ---
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445265#comment-17445265
]
Dawid Weiss commented on LUCENE-10240:
--
Weird. I'll take a look.
> gradle regener
codaitya commented on pull request #446:
URL: https://github.com/apache/lucene/pull/446#issuecomment-971673541
> Let's rename to `MergeOnFlushTieredMergePolicy` since it technically
merges on flushes, not commits?
>
> I haven't taken a deep look at the code, but is it specific to
`T
gsmiller commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r751338671
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java
##
@@ -41,12 +40,7 @@ public DocValuesOrdinalsReader(Stri
gsmiller commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r751339846
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +84,19 @@ public long cost() {
}
};
}
+
+ /**
+ *
gsmiller commented on pull request #264:
URL: https://github.com/apache/lucene/pull/264#issuecomment-971678277
I've removed all back-compat support now from this PR since we're trying to
include this change in 9.0 (see #443). So this PR now reflects my proposed
end-state in main. I still s
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445286#comment-17445286
]
Dawid Weiss commented on LUCENE-10240:
--
That external groovy dependency can be upd
mikemccand commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r751348311
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void initParents
Jeff Zemerick created LUCENE-10241:
--
Summary: Update OpenNLP to 1.9.4
Key: LUCENE-10241
URL: https://issues.apache.org/jira/browse/LUCENE-10241
Project: Lucene - Core
Issue Type: Task
mikemccand commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r751350351
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,40 +125,82 @@ private void initParents
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445292#comment-17445292
]
Dawid Weiss commented on LUCENE-10240:
--
Seems like this is the problem:
https://is
dweiss commented on pull request #433:
URL: https://github.com/apache/lucene/pull/433#issuecomment-971689826
I think some of these "demo" classes come from different modules - this is
legacy and highly unstructured... But feel free to provide a patch, sure. I was
thinking about it myself.
dweiss commented on pull request #447:
URL: https://github.com/apache/lucene/pull/447#issuecomment-971690639
Darn. Thanks for fixing changes.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751006192
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/BackCompatSortedNumericDocValues.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apac
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751361476
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +82,17 @@ public long cost() {
}
};
}
+
+ /**
+ * D
gsmiller commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r751355800
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java
##
@@ -130,15 +125,49 @@ private void initParents(I
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751365695
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java
##
@@ -41,13 +48,21 @@ public DocValuesOrdinalsReader(Str
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445303#comment-17445303
]
Robert Muir commented on LUCENE-10240:
--
Thanks for tracking down the groovy bug.
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751370043
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/BackCompatSortedNumericDocValues.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445309#comment-17445309
]
Dawid Weiss commented on LUCENE-10240:
--
Absolutely. This seems unrelated.
> gradl
magibney commented on a change in pull request #380:
URL: https://github.com/apache/lucene/pull/380#discussion_r751397674
##
File path:
lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/tools/OpenNLPOpsFactory.java
##
@@ -169,11 +169,14 @@ public static Strin
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-10233:
--
Attachment: (was: image-2021-11-17-22-43-13-693.png)
> Store docIds as bitset when leafCardinalit
jzonthemtn opened a new pull request #448:
URL: https://github.com/apache/lucene/pull/448
# Description
Updating OpenNLP dependency to 1.9.4.
# Solution
Updated OpenNLP dependency version.
# Tests
Tests passed.
# Checklist
Please r
mikemccand commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751373424
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue()
[
https://issues.apache.org/jira/browse/LUCENE-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445336#comment-17445336
]
Jeff Zemerick commented on LUCENE-10241:
First time contributor to Lucene -- pl
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751413961
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +82,17 @@ public long cost() {
}
};
}
+
+ /**
+ * D
rmuir commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751435736
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexDrillDownT
rmuir commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751437818
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751451039
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexDrillDo
dweiss opened a new pull request #449:
URL: https://github.com/apache/lucene/pull/449
This should do the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751453417
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexDrillDo
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751453619
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/BackCompatSortedNumericDocValues.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apa
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751455429
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
dweiss merged pull request #447:
URL: https://github.com/apache/lucene/pull/447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445378#comment-17445378
]
ASF subversion and git services commented on LUCENE-10238:
--
Co
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751456634
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10238.
--
Fix Version/s: 9.1
Resolution: Fixed
> Update icu4j to 70.1
>
>
>
[
https://issues.apache.org/jira/browse/LUCENE-10238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445381#comment-17445381
]
ASF subversion and git services commented on LUCENE-10238:
--
Co
jtibshirani commented on a change in pull request #444:
URL: https://github.com/apache/lucene/pull/444#discussion_r751461104
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestCombinedFieldQuery.java
##
@@ -165,6 +169,117 @@ public void testSameScore()
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751462508
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751464048
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751465599
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java
##
@@ -62,7 +62,16 @@ public TaxonomyFacetLabels(TaxonomyRead
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751467194
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java
##
@@ -168,24 +234,61 @@ public FacetLabel nextFacetLabel(int
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751467541
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestBackCompatSortedNumericDocValues.java
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751468971
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java
##
@@ -138,4 +331,51 @@ private Path getInde
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751469402
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestBackwardsCompatibility.java
##
@@ -50,43 +74,192 @@
// Then move the
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751465599
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetLabels.java
##
@@ -62,7 +62,16 @@ public TaxonomyFacetLabels(TaxonomyRead
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751475270
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
dweiss commented on pull request #449:
URL: https://github.com/apache/lucene/pull/449#issuecomment-971804749
Yeah. I don't completely understand the cause either - I just thought not
forcing groovy to create an anonymous implementation of the interface passed to
andThen would dodge the pro
dweiss merged pull request #449:
URL: https://github.com/apache/lucene/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445402#comment-17445402
]
ASF subversion and git services commented on LUCENE-10240:
--
Co
gsmiller commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751476550
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +82,17 @@ public long cost() {
}
};
}
+
+ /**
+ *
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10240.
--
Fix Version/s: 9.1
Resolution: Fixed
> gradle regenerate fails on java 17
> --
[
https://issues.apache.org/jira/browse/LUCENE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445403#comment-17445403
]
ASF subversion and git services commented on LUCENE-10240:
--
Co
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751482085
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751483461
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##
@@ -69,31 +69,34 @@ public FastTaxonomyFacetCounts(
rmuir commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751504639
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/OrdinalMappingLeafReader.java
##
@@ -107,6 +113,64 @@ public BytesRef binaryValue() {
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r751544194
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java
##
@@ -92,15 +93,18 @@
private final Directory
zhaih commented on a change in pull request #442:
URL: https://github.com/apache/lucene/pull/442#discussion_r751545923
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java
##
@@ -466,18 +476,22 @@ protected final void ensu
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751606167
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,52 @@ public void testFieldExistsButNoDocs
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r751606710
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestDocValuesFieldExistsQuery.java
##
@@ -206,6 +210,50 @@ public void testFieldExistsButNoDocs
1 - 100 of 133 matches
Mail list logo
