gsmiller commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r751339846



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##########
@@ -81,4 +84,19 @@ public long cost() {
       }
     };
   }
+
+  /**
+   * Determine whether-or-not an index segment is using the older-style binary 
format or the newer
+   * NumericDocValues format for storing taxonomy faceting ordinals (for the 
specified field).
+   *
+   * @deprecated Please do not rely on this method. It is added as a temporary 
measure for providing
+   *     index backwards-compatibility with Lucene 9 and earlier indexes, and 
will be removed in
+   *     Lucene 11.
+   */
+  // TODO: Remove in Lucene 11
+  @Deprecated
+  public static boolean usesOlderBinaryOrdinals(LeafReader reader, String 
field) {

Review comment:
       Good point. Since I moved the back-compat support to #443 (against 9.0) 
I included this change over there. There's no more back-compat support needed 
here since this is against main. thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to