gsmiller commented on a change in pull request #264:
URL: https://github.com/apache/lucene/pull/264#discussion_r751338671
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/DocValuesOrdinalsReader.java
##########
@@ -41,12 +40,7 @@ public DocValuesOrdinalsReader(String field) {
@Override
public OrdinalsSegmentReader getReader(LeafReaderContext context) throws
IOException {
Review comment:
In the latest iteration I've removed `OrdinalsReader` (and support for
it) completely. I think this is a nice simplification and I can't think of any
real-world cases for supporting a custom `OrdinalsReader` when faceting after
we remove support for users bringing their own custom binary encoding. If we
come up with real cases for continuing to support this, it's easy enough to
bring back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
