jpountz commented on a change in pull request #443: URL: https://github.com/apache/lucene/pull/443#discussion_r751413961
########## File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java ########## @@ -81,4 +82,17 @@ public long cost() { } }; } + + /** + * Determine whether-or-not an index segment is using the older-style binary format or the newer + * NumericDocValues format for storing taxonomy faceting ordinals (for the specified field). + * + * @deprecated Please do not rely on this method. It is added as a temporary measure for providing + * index backwards-compatibility with Lucene 8 and earlier indexes, and will be removed in + * Lucene 10. + */ + @Deprecated + public static boolean usesOlderBinaryOrdinals(LeafReader reader) { + return reader.getMetaData().getCreatedVersionMajor() <= 8; Review comment: It refers to the whole index indeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org