[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429869#comment-17429869
]
Dawid Weiss commented on LUCENE-9997:
-
Filed a PR here:
https://github.com/apache/l
rmuir commented on a change in pull request #389:
URL: https://github.com/apache/lucene/pull/389#discussion_r730728533
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java
##
@@ -1402,15 +1403,23 @@ public int docID() {
@Ov
rmuir commented on pull request #389:
URL: https://github.com/apache/lucene/pull/389#issuecomment-945586019
Seems a lot easier to just test this via SORTED_NUMERIC. There isn't any
point in testing SORTED_SET as it only makes things more difficult.
The test should fail without the f
jpountz commented on a change in pull request #389:
URL: https://github.com/apache/lucene/pull/389#discussion_r730745755
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java
##
@@ -1402,15 +1403,23 @@ public int docID() {
@
jpountz commented on pull request #389:
URL: https://github.com/apache/lucene/pull/389#issuecomment-945593285
> Why do we have all this delegation?
It was a way to have sorted set doc values automatically benefit from the
specialization of sorted numeric doc values without duplicatin
janhoy commented on pull request #392:
URL: https://github.com/apache/lucene/pull/392#issuecomment-945617644
I run the build with this patch, but get errors
```
> Task :lucene:backward-codecs:javadocJar
Caching disabled for task ':lucene:backward-codecs:javadocJar' because:
Bui
janhoy commented on pull request #392:
URL: https://github.com/apache/lucene/pull/392#issuecomment-945628415
I made the build pass when trying the java-based signing (`-Psign
-Psigning.keyId="" -Psigning.password=$GPGPASS
-Psigning.secretKeyRingFile=$HOME/.gnupg/secring.gpg`), but
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429927#comment-17429927
]
Stefan Vodita commented on LUCENE-10182:
I pushed a change renaming {{RamUsageT
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429958#comment-17429958
]
Michael McCandless commented on LUCENE-10054:
-
[~mayya] this looks like an
jpountz commented on pull request #389:
URL: https://github.com/apache/lucene/pull/389#issuecomment-945690914
> As far as Asserting, maybe you misunderstand the issue
Sorry you are right indeed, AssertingDVFormat cannot help here.
--
This is an automated message from the Apache Git
dweiss commented on pull request #392:
URL: https://github.com/apache/lucene/pull/392#issuecomment-945778193
Eh. Ok, I'll take another look. It's all a bit of a black-box with those
plugins...
--
This is an automated message from the Apache Git Service.
To respond to the message, please
xiaoshi2013 commented on pull request #301:
URL: https://github.com/apache/lucene/pull/301#issuecomment-945829893
Hi @mikemccand , I've updated some of the descriptions, can you take a look
at this pr?
--
This is an automated message from the Apache Git Service.
To respond to the mes
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430044#comment-17430044
]
Dawid Weiss commented on LUCENE-10182:
--
I like this explicit version better. [~usc
mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731013013
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -1033,7 +1030,7 @@ def
confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
os.
mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731013013
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -1033,7 +1030,7 @@ def
confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
os.
dweiss commented on pull request #392:
URL: https://github.com/apache/lucene/pull/392#issuecomment-945885397
I've corrected the setup to configure the signing plugin across all projects
- this should fix the problem. It works for me locally (with gpg), although on
Windows it displays concu
mocobeta commented on a change in pull request #391:
URL: https://github.com/apache/lucene/pull/391#discussion_r731075943
##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -539,58 +529,72 @@ def unpackAndVerify(java, tmpDir, artifact, gitRevision,
version, testArgs):
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430077#comment-17430077
]
Uwe Schindler commented on LUCENE-10182:
+1. I approved the pull request.
> Te
dnhatn commented on pull request #389:
URL: https://github.com/apache/lucene/pull/389#issuecomment-945953376
> Seems a lot easier to just test this via SORTED_NUMERIC. There isn't any
point in testing SORTED_SET as it only makes things more difficult.
@rmuir @jpountz Thanks for your
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-10182:
--
Assignee: Uwe Schindler
> TestRamUsageEstimator asserts trivial equality
> -
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430123#comment-17430123
]
Uwe Schindler commented on LUCENE-10182:
I will merge this later in the evening
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430157#comment-17430157
]
Dawid Weiss commented on LUCENE-9997:
-
The smoke tester writes a repository-local fi
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430165#comment-17430165
]
Dawid Weiss commented on LUCENE-9997:
-
Also, the beauty of gradle is that we (in the
dweiss merged pull request #392:
URL: https://github.com/apache/lucene/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
dweiss commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946072163
I merged with main where the artifact-signing changes landed. The
buildAndPushRelease.py works for me (although it does create that stray file so
I suspect it won't run properly unl
mikemccand commented on pull request #375:
URL: https://github.com/apache/lucene/pull/375#issuecomment-946076421
OK I think this one is ready -- I downgraded all `// nocommit` to `TODO`s
and merged in `main` again.
For some reason `./gradlew check` in my local env fails with this:
dweiss commented on pull request #375:
URL: https://github.com/apache/lucene/pull/375#issuecomment-946079849
gradlew clean only cleans active modules. packaging has been renamed and no
longer exists. Wipe all old cruft with:
git clean -xfd lucene
--
This is an automated message from t
Robert Muir created LUCENE-10185:
Summary: gradle check fails on java 17 (security manager
deprecation)
Key: LUCENE-10185
URL: https://issues.apache.org/jira/browse/LUCENE-10185
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430176#comment-17430176
]
ASF subversion and git services commented on LUCENE-9997:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430179#comment-17430179
]
Stefan Vodita commented on LUCENE-10182:
I’d be happy to help with this. I saw
mikemccand commented on pull request #375:
URL: https://github.com/apache/lucene/pull/375#issuecomment-946100745
> gradlew clean only cleans active modules. packaging has been renamed and
no longer exists. Wipe all old cruft with:
> git clean -xfd lucene
Aha! Thermonuclear clean
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430189#comment-17430189
]
Robert Muir commented on LUCENE-10185:
--
The following patch seems to fix the issue
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430190#comment-17430190
]
Robert Muir commented on LUCENE-10185:
--
I also tried upgrading ecj from 3.25.0 to
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430193#comment-17430193
]
Dawid Weiss commented on LUCENE-10185:
--
Weird. Can't see why it'd generate a warni
dweiss commented on pull request #375:
URL: https://github.com/apache/lucene/pull/375#issuecomment-946114742
Yeah, sorry about it. We could add an exclusion to rat-checks but these
proliferate over time... When you're switching branches, git will leave
temporary files behind, it sometimes
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430196#comment-17430196
]
Robert Muir commented on LUCENE-10185:
--
[~dweiss] in the ECJ at least these option
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430197#comment-17430197
]
Dawid Weiss commented on LUCENE-10185:
--
I can actually see this warning in intelli
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430199#comment-17430199
]
Mayya Sharipova commented on LUCENE-10054:
--
[~mikemccand] Thanks for checking.
rmuir opened a new pull request #393:
URL: https://github.com/apache/lucene/pull/393
Otherwise, new java releases such as JDK 18, JDK 19, ... may have even
more new deprecations, the build shouldn't fail in such cases.
Note: I did a very simple suppression-fix for the AttributeFact
dweiss commented on a change in pull request #393:
URL: https://github.com/apache/lucene/pull/393#discussion_r731285380
##
File path: lucene/core/src/java/org/apache/lucene/util/AttributeFactory.java
##
@@ -148,7 +148,10 @@ public int hashCode() {
AttributeFactory delega
rmuir commented on pull request #393:
URL: https://github.com/apache/lucene/pull/393#issuecomment-946137876
thanks, i nuked `-source/-release`, just wanted to test that it worked
first...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
rmuir edited a comment on pull request #393:
URL: https://github.com/apache/lucene/pull/393#issuecomment-946137876
thanks, i nuked `-source/-target`, just wanted to test that it worked
first...
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rmuir commented on pull request #393:
URL: https://github.com/apache/lucene/pull/393#issuecomment-946139296
I am running `gradle check` with the latest commits on JDK-17 before pushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
uschindler commented on a change in pull request #393:
URL: https://github.com/apache/lucene/pull/393#discussion_r731292709
##
File path: lucene/core/src/java/org/apache/lucene/util/AttributeFactory.java
##
@@ -148,7 +148,10 @@ public int hashCode() {
AttributeFactory de
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430213#comment-17430213
]
Uwe Schindler commented on LUCENE-10182:
That's just a cherry-pick across diffe
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430216#comment-17430216
]
Stefan Vodita commented on LUCENE-10182:
Oh, I get it now. Thanks for the expla
rmuir merged pull request #393:
URL: https://github.com/apache/lucene/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10185.
--
Fix Version/s: main (9.0)
Resolution: Fixed
> gradle check fails on java 17 (security
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430219#comment-17430219
]
ASF subversion and git services commented on LUCENE-10185:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430221#comment-17430221
]
Robert Muir commented on LUCENE-10185:
--
{quote}
I can actually see this warning in
[
https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430229#comment-17430229
]
Vigya Sharma commented on LUCENE-10180:
---
I would like to work on this issue and g
[
https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430229#comment-17430229
]
Vigya Sharma edited comment on LUCENE-10180 at 10/18/21, 9:28 PM:
---
vigyasharma commented on a change in pull request #2573:
URL: https://github.com/apache/lucene-solr/pull/2573#discussion_r731346908
##
File path: lucene/CHANGES.txt
##
@@ -648,6 +648,8 @@ Optimizations
Bug Fixes
-
+* LUCENE-10008: Respect ignoreCase in C
uschindler merged pull request #386:
URL: https://github.com/apache/lucene/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430241#comment-17430241
]
ASF subversion and git services commented on LUCENE-10182:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430243#comment-17430243
]
Uwe Schindler commented on LUCENE-10182:
I merged the PR. Will check backports
[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-10182:
---
Fix Version/s: main (9.0)
> TestRamUsageEstimator asserts trivial equality
> --
janhoy commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946219082
> I merged with main where the artifact-signing changes landed. The
buildAndPushRelease.py works for me (although it does create that stray file so
I suspect it won't run properly u
rmuir commented on pull request #389:
URL: https://github.com/apache/lucene/pull/389#issuecomment-946248949
> Sorted set doc values don't have a docValueCount API, they're just
expected to return NO_MORE_ORDS when all ords have been exhausted.
Thanks, sorry I had completely forgotten
[
https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430276#comment-17430276
]
Michael Sokolov commented on LUCENE-10180:
--
It looks as if [~jpountz] posted a
mocobeta opened a new pull request #394:
URL: https://github.com/apache/lucene/pull/394
Suggested at:
- https://github.com/apache/lucene/pull/382#discussion_r729615274
-
https://issues.apache.org/jira/browse/LUCENE-9997?focusedCommentId=17430157&page=com.atlassian.jira.plugin.syst
[
https://issues.apache.org/jira/browse/LUCENE-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430278#comment-17430278
]
Tomoko Uchida commented on LUCENE-9997:
---
bq. The smoke tester writes a repository-
mocobeta commented on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946304048
With skipping sthe ign verification (`--not-signed`), smoketester stopped
here for me.
```
unpack lucene-9.0.0.tgz...
verify that Maven artifacts are same as i
mocobeta edited a comment on pull request #391:
URL: https://github.com/apache/lucene/pull/391#issuecomment-946304048
With skipping the sign verification (`--not-signed`), smoketester stopped
here for me.
```
unpack lucene-9.0.0.tgz...
verify that Maven artifacts are sa
[
https://issues.apache.org/jira/browse/LUCENE-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430349#comment-17430349
]
Dawid Weiss commented on LUCENE-10185:
--
It's fine, really. This is what struck me
65 matches
Mail list logo
