[
https://issues.apache.org/jira/browse/LUCENE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430213#comment-17430213
]
Uwe Schindler commented on LUCENE-10182:
----------------------------------------
That's just a cherry-pick across different upstream repositories (the code must
be cherry-picked from new "lucene" repository to the "branch_8x" of old
"lucene-solr" repo). It needs a rather complicated setup, so I will do it. I
just wanted to know if you think it's worth.
> TestRamUsageEstimator asserts trivial equality
> ----------------------------------------------
>
> Key: LUCENE-10182
> URL: https://issues.apache.org/jira/browse/LUCENE-10182
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Stefan Vodita
> Assignee: Uwe Schindler
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{TestRamUsageEstimator.testStaticOverloads}} has serveral lines like:
> {code:java}
> assertEquals(sizeOf(array), sizeOf((Object) array));
> {code}
> Both calls to {{sizeOf()}} fall back on {{RamUsageTester.sizeOf}}, making the
> 2 calls identical. Instead, we would want one of the calls to go to
> {{RamUsageEstimator.sizeOf}}.
>
> This issue came up while working on LUCENE-10129. A possible solution, as per
> [~uschindler]'s suggestion, would be to remove the static import
> {code:java}
> import static org.apache.lucene.util.RamUsageTester.sizeOf;
> {code}
> Instead, we could be explicit on which method we are calling, like:
> {code:java}
> assertEquals(RamUsageEstimator.sizeOf(array), RamUsageTester.sizeOf(array));
> {code}
> This could be replicated for other potentially confusing cases in the test
> class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
